Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Wan Jiabing <wanjiabing@vivo.com>,
        linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
Subject: [PATCH] phy: hisilicon: Add of_node_put() in phy-hisi-inno-usb2
Date:   Fri, 15 Oct 2021 04:01:51 -0400
Message-Id: <20211015080154.16016-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x7s17ndFkEeeYaGaPmSQ5snwMj9eJiSt8tNaZ8GMcsSvVDsNjJ9/kl6qk6Ng?=
 =?us-ascii?Q?BpAu1wV/uK8fv/paVy/938lU2aDPZJ6fmUzUISs9803/14xG2fUSvfhiWamz?=
 =?us-ascii?Q?aANKRT5l50aRFZabnN1plEQzHUz9KAoHBGpDIvDvSFgilL2con0XQ5lTo3fs?=
 =?us-ascii?Q?RmPX4E2VWHqvyVbI0StQ7F8ByiFtgtSn0w+/Q8HENAXJyO7fn93O1GQK4OgK?=
 =?us-ascii?Q?ffEpjGqo4/fEhNq5QmPj8h7ikxF+d2M2Jsrd5emlzLRxmvzt6EPFFekXyAjZ?=
 =?us-ascii?Q?wOgEXbShBE7SGLFqRGxKy279wpJsqOepd7mUyMolYDahkJH9e91h3RJrakPq?=
 =?us-ascii?Q?Iddp5MeDsJQ+WZPDwauiMBCwTfwVH3dVClX6dzxdOEjxUVYi/290xlgDp7k9?=
 =?us-ascii?Q?FWol90U/NFXNKzDOyfIX98Ew14crDvNDTu5ShYCW7aLrPBq8xnw+hGGGRFLW?=
 =?us-ascii?Q?lnt3F2dceMVxFlO348+8uN919qQoGPWDkx2WsORquDWur0BXp5mYayxrcYOC?=
 =?us-ascii?Q?8pvn5FS18rGnjD9ha168uYpqsiCKsgXk1w0m+i45OeyxzKpghABgEwR9uiHs?=
 =?us-ascii?Q?avl4PEPeOWaMiYInI4KBnVWPMf+NinR76k1Q9ItbH0WRACxwyLm57Urjb5lF?=
 =?us-ascii?Q?vLQSEhtPTOqeuZ30uGAXIVuYkN0C9s6dyhxb8NVVMcQbeqL2KYTHGEYxKh6b?=
 =?us-ascii?Q?fn7hdMLUqU2bNNQFpHhPdzdWwtjsz54DZPpRyp6c5aKea8eMzHHrZTKrafB2?=
 =?us-ascii?Q?ZhJJC8au60Uy3iC2xdEcobZjxhQ8KoLL8DAlkbu124pqbUrE1gVI3VPbPqMP?=
 =?us-ascii?Q?WsdVLLLc22QtEisZ/wi3ItxGm0szM72wDN18rH6utJP7KM8xqyxuuM7SJicf?=
 =?us-ascii?Q?c1tXax4L9Xd5tQc2+IS7DbagLYs3Rkz43uKPyzqUzhZzqRU9u11dlxvMzKK/?=
 =?us-ascii?Q?RsLI39tWBcPJjl5eHf3Un3nRbuNGebtAvczto3c4h12znsLHzbpo0wc0fhjj?=
 =?us-ascii?Q?HGf7HWsgHBhtvLEGPY5fVRTuA/50iqBJezWbENPbZKtaUn7XTA7yuE5efrMq?=
 =?us-ascii?Q?aY/8zfXmj7g/e2JHq3nL7ohinPvVvGdfoAZnScP8lfh03Csrn9NFVYzH9Zf6?=
 =?us-ascii?Q?5MozyaEo3hc+4atBcPDMgszf8gGlBt4uw1/gFIiLFbGlZh/9y3+uhNgF3ghW?=
 =?us-ascii?Q?MRGm54VyY+tFG38YdVoQc/rIh+inx75nirUrox2HUt69fFmjErBDdt7lMrKf?=
 =?us-ascii?Q?9fKXxpiyWoILNBYaH6dGGPtPOYpedVkHT4C55A8gXGVCgM5pknhTMKe6tRGL?=
 =?us-ascii?Q?Q/hjzOUBro1l8UJLb0JMF7RN?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0237720-f743-4957-07ce-08d98fb22114
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:02:27.3766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jf8wQKLK2kH0iqQZu0AmA+hIDxF9b5eYMSNOd47YUhsDOjm45ULUkiIu5jjc9N+p78X7K0s78gc7iX3xD/LWfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3191
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before break

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/phy/hisilicon/phy-hisi-inno-usb2.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
index 34a6a9a1ceb2..b133ae06757a 100644
--- a/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
+++ b/drivers/phy/hisilicon/phy-hisi-inno-usb2.c
@@ -140,14 +140,19 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
 		struct phy *phy;
 
 		rst = of_reset_control_get_exclusive(child, NULL);
-		if (IS_ERR(rst))
+		if (IS_ERR(rst)) {
+			of_node_put(child);
 			return PTR_ERR(rst);
+		}
+
 		priv->ports[i].utmi_rst = rst;
 		priv->ports[i].priv = priv;
 
 		phy = devm_phy_create(dev, child, &hisi_inno_phy_ops);
-		if (IS_ERR(phy))
+		if (IS_ERR(phy)) {
+			of_node_put(child);
 			return PTR_ERR(phy);
+		}
 
 		phy_set_bus_width(phy, 8);
 		phy_set_drvdata(phy, &priv->ports[i]);
@@ -155,6 +160,7 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
 
 		if (i > INNO_PHY_PORT_NUM) {
 			dev_warn(dev, "Support %d ports in maximum\n", i);
+			of_node_put(child);
 			break;
 		}
 	}
-- 
2.20.1