Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Marc Zyngier <maz@kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] PCI: apple: Add of_node_put() before return
Date:   Fri, 15 Oct 2021 04:09:20 -0400
Message-Id: <20211015080920.17619-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ug7MapRZP3D8FKG9zcL9QxBmuhCI2CkmqCUoqsRoE+mVt2n3sQDKRP3DQRru?=
 =?us-ascii?Q?DloI7AZREWWKjeG2DVuoW4UbKYQN2O5G1wBBrAG0CIcmx7yoKAb0O2qMVWH3?=
 =?us-ascii?Q?Fe9RYizz5JBk85hrsJs2nz9ZpVs0NMLWM6HaQmUehmSyuByOhiN17l4SeJvS?=
 =?us-ascii?Q?wjvJgIJ1syRbYBoz3mKo972Exhrq/6u6pBMJ+3adtvKWQY9DbxN+JZxkiUyK?=
 =?us-ascii?Q?rnKeAnfZJ5OWv85cTLEl+QgBQWntsc9n0IOIAvMwExfENmWJdq/gtPyxRzpC?=
 =?us-ascii?Q?g+dyxfrwritJa8EjwRhD8dyl4/DRl0WVNMReKA81kQddS5SaXA3nbjAiwWB8?=
 =?us-ascii?Q?ZXATrjhi3w1fSqJoeNOl12Vh1Qvo40QsxrZMz3lAQfd04pDvSMrIkZ0O43FU?=
 =?us-ascii?Q?/NwoDL7XOqvdHj7M7S4EuYW3a6dP5pJURCk38hGZ9y8X/UdiFLDfSiBnRjvU?=
 =?us-ascii?Q?1x00qB3QFWm9pdcON8B1Ftdrc9uAD9FxOlWJ9/OnTAwShxkVSu+PyrqkQiFF?=
 =?us-ascii?Q?ISiHYOisQDL5RUrFqvWlcBcHNOCm0AJNeTMa2UPa4BbLJgqyH0D2xqy00vhl?=
 =?us-ascii?Q?BxuqfuMRt1zNMceqk+5SWrX2cihEPqtzulh/X9zYocp6FszHvDa72XkfzIcS?=
 =?us-ascii?Q?erw7Msnm5PsFXZH1XldFp5z8KF9JFaeDtvUlcgukx88bqO5tsbwIwszfnauy?=
 =?us-ascii?Q?FMIgWJvVg4MeJnfVl9+shOzz0mA3jWuBbtg587kwiyUsdmjdzit6ntjGQuuH?=
 =?us-ascii?Q?uV6whgs97LxVylNGgi4fYDElFrttS1vQl17GRSOuSKSi4jFcZPFzyWwzFin8?=
 =?us-ascii?Q?y8Rfo9ziu5Lz5x5bLyG1d49bIWc9kSwk9v2LmeJLXHDJI5bZ7CR4ztdsKdkm?=
 =?us-ascii?Q?kHBMMlpVFFN1bTB5La3QtGMjVvWB5v55b+q5qs05BEPk+J2FUlUrxI7w2X20?=
 =?us-ascii?Q?h+f44ZRLnyptcBSDd8ytqKTuk1pMEWPisAIijKp9rv4Zg54pmGTq0wAPtPtA?=
 =?us-ascii?Q?MbC4wMJG96onEBN9U92uyUvJVglq4y6ZVYq40xvbyGEuE2HU0bgCzoT/f7EB?=
 =?us-ascii?Q?gxxn2zN4/YS5hUlAKok9bEyPPMZCx67MXlT/JM50XaTmLmlDhnoJ0pt9mZZD?=
 =?us-ascii?Q?Tiaj0JLgA2UmrfE48g4RJwOzdZ7wWYM9ZWTCkbUe5ejoQWPdjZY6lcZQBIfX?=
 =?us-ascii?Q?2BJiqQGV/B7EKfdWSTIBbHM8otTx4BKqsOkDi7s7YkaXcKLxsDx2NvBy5Txm?=
 =?us-ascii?Q?0lNAPslzfaSo8VGuHd18i5MqNJjGn7t5yXvOzOv6jx1DczUbCQ27dxZ9hahL?=
 =?us-ascii?Q?rfpWpolhiYWDLy/fEng6BkX0?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e11c770-b149-42dd-767e-08d98fb31f9b
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:09:34.3974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NeKDtPwXikgajuAxsEk0gKaUbVkdMMVff1S247lSpkb/YSEoK0fkRW+YekffCrP8HXFtL0aWwCWhrPtjvmJHNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2778
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/pci/controller/pcie-apple.c:771:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/pci/controller/pcie-apple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
index b4db7a065553..13101389e988 100644
--- a/drivers/pci/controller/pcie-apple.c
+++ b/drivers/pci/controller/pcie-apple.c
@@ -772,6 +772,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
 		ret = apple_pcie_setup_port(pcie, of_port);
 		if (ret) {
 			dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);
+			of_node_put(of_port);
 			return ret;
 		}
 	}
-- 
2.20.1