Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] of/unittest: Add of_node_put() before return
Date:   Fri, 15 Oct 2021 04:26:58 -0400
Message-Id: <20211015082658.19005-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TeHQjy6i9USfC7Y2BgWTKmkF0UfvQNdaDYAsuztcGEgxyHP65HDw/e492h87?=
 =?us-ascii?Q?rmU7qP+yib+0g5BcOXz0DiNry3YvCYGgO/8u/bwYxxS77Mc5mjwtVSvZf6WL?=
 =?us-ascii?Q?mDKL+odflhhfCwZzrwTJfoyZbAklOFMLok3JUMEqzxDHdWDxVvfOmrdemzTy?=
 =?us-ascii?Q?LHMbn2aSoRIzJn95l2iPnSKoa5+bMMtiSkGuHCCZKJ71YgqIjI9yiHkh16Xm?=
 =?us-ascii?Q?8ISnTxma50Ia78M1o2NZv9dre9Z+jinCNAN2jDerSz7Sg9sTyCyrdWLVCENK?=
 =?us-ascii?Q?BsaJCsIPiMavXYaKF4kBlFXtyzjOu8pSvHOuMiC/z5ERPu3pIlsNv4RN31tS?=
 =?us-ascii?Q?ebLBOddcasa5dApfaoaJ1uo12DERyH3CTfCftn56CzfcWWMHX+mBYjR9fWs3?=
 =?us-ascii?Q?2EQvGfBopyY9gYUfB2g1UX/a6wFKPjtz/M5pLz4L5SSYZqnwhzNlge6GKJCG?=
 =?us-ascii?Q?XEgFax3Pb1VSTahvOx93bOZdc/l4H09z3h7T7MyEj6FIoXy1yz4f+FcIAX29?=
 =?us-ascii?Q?htZE+7+ftHubXRRSc9qqQtn4YV6sNuvYQWFTQ2tTn6jI6RuHuI8A8/kXyyOa?=
 =?us-ascii?Q?6ivVNqUITNFvPcBg9cIAJpx1bYzgGnsWp9f7Bzq+V/DtqzE5rlyiIfdmEvn7?=
 =?us-ascii?Q?9FW3nj23Iqmy3oF+DF/355oObmyAN7Cffz16snfMZy8T/fAis4D4jWtgS/OT?=
 =?us-ascii?Q?fzTOnVZEjRhd1H9rxjUysUsc5LBjY5XSs4cd5++yY0be9/WGT6DvUpkl+r66?=
 =?us-ascii?Q?l04U+ctOHDgIMnbUx63btJt4ja2cO3eI7qHdEJtLO0kk4TCNry32LRYy40zm?=
 =?us-ascii?Q?Im5ahvwyhHdSR647gX7X+iMJkRKs54R6ZEi2MQOyyy9avDxWy3coQH2RGfNG?=
 =?us-ascii?Q?XzKq63mQGDbE1MFdle4KciU5DUdSeTc9kcAGU/pTeI3sjShZZ/IpFlIqApYN?=
 =?us-ascii?Q?wb8XooGjRV0HJ/aUdhnzPdpqH4ClrMMDluY+8SGQqWx9d4k0OQm5p7Id1Ui1?=
 =?us-ascii?Q?7PZaX41oZERU/xyxd4jt9j8og8k4hog/mGJs65O6AVxJhaI72ULqh4/l0WU4?=
 =?us-ascii?Q?4cuZz97Lc83c6+QRPoFrAGrnNvStgxZJbGsGqUllsoGbNI4KVN2ENOrhj/nG?=
 =?us-ascii?Q?BfsD4bd/DmlfVPm7IzH51llghzujc0JNAFHjdGhj3W0oVzb+NF04jb/I3auK?=
 =?us-ascii?Q?W+ZYS8Rcjdr7hCemPu0IdwVaN2JFzogGNZliPwNrj0sAaFfPf22xLyEk5vto?=
 =?us-ascii?Q?tdyyrpj0WxtKYqwv79YJLf8pFjfspI8NyG8uYUSkx/QqFPxdSLTMaKdscJWz?=
 =?us-ascii?Q?wR6vO9kDI14jFpO6Rq/6vLkV?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac9b53e-1280-4c44-86b0-08d98fb5a632
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 08:27:39.1976
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 18ia7ymOnAkktX4yb8ZmevhF6vK+Ivjjq+GzZVT31yOIzlr1lkACKovMq5szshuliN5gCyxV3xtVCYbvssYlnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1951
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/of/unittest.c:3091:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/of/unittest.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 8c056972a6dd..b8d2b669408a 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -3094,6 +3094,8 @@ static __init void of_unittest_overlay_high_level(void)
 			if (!strcmp(np->full_name, base_child->full_name)) {
 				unittest(0, "illegal node name in overlay_base %pOFn",
 					 np);
+				of_node_put(np);
+				of_node_put(base_child);
 				return;
 			}
 		}
-- 
2.20.1