Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 Oct 2021 12:43:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: Avoid bitwise vs logical OR warning in
 hfa384x_usb_throttlefn()
Message-ID: <20211015094344.GQ8429@kadam>
References: <20211014215703.3705371-1-nathan@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014215703.3705371-1-nathan@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SvkZMQ/BUkPxIyLIgkElO6odrk6HxR4VKrs5wAGq6loiCf5JRb4wHHA2UXal?=
 =?us-ascii?Q?/SxectQzvm8oT4JcHdpQqHYd/5oEge9iXKW4kKl4C3a3L3dUJkB/WvOz4BRl?=
 =?us-ascii?Q?3j05oqnEKLY2V0J0laaiWc5O4Yn16MVnhBydnJVsqTTrmTt47+zuAMJ4mr5e?=
 =?us-ascii?Q?/+DVptoU6Xto9upCtyHGwTBQG25Jocz7G15sGLfvdsIP04cMdWU/8CG8lRKx?=
 =?us-ascii?Q?PIKrYPVnr7+klkDkL0M34RBg3KaED8VVZGPTLazeSym24A1vj1O6dz5UoLSL?=
 =?us-ascii?Q?K3Mu9cL8oLaltcpmH2YzCuQXuR/z2iNde+DeEronN4TMH5pR5dfr0iEC1hen?=
 =?us-ascii?Q?mTpLQww4estfJqfwcD4OEXXrnFSggvFuHEEvZ4I5Zi3ueVwa1dEBU6BsP6UF?=
 =?us-ascii?Q?sF8qAkKTPGrmlEn/ZazyPbOyAi2by4p6oy8eQUuwvcW9pfNSKr9DPbTkIW8c?=
 =?us-ascii?Q?LoA6/g00zSb0Nc/iyYoceGqQoU5aPV4Pap4n2bC4K2svSk+JobLQRLBNERb+?=
 =?us-ascii?Q?n+EEE+eC0tw9KR8Z2RYAGT+9LiR8V2X2tPtgFrY/o0VWFg3AIyAJ5g5sLKVR?=
 =?us-ascii?Q?EAEmWzA09s7p9kjkMhOAl0q7r+YXDwPPafrYN/y7XsyqfM+a6q6Ecz1OmRMv?=
 =?us-ascii?Q?nnboJOf8QqzvUC01h5bXqG8U2wE5TLi/ztkwAxuNFgJVVfoZ7JbJL2nVpmzT?=
 =?us-ascii?Q?N8E3bpP7pNr2Mp/xJmjINb9rCKrF6iBLWGmmvpxtw5phIqdsSi1iGcrsZ84O?=
 =?us-ascii?Q?+mSjE5v2rsc8WBgSJ8RTH2xQUEtl4GXeMDdu5Ta0ac11EAGu7hX7cLxFoXf/?=
 =?us-ascii?Q?oQTppJg8EtDYvtMygiVs7MJDivLJbd6HAqzyS4Y7bGrMRuJtTMZIfB8DH/Kd?=
 =?us-ascii?Q?lY9Re09raIGXb+SkZCYOx0fnUkI0my+bcCSR8ItoOTB0fJ9yeVhY3h55GEU6?=
 =?us-ascii?Q?ojBXv0Vo0NFgKTNFs6E9UUpoAn1kggQ1xJHMeq0NW2U+OsWBbHXHVrqmiuq1?=
 =?us-ascii?Q?IVNNrpA3V3p2+ELybQs94R3Ox/+NrnyNwISqHhhZr6JoXd+/A9zM8o5wnNTA?=
 =?us-ascii?Q?rvJX7mbweWSM3x2Z1Zun+EVLdeoJYtrb5kFcQYmCTos21h9StGrU+Xk1idOr?=
 =?us-ascii?Q?3Scs38BZO1C4Jj+lkk04Vwj79ulVCsJ5MmV9enDHsFAP3pBRNkyjKh2C/lmo?=
 =?us-ascii?Q?KjFIfMXKmjDIj9Vf0ddAR9TdAwOdrS3qOdUmNHk8GfEyg2TIueO90HKVW9op?=
 =?us-ascii?Q?r2QLEN3sEbQeAkegmLbEujO/T7oa59ZjoWkgSa+pRR0h+wQDNEoGUvhsiLDV?=
 =?us-ascii?Q?RnarGRPQerkVGhiQvj1RTpOs?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef027e86-d7bd-4df4-80d9-08d98fc050ec
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 09:44:00.7573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5eWyFC3Tc422fWlwoHMuYEdlH+onBBG9LRf7cYC1zXXg72/y6FPohTC5HWf2+qaUsXCpKIECAvJofQF4u7Lv7T2WXw825eJjtsA+/yxdDDE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1888
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10137 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=974
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110150058
X-Proofpoint-GUID: 1nSXDdkPCQZ4VNIgrqps8rfaWTksFGsZ
X-Proofpoint-ORIG-GUID: 1nSXDdkPCQZ4VNIgrqps8rfaWTksFGsZ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 14, 2021 at 02:57:03PM -0700, Nathan Chancellor wrote:
> A new warning in clang points out a place in this file where a bitwise
> OR is being used with boolean expressions:
> 
> In file included from drivers/staging/wlan-ng/prism2usb.c:2:
> drivers/staging/wlan-ng/hfa384x_usb.c:3787:7: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical]
>             ((test_and_clear_bit(THROTTLE_RX, &hw->usb_flags) &&
>             ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/wlan-ng/hfa384x_usb.c:3787:7: note: cast one or both operands to int to silence this warning
> 1 warning generated.

Both sides of this bitwise OR are bool, so | and || are equivalent
logically.  Clang should not warn about it.

regards,
dan carpenter