Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp581793pxb; Fri, 15 Oct 2021 11:29:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWjJZrMbmdwNlfQK+GUU4AIcZI/WYGAzjhgjJZ7LXjrHl6NIuQeu8mq4SGpV3b6JR3i2gH X-Received: by 2002:a17:90a:6fc1:: with SMTP id e59mr30260922pjk.103.1634322544291; Fri, 15 Oct 2021 11:29:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634322544; cv=none; d=google.com; s=arc-20160816; b=Q1nWy/b8k+7z6OvXCPOzo5Q+6kFco1jIuN7YJmHwP321ua+ue/mzdF+wmCtpAzTw67 5lSNG3XhtMkpvD9SSjDKwZrC77hVGDQ1u3i4D9MNI7BN5CSedJcjz6cjyc/QYC8qPv/1 o9XaK5gsF6cuLiD+IFjWhBi6w021HYI4loH55KIZ3faphsTvNbv9rIXuenwhLgpy5SvJ 5kBkv+TYEoDZ11Fbe2pL89p3rdDjmjLpKNiVkhej6lPHaFdWlGfiLVvrvkRHeuBEveQw SNw5W5lg6u1GvUTNwzTn8RcEZcpbzycfF8FERselAdc305nSi13QQpm6z5Oc1KvBkGkN UY+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=kv94Zkwy2UuD2nMM/YTTr3yTG2ucsSbWqrfNNeuNyhg=; b=p6yJ4j8FIkDFISOHEO8UUVQTwoq6vKNUHKjIKLtyN+TH5sycCDGj2490MKtgvSf1+O EhF2QqW31cldfVGXW6xUu7JWumG/+32FiaLvX8mZNOdSqo63FsVqIWjOFkGl8m7hGp3c gsZxJgB9ACmLJTBns6NAksyIw2YYlgA8B1AA+19J3KNltEyJBwU7H3Mh2TNLXt/FQfK/ TzDScTQWtcXsHjVFz1cW1N+ZIq/rDJ3SAoafeCBHXgW267y9GkAufTg8T0Lu5plF6jEo Pf0TzGvdovlasRMJOyob5osFCVp1yv6Bo4qzW+xcfxOIT0pHsAKloQYYt7N+LMzK/0R8 k8AA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id na3si10629086pjb.190.2021.10.15.11.28.51; Fri, 15 Oct 2021 11:29:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237823AbhJOKM2 (ORCPT + 99 others); Fri, 15 Oct 2021 06:12:28 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:38828 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237769AbhJOKMW (ORCPT ); Fri, 15 Oct 2021 06:12:22 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0Us8X9Kw_1634292611; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Us8X9Kw_1634292611) by smtp.aliyun-inc.com(127.0.0.1); Fri, 15 Oct 2021 18:10:14 +0800 From: Jiapeng Chong To: yong.zhi@intel.com Cc: sakari.ailus@linux.intel.com, bingbu.cao@intel.com, djrscally@gmail.com, tian.shu.qiu@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] media: ipu3-cio2: Fix missing error code in cio2_bridge_connect_sensor() Date: Fri, 15 Oct 2021 18:09:15 +0800 Message-Id: <1634292555-66006-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. Eliminate the follow smatch warning: drivers/media/pci/intel/ipu3/cio2-bridge.c:242 cio2_bridge_connect_sensor() warn: missing error code 'ret' Reported-by: Abaci Robot Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") Signed-off-by: Jiapeng Chong --- drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c index 67c467d3..9e364ba 100644 --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c @@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, goto err_put_adev; status = acpi_get_physical_device_location(adev->handle, &sensor->pld); - if (ACPI_FAILURE(status)) + if (ACPI_FAILURE(status)) { + ret = -EINVAL; goto err_put_adev; + } if (sensor->ssdb.lanes > CIO2_MAX_LANES) { dev_err(&adev->dev, -- 1.8.3.1