Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211014151235.62671-1-colin.king@canonical.com>
References: <20211014151235.62671-1-colin.king@canonical.com>
Subject: Re: [PATCH] media: drivers: cx24113: remove redundant variable r
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Colin King <colin.king@canonical.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org
Date:   Fri, 15 Oct 2021 12:01:26 +0100
Message-ID: <163429568660.4164224.1248800864545725818@Monstersaurus>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Colin King (2021-10-14 16:12:35)
> From: Colin Ian King <colin.king@canonical.com>
>=20
> Variable r is being assigned values but it is never being
> used. The variable is redundant and can be removed.
>=20

Indeed, it gets re-assigned at line 385 as the first cx24113_readreg.


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/media/dvb-frontends/cx24113.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/dvb-frontends/cx24113.c b/drivers/media/dvb-fr=
ontends/cx24113.c
> index 60a9f70275f7..dd55d314bf9a 100644
> --- a/drivers/media/dvb-frontends/cx24113.c
> +++ b/drivers/media/dvb-frontends/cx24113.c
> @@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *sta=
te, u16 n, s32 f, u8 r)
> =20
>  static int cx24113_set_frequency(struct cx24113_state *state, u32 freque=
ncy)
>  {
> -       u8 r =3D 1; /* or 2 */
> +       u8 r;
>         u16 n =3D 6;
>         s32 f =3D 0;
> =20
> --=20
> 2.32.0
>