Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211012221144.30638-1-rikard.falkeborn@gmail.com>
References: <20211012221144.30638-1-rikard.falkeborn@gmail.com>
Subject: Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>
To:     Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>
Date:   Fri, 15 Oct 2021 12:12:20 +0100
Message-ID: <163429634048.4171071.2327108342733912267@Monstersaurus>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Rikard Falkeborn (2021-10-12 23:11:44)
> The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(=
),
> which takes a pointer to const v4l2_m2m_ops as argument. Make it const
> to allow the compiler to put it in read-only memory.
>=20
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/staging/media/rkvdec/rkvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/medi=
a/rkvdec/rkvdec.c
> index bf00fe6534a3..28aab5c7fe33 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv)
>                 rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR);
>  }
> =20
> -static struct v4l2_m2m_ops rkvdec_m2m_ops =3D {
> +static const struct v4l2_m2m_ops rkvdec_m2m_ops =3D {
>         .device_run =3D rkvdec_device_run,
>  };
> =20
> --=20
> 2.33.0
>