Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     "dsterba@suse.cz" <dsterba@suse.cz>,
        Wan Jiabing <wanjiabing@vivo.com>
CC:     Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kael_w@yeah.net" <kael_w@yeah.net>
Subject: Re: [PATCH] btrfs: Simplify conditional in assert
Thread-Topic: [PATCH] btrfs: Simplify conditional in assert
Thread-Index: AQHXwbCaz3obs/f52kqrDQCLyWuaHw==
Date:   Fri, 15 Oct 2021 11:41:20 +0000
Message-ID: <PH0PR04MB7416FC5DCB8276A9E33DDAE09BB99@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20211015103639.21838-1-wanjiabing@vivo.com>
 <20211015105154.GC30611@twin.jikos.cz>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bZj54DAKseVfAmONG2aucywfeYBr5rq9IIXG3wCJhUWU/NwXFxOx03vHtu5d?=
 =?us-ascii?Q?sEzF9xqR/62/tMk8/7v8ldRBfNHBOKslLnN1doWxdi/r/nC8/TdB1wWfjN81?=
 =?us-ascii?Q?udJKFhXS5H+/FLGvQsoLs6OCTfz6S3DfWhNItDXVW9f8+X2ztHarEWZaQNKF?=
 =?us-ascii?Q?q/59PL7LrgTKYPZEBjUVlNC6/nhjhBDyHK56Go+bckvdct9hnRS9a2tB8zgJ?=
 =?us-ascii?Q?jvI30IhVZ6z88z1NYBfQFouj+kGm32Pxz073jprgGOyeHaIaXKQjxYVK2av7?=
 =?us-ascii?Q?EY5D9HMDQFtyEGIj4iu2ubJtTQlCgxu2OJcYMiAcJkAanDBZHSWoZUMw+El6?=
 =?us-ascii?Q?8kVuWopjG176Ay2/upvJvibTt8V5gQQRTVHsCKq3Caby+UWwDhRwGq3m+4NV?=
 =?us-ascii?Q?SGk7oAtZuBuDArQKaI7sdb4VS32eFrUjlE7PKiLb75nHK3OcezODiULPOszr?=
 =?us-ascii?Q?3QeRdWt8uNLz0X+XmjV/zUR8h6Jn3qOpTPGQxNcn2U8ajvxLD2cRqLFjSN2r?=
 =?us-ascii?Q?0Fc3DdbHV4qn5wZ+GgTF3tTfOG+w+8xfaVm+Lp63k/tmWqHn+dCDfXnpbT2y?=
 =?us-ascii?Q?dANv6kgamthLe13Ks11LYOoC8qwb6jbQ0e1DukGMs5ah3l1j2AV+EoMSFQus?=
 =?us-ascii?Q?LTCHJN1AcxPRhU4Yb6QbsPgxNdfqAzopKXjSbmypukoasV+hgQirhXoLuNha?=
 =?us-ascii?Q?W9ViuAtdi95CHAT/wTccdJuzjZW0q0GVdiQGwKWGuhUkqEWpXVH29vLupb1C?=
 =?us-ascii?Q?X1CXHWMpORP57GbWM+Ggs1Yar9oU++MQroV/N8Fkxb6TyWP7ruZJlBLRxDmH?=
 =?us-ascii?Q?X7Yvdc9aMM0bGcAFJuLILTXimBEG4QMEz/tBZGE7HCkuwQ+u6nCtY/aCp91w?=
 =?us-ascii?Q?KOoAURf7jS3yr2u5zLsjp9Xg9E/2wdeoI3dl4zzdaFmdRzqo9U42e4Bxgl2G?=
 =?us-ascii?Q?QrZ/mg+zbDYih40PV7jfbrmSc5YW81WPdH+Qrdu5KG8ZjnS9wkCJ6QK/1wow?=
 =?us-ascii?Q?ZoN11RsMd5dY6BhcBpbleKUsP0iE2s+lqWaLZuhNYOgu2y8VFvNFGoGLqFuJ?=
 =?us-ascii?Q?keke1732PfWvlkzn8xT/oBIA6SW5hJwSc/44jbkiM7AFi3t4sJXvR005446p?=
 =?us-ascii?Q?7oLvIRtV6jeHWHlLoPWEkWQL9PArs86VcwL5OirZGdSAgcihxTZEfnnB2wZQ?=
 =?us-ascii?Q?bxDyWdWGEqsq01jxq+yxe+6Mnun3bCVgjG7R4W7RsovTrO8FE2qeaNnDVk2D?=
 =?us-ascii?Q?t7IhOe/YMG1RUI8hgWADN2ENGw59b7odQz/5JE5mAEdOWRvoIkpPQ6swvjCx?=
 =?us-ascii?Q?ccobxAr3nCwEJ3tXSSSCWooe?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b07b5a6b-c0c1-496d-b03a-08d98fd0b52c
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 11:41:20.3487
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NclNwMlVgGa+vLz81Ry8K8+UecPTn4qO39cM0jP3tQFrqjOCzSC+9TxclWfc0pZKEZ906cCPrTZso882iKx3V9iNXZ6t9gdNm7aHut/nFIk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7496
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/10/2021 12:52, David Sterba wrote:=0A=
> Adding Johannes to CC,=0A=
> =0A=
> On Fri, Oct 15, 2021 at 06:36:39AM -0400, Wan Jiabing wrote:=0A=
>> Fix following coccicheck warning:=0A=
>> ./fs/btrfs/inode.c:2015:16-18: WARNING !A || A && B is equivalent to !A =
|| B=0A=
>>=0A=
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>=0A=
>> ---=0A=
>>  fs/btrfs/inode.c | 3 +--=0A=
>>  1 file changed, 1 insertion(+), 2 deletions(-)=0A=
>>=0A=
>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c=0A=
>> index e9154b436c47..da4aeef73b0d 100644=0A=
>> --- a/fs/btrfs/inode.c=0A=
>> +++ b/fs/btrfs/inode.c=0A=
>> @@ -2011,8 +2011,7 @@ int btrfs_run_delalloc_range(struct btrfs_inode *i=
node, struct page *locked_page=0A=
>>  		 * to use run_delalloc_nocow() here, like for  regular=0A=
>>  		 * preallocated inodes.=0A=
>>  		 */=0A=
>> -		ASSERT(!zoned ||=0A=
>> -		       (zoned && btrfs_is_data_reloc_root(inode->root)));=0A=
>> +		ASSERT(!zoned || btrfs_is_data_reloc_root(inode->root));=0A=
> =0A=
> The short form is equivalent, but I'm not sure it's also on the same=0A=
> level of readability. Repeating the 'zoned' condition check makes it=0A=
> obvious on first sight, which is what I'd prefer.=0A=
> =0A=
> Johannes if you'd like the new version I'll change it but otherwise I'm=
=0A=
> fine with what we have now.=0A=
=0A=
I'm fine either way, no strong preferences from my side.=0A=
=0A=