Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp709372pxb; Fri, 15 Oct 2021 14:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJ294PwCpqqH6IZJT7+ZZLygWLYWxSj4nvsCUisFqjEBFrP6oQ5uDzN3NFsi+T6seph/U8 X-Received: by 2002:a05:6402:50d0:: with SMTP id h16mr20933838edb.303.1634333566035; Fri, 15 Oct 2021 14:32:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634333566; cv=none; d=google.com; s=arc-20160816; b=ZhAmN3nHh8zE6zLTSdqcOLL/mseBjHEU0dFIbECun5uZvsgIOyWJFpgCNBXTg0ltA/ XGJUMaZYCNk4FY53dURBt59n83nzKGs1rhx4RHvB7YOZ0fPvn8HNagXe0MCohW+Q+T1A vNJ2+bZMWfIVUHApuPlP65BUFc4LBq/rJ0planT1ONx31B/oUEsSho8qQzEMy67Ytiw/ 92hWyoW50wtEGbXRM6Ddp1zpoJzBNshsYfdRDOZJZOanDQRBXbHsDyTsEY6/GBAN2ugQ EXOXFOvhvXlGZxMHUruivqVxtFeY7D382WB6KntqiJJaXuRaCS/MEDhRozgx5SDtQ07n aOUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ihfz0jXlZwuHL87l5wK9+AFSx48nUR+ukAj9B84W2nc=; b=tvApK6BYcBA02wCKWWp+7/ogUj6pcDXRR0X5bPoFnQoSsoPu8nAzsL1V6LehjYCtpW NUdr7MfBfxVdwozTHiQ8NaF1MJnId6BUo590sfip2aMq4Fgw1cekDrfN9o4LSii1zLkB Jwv7EQBBcifHdMQR4le5b+zwxLe9IsH84Y4P7yoUAskdqnVd27WiOeD/Ili4PqVayfnz at237d0QwBjq5BIlbKQ5hhE6spE+cGQisYKDZMcUdDW7y3YOffGVDU5YMqeDhQjCRh3f h2TnwjNtbpLL3QSvG6lwi9ouwshkiOhn0fKVs5om8ba3IrrQxEm9Wfo8fwPb5szfYY3L EDjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qKte9AhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l5si9520995ejn.84.2021.10.15.14.32.17; Fri, 15 Oct 2021 14:32:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qKte9AhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238539AbhJOLsV (ORCPT + 99 others); Fri, 15 Oct 2021 07:48:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235360AbhJOLsU (ORCPT ); Fri, 15 Oct 2021 07:48:20 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4872C061570 for ; Fri, 15 Oct 2021 04:46:13 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id d11so6776130ilc.8 for ; Fri, 15 Oct 2021 04:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ihfz0jXlZwuHL87l5wK9+AFSx48nUR+ukAj9B84W2nc=; b=qKte9AhEalyQcx/QqP8xB9EOeoqrRNJsInfq+8x9T/9gWvJT8spvXicxCHAfIzmgtx hCMrg62Z3KcGSVHA5xAW3SWOim7rGsDhdya/C359OEwtNEuF1eFQWDYPRBZiY26sI3p0 jOr6hAOixjOYoLd8Xars3R+bxTA+Rfzm3X5etdOhifXfGrtTS37S0caKpqz81ipoqRFK tIpw5b0q7/IxKMGRaTpB+JZmCUadzKs84l4/nDSeOOcv0KKTT6bYhVIU41yKdFaM43Zu 6ZYwka3HVOW7VSECmqZ4QZQtlfDRfISN2upoCKdly9fAUmkLvAsdwNflNKwjGlGNFfgW kVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ihfz0jXlZwuHL87l5wK9+AFSx48nUR+ukAj9B84W2nc=; b=yQ0qrrIPiqg7YxS3Ak30bYWCNIsW93sAnbwmtZjSqPmNNuhWbMWCx3fMwwUv09Qapn CbcKJQIKmPNawJCG2GLuHtVYdQYFuIdh6oJtB5Hy1pVV+Ntm/8p16zWTyCqCExujWg/s fkUEpy3hXGdsLhUiq4xj6BfgNhFRcDHzySWd/pW7MemdvDC7pIpAqoiYJ1Ooy+719Zbr nhwNqKZiPHQJmeKFvNmCJv5xrvpn1k0eosftPFcwbIAtJaKp0i6I52anpVM0L1hIyB48 WrxuKMxy8VTdZn501bi7eqWoXU3zkCHpyMC6UIYJ7vAb5BDSnKPjkuj421XdX/9S4a4G v0rg== X-Gm-Message-State: AOAM533Rgc4+hqwycRosHgx7aE+OTMg1AlVpMHWwFJJCsUxzMjxk6Fh5 v8nzoWNXTCfmxwQMCdFojI6d7hIFDcdknmUlSPU= X-Received: by 2002:a05:6e02:2141:: with SMTP id d1mr3508167ilv.5.1634298373292; Fri, 15 Oct 2021 04:46:13 -0700 (PDT) MIME-Version: 1.0 References: <20211015083144.2767725-1-linux@rasmusvillemoes.dk> In-Reply-To: <20211015083144.2767725-1-linux@rasmusvillemoes.dk> From: Miguel Ojeda Date: Fri, 15 Oct 2021 13:46:02 +0200 Message-ID: Subject: Re: [PATCH] tools: compiler.h: remove duplicate #ifndef noinline block To: Rasmus Villemoes Cc: Arnaldo Carvalho de Melo , Miguel Ojeda , linux-kernel , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 10:31 AM Rasmus Villemoes wrote: > > The same three lines also appear a bit earlier in the same file. > > Signed-off-by: Rasmus Villemoes Looks good to me -- they also appear to be at the same level. Reviewed-by: Miguel Ojeda Cheers, Miguel