Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/3] locking/rwsem: disable preemption for spinning
 region
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, will@kernel.org, longman@redhat.com,
        boqun.feng@gmail.com, linux-kernel@vger.kernel.org
References: <20211013134154.1085649-1-yanfei.xu@windriver.com>
 <20211013134154.1085649-3-yanfei.xu@windriver.com>
 <YWlUZ5BlUZRA7LGR@hirez.programming.kicks-ass.net>
 <YWlV7gVnPColm61C@hirez.programming.kicks-ass.net>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <41448d61-8711-15b7-c120-7ce27e47134a@windriver.com>
Date:   Fri, 15 Oct 2021 20:33:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YWlV7gVnPColm61C@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWYvWk03K2ZKVG5WdDFZNFNLa3hKelMrZE9XWTJYaTlERGdzMlBlc2xPZ1JM?=
 =?utf-8?B?RWI2RnEyVDg5ZXNNME9kcTZIeW84YWxPd29EVUZrWFpiMUhoSkZUU01iTURs?=
 =?utf-8?B?Z3EyY3JzT0RJQlZRRzdxbGhKajFxKzhKV2czZnhCclc2M0hMdm1ZQ2pkYmhX?=
 =?utf-8?B?RVhwaW4veGM1YkN2Q24rYTFPaHJRcUlaMVNMd1RJSE1oM0N5SEIxM3h4UStV?=
 =?utf-8?B?bTRneThtcDZyLzA1SExSYWdxVGc3RVpIZ0Z6N3QwUDFDYllHZVBPK3Z5S1Z5?=
 =?utf-8?B?NWEvUFNIRVpCNnMxSThkZDNNT3ZnSWd1eWNibVRrbXFvR25sUFVycmlzYzZj?=
 =?utf-8?B?Y2JFTWswTXI3T1o0NFNFTHpqd0hxZE50K0t1d0FSUlU2aUw5VFYwem9nTlpa?=
 =?utf-8?B?RHUvZGdjRmNFQjZoRHVJRzVGYlBOVzdRaVdENW1CNk9uaGwyQ0VjOWRVYmZI?=
 =?utf-8?B?U1ZtMFZBS3llUEhNb1ZkbG45RklmUGJsV01aMnJzUW9yTjNSSVVEYUU2cHRE?=
 =?utf-8?B?bCtXTkNWb21Gd0pKL2dEeFhaU1dFcVJ3ZTcyQURnckE4T2FPbmhUdHdiSDlG?=
 =?utf-8?B?aGMzZHBJR2taKzBwVXVXWml4YWtyZzVEa3p3d1hEWEZ4Wko0NzlTSzhwM0s1?=
 =?utf-8?B?VDBWdVZibVZicGdLbGFKUGNCK2J3dWtWYTV5ZXo1MlVQelVUOVNTYU4xdWhH?=
 =?utf-8?B?WXEvdjNjR0x6UnhPUnMzeXZqcUI2VUJmWWpPM094N1gvcTg5Y3ptVkZuZjhj?=
 =?utf-8?B?Z25ra21Cc3hqN1ExNFdHeE5YWnV3dlBORnlHYWduRnpFVW5DaVlvNWNmOXhR?=
 =?utf-8?B?aUhUYmdYOTdqaXIzWTMzcStOTEUzNkpkY2FzRDMwVjl3MXI5cHhDMVZ6RlRn?=
 =?utf-8?B?MmM3ZE9KVVd6ZnorOE5jZU9xeXR4YnBpWDFlSkxpUThsaC9COUErMDFFNW1a?=
 =?utf-8?B?UE9QZll4YXhXSFh3aThuclZ2YW8rcFF6TkduL2syRmJoanJCYkRFZVpwNWl2?=
 =?utf-8?B?NWtTSjBwQXdmZDA3Z3RPM0pub01HbG1QQ0V0NHFDQzRnYUlsOVFaRFBCd2Q4?=
 =?utf-8?B?M3V2RW9wVXhlMGhveHByS1dSMDNmTENWRWRoRitWRWo3L01ITW5vcWdMQlFC?=
 =?utf-8?B?bTZqUHB3bmE4TGlMS3BHMmltdkpaaUhUWVkyb1YrRk0xZDFVdHFERHV4UFJF?=
 =?utf-8?B?RFNER3BycGVqUWNGaFZwbU9qMkVrL3BvSnBLVmg5Vlk1RlE3SCtzU3ZUNGNX?=
 =?utf-8?B?c2FiZHliNlc2aHhvUnVDVmpLT0J5N1lsUlZTUUFoSG9Nb3VtZDlNYlpJMGhU?=
 =?utf-8?B?N0QvYTdQbzNnTTlrT3A1RUVJMFRWZ1JvQjBXT25tUGhZNmhBYVErYUtNUmF5?=
 =?utf-8?B?bjBIL3kzRExVbGNrTmNTWWMyczMvK3ZUVWFKbVozeDNuSElWRXR0N3k0T1F4?=
 =?utf-8?B?OWNwR3JjNGF4MFNjQys5MTVtK0FkNnJJVkNkTGlpYjErQlF6OVJrbXI3cnNE?=
 =?utf-8?B?TU1seE5MSFZoSnJ2bmR6QXllN29aTnRLVGtlangwUlptb1NMdHNBeDhHcmph?=
 =?utf-8?B?L2Y2VE1XNjlUVEJmYlhFdlBraHlpcU1UMnRaR0ljbHFocEd3VWVLdDE2aDlS?=
 =?utf-8?B?YmtiWmJSMGFNNFBpdllVMy9uQm9nNEtwRjE2aG1NMDRxYlVSUkw1cGF2b2E4?=
 =?utf-8?B?eHB3SVllZk8ycDJvK0NjTlRxNElHSUZBV2ZnUlJhK2dTZ2xaRkt6Mmp5M1ox?=
 =?utf-8?Q?NL7QRtoUT027CEROju9Md8G3+4/B92bxxPjpW4S?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85250ad1-41ae-4676-821e-08d98fd7fd54
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 12:33:28.1147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iZUwp6DeGi/oyu0jwdPm23MJZaLwWBHdKJ8NZ+x28k10g4VzwR3cq8gK+GKrFM0R6Raa6UDVgKxO86OZD6Z2XQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3290
X-Proofpoint-ORIG-GUID: 35Wlg56BmvxWNuR47-gdfRhfAuHt2LpC
X-Proofpoint-GUID: 35Wlg56BmvxWNuR47-gdfRhfAuHt2LpC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-15_03,2021-10-14_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0
 bulkscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=512
 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1015
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110150076
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/15/21 6:20 PM, Peter Zijlstra wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On Fri, Oct 15, 2021 at 12:13:59PM +0200, Peter Zijlstra wrote:
>> On Wed, Oct 13, 2021 at 09:41:53PM +0800, Yanfei Xu wrote:
>>> The spinning region rwsem_spin_on_owner() should not be preempted,
>>> however the rwsem_down_write_slowpath() invokes it and don't disable
>>> preemption. Fix it by adding a pair of preempt_disable/enable().
>>
>> I'm thinking we should do this patch before #1, otherwise we have a
>> single patch window where we'll trigger the assertion, no?
> 
> Anyway, I've stuck the lot (reordered) into my locking/core branch, lets
> see what the robots make of it ;-)
> 
Well, thanks for reordering them :)

Cheers,
Yanfei