Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211015090530.2774079-1-linux@rasmusvillemoes.dk>
In-Reply-To: <20211015090530.2774079-1-linux@rasmusvillemoes.dk>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Fri, 15 Oct 2021 15:08:05 +0200
Message-ID: <CANiq72mG2dX++A9S9+ycS-67rbkhFgF7B9wgEEpOoBKYpgPAkg@mail.gmail.com>
Subject: Re: [PATCH] linux/container_of.h: switch to static_assert
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 15, 2021 at 11:05 AM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> _Static_assert() is evaluated already in the compiler's frontend, and
> gives a somehat more to-the-point error, compared to the BUILD_BUG_ON
> macro, which only fires after the optimizer has had a chance to
> eliminate calls to functions marked with
> __attribute__((error)). In theory, this might make builds a tiny bit
> faster.

Thanks for this! Very much in favor!

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Perhaps Andrew may want to add a link to the related discussion
thread: https://lore.kernel.org/lkml/20211014132331.GA4811@kernel.org/T/

Cheers,
Miguel