Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp929595pxb; Fri, 15 Oct 2021 20:30:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl/CfbEcHH/rL2/LbdF1Xe7wk1TqHbwVgdEWU7SRrw6UxtxKC99dbu/FCUtGsKmTnz90Ov X-Received: by 2002:a17:906:b097:: with SMTP id x23mr11320661ejy.501.1634355011513; Fri, 15 Oct 2021 20:30:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634355011; cv=none; d=google.com; s=arc-20160816; b=t3wST/6pZOAfMdxNwBrGbxvsBWi/PaLELaNxmhLhpW7rNEaYxe27i57JYfDWkIwR30 zcsLveP6uWVMfDDbPkvHpZY6z0xqIbHzRyMhL7gL0RbViw5DGC26BccXx/w8JDJMnL4K vmLIcpx5ef57MCS51PEjMWt+DYl7BkZdVe0doMiaITV/GAIOXN33PYIoJXB2bt4eIJAk EywGD1NW2YenlUsEzPxncQwDvseJnlQcmBquD8AggcjunPbb/lUUDa3eI8PzFJwHdoco teDeqBOAZ4c4j1AmW9H0S1IW9+NkpH+JRRz0z3sWAoSs9IvbShZ1mBvjTpRIGgnpUMjk ATdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:dkim-signature; bh=o0wfY5rWG9bmKz4fgn2nS2DQacNRL7NBVJevnu+cu7A=; b=rfvxHqKhY+NIdphS0lGHe42iG1+2RdlLtmRMb4kieVTfzQOzoTXSTNz2IazNWa7rCd tMCQddRuECDVKaDR/lucVj68QHsxwZXde29exsrwSLojOQTf1WSLpSsHT+zntBvnRnbE d1Xsl9T7+H9jwTvEZ6JbzXZbLKGI47lMRyFH5OM9HF/Thfdr2CSd5e1wpVTL4V+ob+LQ h79qOM9aUsQJbu1jxMJvfbsrhH6uxCgAv4NRkX2pw75l+I3+zWCAfOqFP6v5vi/7yDCX 36+3oxMTM0wKLp5P84dO1zYKQogkd5I3UhOgUmTSpSaPwLgI52RnMkAS/k3YUbX7qdF6 TNgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ext.kapsi.fi header.s=20161220 header.b=C4BLm5Ns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 2si9985479edv.141.2021.10.15.20.29.48; Fri, 15 Oct 2021 20:30:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@ext.kapsi.fi header.s=20161220 header.b=C4BLm5Ns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239341AbhJONY0 (ORCPT + 99 others); Fri, 15 Oct 2021 09:24:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbhJONYX (ORCPT ); Fri, 15 Oct 2021 09:24:23 -0400 X-Greylist: delayed 1548 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 15 Oct 2021 06:22:15 PDT Received: from mailserv1.kapsi.fi (mailserv1.kapsi.fi [IPv6:2001:67c:1be8::25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0CB4C061570; Fri, 15 Oct 2021 06:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ext.kapsi.fi; s=20161220; h=Subject:Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o0wfY5rWG9bmKz4fgn2nS2DQacNRL7NBVJevnu+cu7A=; b=C4BLm5NskSbrQTV1sjBDGHez2B Bb9TCosJPdsS3LYNjtqn7rEp5XDA3EZZLlAsYyjnOXOXTNOIIHA9zB6eHu3G6sTJEfVJRe81gxD2f pQwakmwJIfNhZN2HSYcyXmTbgLp5xpJimHu9+xQNU+W2I/P6EZJ0tYtxzogoXGR+CE8tzRVBALNe1 AvTIQc2Yid5js5hUlYgBszJugfslQewUiudB5VoKuCwj4N2I2X9sDKxKzkkWYAlOAGgzsaoED+YBw xCDxOaWlqyKmGWCWinE5mBcM8PlQDA6Ue/pQwnmLzNr14iNVdB2oK6unt7vEatV0fjd6QC87JCLrG mwOwocig==; Received: from a2ef-817a-a3e5-8122-5100-87f3-07d0-2001.dyn.estpak.ee ([2001:7d0:87f3:5100:8122:a3e5:817a:a2ef]:52775) by mailserv1.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mbMl5-0000tY-BT; Fri, 15 Oct 2021 15:56:23 +0300 To: Andy Shevchenko Cc: Mauri Sandberg , Bartosz Golaszewski , Geert Uytterhoeven , Linus Walleij , "open list:GPIO SUBSYSTEM" , Rob Herring , devicetree , Linux Kernel Mailing List , Drew Fustini References: <20210325122832.119147-1-sandberg@mailfence.com> <20210621172053.107045-1-maukka@ext.kapsi.fi> <20210621172053.107045-3-maukka@ext.kapsi.fi> From: Mauri Sandberg Message-ID: Date: Fri, 15 Oct 2021 15:56:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:7d0:87f3:5100:8122:a3e5:817a:a2ef X-SA-Exim-Mail-From: maukka@ext.kapsi.fi X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mailserv1.kapsi.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mailserv1.kapsi.fi) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.6.2021 20.43, Andy Shevchenko wrote: >> + gc->of_node = np; > > This should be guarded by CONFIG_OF_GPIO. In the Kconfig I have a dependency to OF_GPIO. Is the guarding still necessary? Or should the guard be added and dependency removed? Or have them both?