Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp937854pxb; Fri, 15 Oct 2021 20:45:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjfBlIwmmAzhMPusNVT/fkF0A8IeSnXzwamoB95ECIgpOL1MQN01VLcdPfNhvcoJ06QIxS X-Received: by 2002:a50:e08a:: with SMTP id f10mr23044214edl.319.1634355937688; Fri, 15 Oct 2021 20:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634355937; cv=none; d=google.com; s=arc-20160816; b=wo+4acfgX1JrMhIJyduDo5Jadow2t401900tA87zHGRWXasUr3HxS48UW6d/nsZOyV qHzJP3CxHKKvVS7l4mmqYHxfhMLwl9ZuD6tG5NBFLs8pzNj8xgpYyUgCPIy4Mmylv2GT Bn3rF4Rb5TRDK7kllc61Axj+RP9ZqIQMRVXAU83lKniYvoiCwnRB6jPAhzKB5LVh2Qn6 wCQ+AmiQsm1NFGJTlrl8MyFyLBnOigp63aK9aPyiry/NyyafBoN6rIAqerNYcSnVgMiD bp3eLVTzXEaGGnWrPfbQOaeCXgxn1cEvs2awqlxGVNc/84KH3JoPreIdLUzs159zXXQG oCiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Vf35v0bqiZzdiWrXKHoxlWqdW5cbp+8y9iPSBh82fTg=; b=OYwNmUe/na4RGTKNXqY7uxi4jvl9nsJwcm99POGixjTTeQovRVb62rPH2ruRWPmun4 ZlidvDipegvnQnNB2aVq5ljVQXVHV4k9klM1crMS60nqt9tbJv8Q8l36lOLxRrqfV0PE k5VdDaz3/f0TnJ/uIoArErSNDFta77nYz1IPmqNRcQRyDPziTui4ew6WnawXHEEscbUU bZG7xdItDVf9yJasUUKqRnQGsGaoZQkEnbQC+AVbdY7k6lKxuzeLQVF3tbRR0GZobOhu Kw1O/cktEhb2lR4n//iknMEmnU8gyKTxy/nGxjDkb0qxPt8aKS24avlzwco+hbEc3kjM B3cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=20134lrx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp17si11218066ejc.636.2021.10.15.20.45.13; Fri, 15 Oct 2021 20:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=20134lrx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239377AbhJON0O (ORCPT + 99 others); Fri, 15 Oct 2021 09:26:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239368AbhJON0N (ORCPT ); Fri, 15 Oct 2021 09:26:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA4B1C061570; Fri, 15 Oct 2021 06:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Vf35v0bqiZzdiWrXKHoxlWqdW5cbp+8y9iPSBh82fTg=; b=20134lrxVbhWLR74xnpZwFl2LP MFiVJpXssduTGdPS5Ydo2aYJ1BJiBhUjQ3glVfIgIICFRofxfIbNZuYf/ROs4LyoeIDZb98e+JDD8 zurbvXysVzqrxNrpe4EYfMwDkHj3smo938qwbOCgcE2TPLQZOG6F5XbotvFb9fAvPdbmRDsDrHV2t NZB9X0gnYB4CELZE7XXTNCSvoojH9DO7L65UGwxS/oti0YkDdymrV7KuAGvH4yl8S/pu5DHGV6/do 2+HaZVf2PecgUha6qUWUun53JR8YGo6IiDrPMOGTBv9JxL2sSzlP5TWYxYpBUCZZY/8d09NO4xnqm JCxfl+hQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbNBs-007Bod-NR; Fri, 15 Oct 2021 13:24:04 +0000 Date: Fri, 15 Oct 2021 06:24:04 -0700 From: Christoph Hellwig To: Zqiang Cc: Christoph Hellwig , willy@infradead.org, akpm@linux-foundation.org, sunhao.th@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: inode: use queue_rcu_work() instead of call_rcu() Message-ID: References: <20211015080216.4871-1-qiang.zhang1211@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 04:28:10PM +0800, Zqiang wrote: > > On 2021/10/15 下午4:04, Christoph Hellwig wrote: > > NAK. > > > > 1. We need to sort ounderlying issue first as I already said _twice_. > > 2. this has a major penality on all file systems > > This problem report by sunhao,  the log > > https://drive.google.com/file/d/1M5oyA_IcWSDB2XpnoX8SDmKJA3JhKltz/view?usp=sharing When I wget that it just returns garbage unfortunately. > > but I can not find useful information, not sure if it is related to the loop device driver. > are you mean There is a problem about inode lifetime ? Yes. This implies that the del_gendisk hasn't been called before the block device lifetimes hits 0.