Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 1LqGw4wudZsJmutI5/fs2v8NG8v+7mJiYQYRu4y36zP4wmYF4uCNxGspx0UXhdrElT1MHs7lEP
 Ef7vJ4FfgE9+LIWpZZxm9MhPU4VudvkJNPqBY5yguc910c2iZcwVZbUKCOGn0aCITjHBzGB3nf
 H1YAuQjfwQLSd3rejtOjlMwl/9Ckznm65ZpCEFQdCeyXGIsbQwFtPWm06RnrS6+G9bmCKx6C+I
 UH8UFtyi6w0St1Ki06pxTuNT23hQK66htkw8kK83WfFbTrAH2Da+V924BLXv63IxLDk04wufU1
 21LHPbbFBS6+qgfToYCxW3KP
Date:   Fri, 15 Oct 2021 16:14:04 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
CC:     <robh+dt@kernel.org>, <andrew@lunn.ch>,
        <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: reset: Add lan966x support
Message-ID: <20211015141404.5eiylskcfy2fxi42@soft-dev3-1.localhost>
References: <20211013073807.2282230-1-horatiu.vultur@microchip.com>
 <20211013073807.2282230-2-horatiu.vultur@microchip.com>
 <838af7b574968fc55d517a3becede5fa106ed896.camel@pengutronix.de>
 <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20211014152016.wuwaesswc5iiil42@soft-dev3-1.localhost>
Precedence: bulk

The 10/14/2021 17:20, Horatiu Vultur wrote:
> Hi Philipp,
> 
> The 10/14/2021 13:55, Philipp Zabel wrote:
> > 
> > On Wed, 2021-10-13 at 09:38 +0200, Horatiu Vultur wrote:
> > > This adds support for lan966x.
> > >
> > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > > ---
> > >  .../devicetree/bindings/reset/microchip,rst.yaml   | 14 +++++++++++++-
> > >  1 file changed, 13 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > index 370579aeeca1..fb170ed2c57a 100644
> > > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > > @@ -20,7 +20,11 @@ properties:
> > >      pattern: "^reset-controller@[0-9a-f]+$"
> > >
> > >    compatible:
> > > -    const: microchip,sparx5-switch-reset
> > > +    oneOf:
> > > +      - items:
> > > +          - const: microchip,sparx5-switch-reset
> > > +      - items:
> > > +          - const: microchip,lan966x-switch-reset
> > >
> > >    reg:
> > >      items:
> > > @@ -37,6 +41,14 @@ properties:
> > >      $ref: "/schemas/types.yaml#/definitions/phandle"
> > >      description: syscon used to access CPU reset
> > >
> > > +  cuphy-syscon:
> > > +    $ref: "/schemas/types.yaml#/definitions/phandle"
> > > +    description: syscon used to access CuPHY
> > 
> > Can this be used on sparx5?
> 
> No, because the sparx5 doesn't have any internal PHYs that need to
> be released of the reset.
> 
> > Is it optional on lan966x?
> 
> No, it is required on lan966x. I will update the binding to show this.
> 
> > 
> > > +  phy-reset-gpios:
> > > +    description: used for release of reset of the external PHY
> > > +    maxItems: 1
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > 
> > I'd like somebody to reassure me that putting the CuPHY reset and
> > external PHY GPIO reset in the reset controller is the right thing to
> > do.
> > 
> > It looks fine to me, but I'm not sure if these should rather be in
> > separate phy nodes that are referenced from the switch.

Were you thinking to have just another reset driver('phy-reset') and then
the switch to refer to both of them?
I like this idea because then is more clear what is doing each driver.

> > 
> > regards
> > Philipp
> 
> -- 
> /Horatiu

-- 
/Horatiu