Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Nitka, Grzegorz" <grzegorz.nitka@intel.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH] ice: Fix missing error code in
 ice_ena_vfs()
Thread-Topic: [Intel-wired-lan] [PATCH] ice: Fix missing error code in
 ice_ena_vfs()
Thread-Index: AQHXwdFF9D9HGiAfhEOILrrrimizZavUIRyw
Date:   Fri, 15 Oct 2021 14:41:05 +0000
Message-ID: <DM4PR11MB528003D5122D7831F9A5F72A92B99@DM4PR11MB5280.namprd11.prod.outlook.com>
References: <1634292249-63098-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1634292249-63098-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?coI7zBQ/hX8NcdnmtprgSmK8waRSdHSl9lIaX8TUDjcyc53UPh59nK2FtU7k?=
 =?us-ascii?Q?bRiHlSnUBkBIXFVUsfTfEruSzJ5Vo3jZFW1zIOGCYowC4F1Xx7q0qkVbKC5L?=
 =?us-ascii?Q?ZZxfZw/8dHtmO+dvx0bt8/v/acxbSi1gENzVQP1BNYvWf9hWkTnRDn2dbpMi?=
 =?us-ascii?Q?GflDnPM9pHFGgBwHr08BgXgHPM0lA1F6YVSo1H1NPTI4M/8RJi1rbCwrJ+Ss?=
 =?us-ascii?Q?t6mugLQAURbrY9Xh08lqSu2yc74EGTqQvBEcw4G16EwMy5R9IytM2L46AChk?=
 =?us-ascii?Q?XupT3e1r74BFbS11o86maVrIWcOKAiazKiNLWYWWac8BikDRnSCDH19lo6eb?=
 =?us-ascii?Q?G0Lpuxp/0O1N9y9QPikqFEehzPqdf/Yo8Jk1oXchv/mfEQGFK8N6mgEbAm6U?=
 =?us-ascii?Q?6nvkgeOxdrgoMbNUyHHxh3Yq/tP5lmN250DGVIQwV5WKcmPv25j9xuDFU1P0?=
 =?us-ascii?Q?0DhaJUer4IwOHfsjnHh4x072wpbDhArGNyHEeTx3AUwCZBd3Q7jLHfwhSGir?=
 =?us-ascii?Q?uWntNXgebA1YhlNCJ8JZP1WX2/+ypYivmI9LuMXqhJhGL7RU1DW12ijG3CMw?=
 =?us-ascii?Q?9Sgy81teb4C9UAnvyTiq+cCb51IyU/BkpWwVDHsPD3vTEDdVdDnjjknEjB/Y?=
 =?us-ascii?Q?RmJid+lUXJI/K6JiGv/wPNEG7aFJ3zxr52hgLro63FNSUh8nZBgm5UHAAZy9?=
 =?us-ascii?Q?aAccYXU/yetvow9KteGxob0oLwaBCNqC+YhGh3Zfx7UhqyFo+sXW62DHkPHb?=
 =?us-ascii?Q?4YN1z6hzKsbO9mOt3PYWwmaX6vuNeFHEwRENbg16pAuTPpLg4IKjlXN+4YcF?=
 =?us-ascii?Q?ctpDuBBVHM29vKEuxCcjH7Ma3p42qb42yDWtIc5uqsPTrFrOx42znPRS9kS3?=
 =?us-ascii?Q?YL+2swSDCqJebNeuqYNIY6FiPtcW/CFotRovYPNLd/nZPjc9SW/pS76T7XQH?=
 =?us-ascii?Q?/JAKT1c0S3p15Tsn3ofnoB5xHwjWJX0zeicsrAyme5GUAKRaS7WGreCoRp3I?=
 =?us-ascii?Q?hP+G1vy3bZnMuQeId8aXj0MNVytnFBKYxuDZi8qvKyjCQl8VbxQowOqTFobp?=
 =?us-ascii?Q?C+3w1gIgO/8KxRPGjEqPPbgXO4omtNWfRfu0x23y5q0IFXO40DLcTeqxrSYz?=
 =?us-ascii?Q?APPzXmEN08X/mINhqSkBpI/30hP71YIJlv0+YQnF6suf0mTAPDi5KXaJ4i5p?=
 =?us-ascii?Q?aGjbuxL8V16Z2zNk1aX1JvuCcXN3sO+qR6oKYCDvKWqvBO+tTKAYXdjn4G6d?=
 =?us-ascii?Q?baXis3mp/cfPW+S1iffrj3iNjJswtiq+Wf6RJBdZnQpe2XNQMyy3NbbKY2wS?=
 =?us-ascii?Q?c/IZwxdbuuxGb7RTzSJf5R4o?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc195d64-5fe7-4477-3f8a-08d98fe9d171
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 14:41:05.2532
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JzdlF/WwoTnwBDhIOIGxQ/Gk4VocVMG04+IFFYFxk96Rf0gQYg0ASaGhLq51Gf/5qPr34iMTU1KRhugTHfovgI9hBl+0Cad5fq1rFJ77KG4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4692
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jiapeng Chong
> Sent: Friday, October 15, 2021 12:04 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-
> lan@lists.osuosl.org; kuba@kernel.org; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH] ice: Fix missing error code in ice_ena=
_vfs()
>=20
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
>=20
> Eliminate the follow smatch warning:
>=20
> drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c:1979 ice_ena_vfs()
> warn: missing error code 'ret'.

Seems to be already addressed by Dan Carpenter with this patch:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20211013080012.G=
B6010@kili/

>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 1c54c839935b ("ice: enable/disable switchdev when managing VFs")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> index 4d0b643..b2a018c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
> @@ -1975,8 +1975,10 @@ static int ice_ena_vfs(struct ice_pf *pf, u16
> num_vfs)
>=20
>  	clear_bit(ICE_VF_DIS, pf->state);
>=20
> -	if (ice_eswitch_configure(pf))
> +	if (ice_eswitch_configure(pf)) {
> +		ret =3D -EINVAL;
>  		goto err_unroll_sriov;
> +	}
>=20
>  	return 0;
>=20
> --
> 1.8.3.1
>=20
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan