Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1485793pxb; Sat, 16 Oct 2021 11:08:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoYjFpVkm5c7HvRgk5jK0VNoauLDlZigAAZ+33y8cFG1DO8XhQ6ZlxpssG9OfeOp8hLops X-Received: by 2002:a05:6a00:b94:b0:44c:db51:30cc with SMTP id g20-20020a056a000b9400b0044cdb5130ccmr18690940pfj.47.1634407700159; Sat, 16 Oct 2021 11:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634407700; cv=none; d=google.com; s=arc-20160816; b=K9Szm9cTiv4eIV3i48psyOX35dJ8naGXqovvOF2D2CACmv1pqzbYrlQpiWddO3BVP1 7UckqlORdWHJxRjJ4MUdBEDzALMXokWAkJRM6g/FU2lJPpRYkBBDcIGYdSAiPcKobmeK dYlcRP6y0HKDVMN6WjJ96OjYyTRSD2n4QVAkNT1W9zc/VGceRvVr3zzxXswMVEjrrpFd 54HFn+SPZVH3v5RdDhTMguecfq/b4YaFHzoIm77Q2aAMtPQzdpBwO3lxo1zlN7Z57H7E jo67IRUjVRA3YYzbL6YLjD1zNjhGCoAB8I9HWQWBI+jkt4t2xgDQx95PhDi/XGJNQnlA gE8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:to:subject:reply-to:dkim-signature; bh=RBjjLeiWguUvJEs61LGvxzcOuVVwGqpZvu6xGLNcQxE=; b=AycHOSJ1l6VYLMAm7owQMKbRXIb6Yd25ZGPKLcGLyuK8YLAwFpPjT9ZXERPJGED2Tl hIfwYPJ0j7kiSJvZJJE2l+oj40Y5axoW1RROTDrBFgyqA65KrINSldjD0zI+0fkAO1oU JDBg4NX8nwT+FDoQaJeEqRgBlPLxFQ1imWm9paS4BiipVtotGwG6AKkPUC2gpma5f9Ac S7YdgNdHeoS9Rlc3z+BgYDZyczErelJ2o5czu6loXqrYLjIkc4qK1pvn5Vd3LBAbn4PM dhsG1CClM7/QhyEuXvW+yM+VJzD5+xKIgikX2A7hDhAHwxoESIXCTxoyvzrbsiDm11o4 HRbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@6wind.com header.s=google header.b="Itr/Erp+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=6wind.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si14530040plh.93.2021.10.16.11.08.07; Sat, 16 Oct 2021 11:08:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@6wind.com header.s=google header.b="Itr/Erp+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=6wind.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240714AbhJOPDD (ORCPT + 99 others); Fri, 15 Oct 2021 11:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240639AbhJOPDC (ORCPT ); Fri, 15 Oct 2021 11:03:02 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E482C061762 for ; Fri, 15 Oct 2021 08:00:56 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id y3so27150084wrl.1 for ; Fri, 15 Oct 2021 08:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=reply-to:subject:to:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RBjjLeiWguUvJEs61LGvxzcOuVVwGqpZvu6xGLNcQxE=; b=Itr/Erp+2n16kmSlIzgLZ7us7a3qCYej2DFLFJtKE7utAoqwfiU1p032ZmfVUwJrvQ MNmp1vhX2U3vxiYdEFGItNPK4SQn1+VqY8QsZAtqM87WDBHNJf6V+XmVLlTQs42gc6kb T9kZ+fNu2gfkOAeWwQBOk92IA2HQsbaEYcWkOaO/P28PhlAYw4poa1K1IeC+J3IIgP1i htj2mq+VNF0LuhV8wkelX6oycFnzBZ+gnZaXZgOITdwZvi++GLKyQIPMJT0QSEy5HyBf kZA9vs/gFxbd7iH/5hP2JcssLc9aUhkzLVUjP8JhJVo+1HC3vlR0U1phgjRm7euBLV5e rZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=RBjjLeiWguUvJEs61LGvxzcOuVVwGqpZvu6xGLNcQxE=; b=nzTZG2vZY72b27XtV8ZmlixH4i8fBJduPiA50zFrVbMHWptlhqSEuy52Em0Wx/9ieP pYFRF1g/3tFfe7Sc36zHHlABx3eyOidxuyJH4rWm/+NEfSmXVMXxVRYtbGTZSx/NrUTI e1YHJyRap5IGtYIc2q8sRX52f7uilhj5zJVHQVTm3vilLfr+pX+AVBgKZ1Elhilwau7D e5SX/PeLxQk3/u6HhEVNbiCfXeT8nGUdqPcoT0GOGrel2HRy6bRONS4vAuiOTIKbNowW obkny9Unu8MKzE6J0S0DxgiKt2WaYianKwryc/wHlZcbgds6gFVXlpG9YPf8kYdpAC8e IcCg== X-Gm-Message-State: AOAM532WcMTJt2XFrpg8GT2Q/dutzBPU9lOqPUStNhGI4tJSLYn5fq53 DBfqoUd7fYFfk4N09Qa4r1Pn3cMRB1c8Bg== X-Received: by 2002:a5d:64e2:: with SMTP id g2mr14917796wri.253.1634310054940; Fri, 15 Oct 2021 08:00:54 -0700 (PDT) Received: from ?IPv6:2a01:e0a:410:bb00:a58d:ec4:bbb2:aed8? ([2a01:e0a:410:bb00:a58d:ec4:bbb2:aed8]) by smtp.gmail.com with ESMTPSA id o8sm11730076wme.38.2021.10.15.08.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 08:00:54 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [ovs-dev] [PATCH net-next v7] net: openvswitch: IPv6: Add IPv6 extension header support To: Ilya Maximets , Toms Atteka , netdev@vger.kernel.org, pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org References: <20211014211828.291213-1-cpp.code.lv@gmail.com> <1d0a5e90-b878-61a1-99af-35702b72f2d9@ovn.org> From: Nicolas Dichtel Organization: 6WIND Message-ID: <69204286-6dad-dade-f749-8603da82eb48@6wind.com> Date: Fri, 15 Oct 2021 17:00:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1d0a5e90-b878-61a1-99af-35702b72f2d9@ovn.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/10/2021 à 15:56, Ilya Maximets a écrit : [snip] > Not a full review, but, I think, that we should not add paddings, and > define OVS_KEY_ATTR_IPV6_EXTHDRS before the OVS_KEY_ATTR_TUNNEL_INFO > instead. See my comments for v6: +1