Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1589861pxb; Sat, 16 Oct 2021 14:04:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTBGIGSSg8XllLjjsr2COUq+IHYkY98Cy1nUFFhnt3lm6PW8X8cTucbSFqoovp8/0TOC1+ X-Received: by 2002:a63:dc14:: with SMTP id s20mr15003567pgg.291.1634418289329; Sat, 16 Oct 2021 14:04:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634418289; cv=none; d=google.com; s=arc-20160816; b=YbYMzQfiXLX/3svcJkuXArWYeLSmVMtnH54dUU2mrPpnqUOWwlhc2x3LXwQwljHtwR r2p9OPE1qdghZbgN9YM7vQ/oTUK0DWHepGEJK9VyouUaloPOxQgGFhG7ZN4aZctSIi9n 1VqAhjDlv4sEIWNG26X6bHIt/p4UQTxoXMNLwVmq813JB2L3i+8zFvVRYamPMa9LAq4j 3Fgks8QTIzyGs8FwXIGBjoX8WGj5fEIJv2ZKma8j+PZoLk79ugLpBWJ136+89Fdc6rFt 8Jo3Qzsqb5Sb726jv1hneQULh51nlolmBwEjNg8Ts4+RMDPiyzs57pu1bh0p3XIHSNHj TIOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=8YmlrDNT643w8xlpmwqygZolkmjBpCXMyrJLtlLidLc=; b=SHJhNfGy/d3YtkfFuwRFIGoBdnx7V3CdEzxMUwMAZakPedgLLavR4Ww7+HVQqiQB33 qHYELc1cWp5adk1qEsrP+helxAyGWlkCQFFsoTqEw4w77x9T+RwKVa8Nkd4SpL3QCPOU Gi56EnszttipDFSNJ2QYosvSm3lLL9LR4yLHoEARllIkjWipsj4MyC5IqWC6I6XGuked JtQQMt1DWhA4G0Jru819gPbz1ZnNy6bOiPrtCngUfXIrcVKexUCmcVRiXVRdHcEjCU89 Ahh80kcETnQARTYoG5Rd+zTqSX491YeWZUjfBPZ/Z0cyJWO2KvVdZUc/Qv88leIUK2sO 3vlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b2si14350253plg.308.2021.10.16.14.04.04; Sat, 16 Oct 2021 14:04:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240969AbhJOP1P (ORCPT + 99 others); Fri, 15 Oct 2021 11:27:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:23112 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232267AbhJOP1L (ORCPT ); Fri, 15 Oct 2021 11:27:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="288795650" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="288795650" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 08:25:05 -0700 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="718137364" Received: from fongchan-mobl.amr.corp.intel.com (HELO [10.252.130.142]) ([10.252.130.142]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 08:25:04 -0700 Subject: Re: [PATCH v1] x86/fpu: Remove opmask state from avx512_timestamp check To: Noah Goldstein , Borislav Petkov Cc: tglx@linutronix.de, mingo@redhat.com, X86 ML , hpa@zytor.com, Andy Lutomirski , open list , aubrey , "Chen, Tim C" , "Van De Ven, Arjan" References: <20210920053951.4093668-1-goldstein.w.n@gmail.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <53c43d2d-0e2e-654b-417d-d3dcbca42fc5@intel.com> Date: Fri, 15 Oct 2021 08:25:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/21 8:49 AM, Noah Goldstein wrote: > Irrelevant of the still existing flaws, it makes the output more accurate. > > Is there a cost to the change I am not seeing? We'd want to make sure that this doesn't break anything. It probably won't, but it theoretically could. For instance, if someone was doing: avx512_foo(); xsave->xstate_bv &= ~XFEATURE_MASK_ZMMS; XRSTOR(xsave, -1); That would leave the opmask in place, but would lead to the ZMM registers tracked as being in their init state. This would be *very* unlikely, but it would be great if Aubrey (the original avx512_timestamp patch author) could make sure that it doesn't break anything. Also, there's the side issue of AVX-256 use. AVX-256 uses the ZMM registers which are a part of XFEATURE_MASK_AVX512, but does not incur the same frequency penalties of the full 512-bit-wide instructions. Since ZMM_Hi256 is the *only* ZMM state which is truly 512-bit-only, we could argue that it's the only one we should consider. Noah, thanks for bringing this up. I'm not opposed to your patch, but let's just make sure that it doesn't break anything and also that we shouldn't do a bit more at the same time (ignore Hi16_ZMM for avx512_timestamp).