Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2140559pxb; Sun, 17 Oct 2021 06:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj2TL5YE8LEujDgprvAriaYlLsVjzk4z2gOJb3zRaWfCvX4M0ToI4dwudqnGj5mIt2n/3d X-Received: by 2002:a17:906:ae54:: with SMTP id lf20mr21963690ejb.195.1634478894598; Sun, 17 Oct 2021 06:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634478894; cv=none; d=google.com; s=arc-20160816; b=Qz7DLGg2sF3pLn5mCLcL1t/fH3iDFo2BgNxC3Ajpm5X1wG2MXyvuNLBmUXNr/GVTQe c6EGfZfVqSPswQxkpaZQqTQUVpVq9QMf8ojuI+7DecM4/NB3utR+pnztm4iEl+VyzlcX 8yxj6zJl9X4vKTsaJJDxzelCFFHZb9Eorq+GVxujtJSHhEqN6rDr878ctAQRprpAE95l 98Fb2OvnjqI+TURqEk5iPRMw7jhh0f7EO7KDknlndQnKLlCTHbsiEaJIXiKNVszDoK/F +KBPCKj9ZUMMbj+bpQXkBd8FVifyMcIKPRMqYyL8So5G18sUyUc2zm20foFnI+ApS8B6 62Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=3qZZL4q7gSQLhx5UGqjT9ebzZrdH8WkBdFrjH947yQo=; b=h/8K62FWJ0fmuKtozcFLH1Yu8M8fMH0XlNenG5RlqOrUbIxojMTj95uvbM9MhYN9/i kmTFq9Q5Nl9ezAErDFfLucbaAIGm9+Tn9Lt3pvIPXvZGLuDO/p6gbK74AkGzZfqrvV3E 7kBLzgXa7P4g6pDcIJDjTUZKaDiw9Clyaax5kAHZjD5EaqEjTC7qFJUUNS++Jrk0Qa3u r8mBRV9cKh2U38q2Z7Qm+Es+QoGW53IyyIdfZA2CcsDZecounDJ+ooBGZj3/sApFGlvP mzoqva/zfvsPlGgjG1OERyPVd2ybnJL/XdTXu7SJnJazBxjSQVgVnLRrWtRI7Sd0iR0H dBRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=StaSBoZi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si14690048eda.304.2021.10.17.06.54.29; Sun, 17 Oct 2021 06:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=StaSBoZi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237523AbhJORZ0 (ORCPT + 99 others); Fri, 15 Oct 2021 13:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242350AbhJORZC (ORCPT ); Fri, 15 Oct 2021 13:25:02 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73792C061783 for ; Fri, 15 Oct 2021 10:22:24 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id i83-20020a256d56000000b005b706d1417bso11970063ybc.6 for ; Fri, 15 Oct 2021 10:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3qZZL4q7gSQLhx5UGqjT9ebzZrdH8WkBdFrjH947yQo=; b=StaSBoZiHR3EyDcQiaC3wo96F5TxLygYhJeEXjuSQKdGg/uFybL9coAqda6skNKa1/ H8fDo4iMUdT1JQVheG1jNqSvOEnWloBo82r40zlKrFZYf/LVrQKJAEjiYmZYMt8qfGav Fmmw8VzQW/ArC8hnNcgfatbXub3CkaQJDW8rTvnczzJ9Jiaf2F+0yDsxQYlVflc01SHc L9VT5r4G9XqXnW9SmoAyluPVGe1EOtyIs2d0UAlsCOcpcodboa7ECIlhzSGn92vfOrda qIVKgFUoEqffuKDLl7PV4I+DO7juTtTbzh6Td73U7U7AB/wNlCuIhpTAD5pZEc2EqhSU oCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3qZZL4q7gSQLhx5UGqjT9ebzZrdH8WkBdFrjH947yQo=; b=YzmaYTs7wBKzczBLPuqzT8ZoOtL/EDI5+Z+XJiA9NellzfAbU5e4NvMu0rpY3fJnoe OoOfMKqJ9TzwyUxjm+0MUlO13bWg+INEYkGGh8QPnSABYTZp23HHvlTJ8ROGwnxPxt/U SNRoT0mmnWdef6Ph1ZpVSsOcgplC79bNKqIBdxYrrM1ErGqKdipdkpc3J1ES1Ik2hwjY mE/TLERwk6EBYqKjjJDpuC3r4WzgKciuu7Xdsvjnhx/jgzUDjxitU6AyRUfw4F8saFaD 2F0gFEBPlm3UtsJETxRXSwCMED4VVYvMOxQhGoo12+bbPg5ulbCKKSoKhb6RzVf8I4qr 9i/Q== X-Gm-Message-State: AOAM5334C7TtmVubQjp3z2CuWRI89VfDRSO0/eq+fmjqETjLscg2bY9I fqqMlOi6nuOp9QT3M8j4DuIZnA3Ljabx X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:69bc:7451:58ad:6585]) (user=irogers job=sendgmr) by 2002:a25:6884:: with SMTP id d126mr13929568ybc.533.1634318543629; Fri, 15 Oct 2021 10:22:23 -0700 (PDT) Date: Fri, 15 Oct 2021 10:21:30 -0700 In-Reply-To: <20211015172132.1162559-1-irogers@google.com> Message-Id: <20211015172132.1162559-20-irogers@google.com> Mime-Version: 1.0 References: <20211015172132.1162559-1-irogers@google.com> X-Mailer: git-send-email 2.33.0.1079.g6e70778dc9-goog Subject: [PATCH v2 19/21] perf metric: Switch fprintf to pr_err. From: Ian Rogers To: Andi Kleen , Jiri Olsa , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Kees Cook , Sami Tolvanen , Nick Desaulniers , Andrew Morton , Jacob Keller , Zhen Lei , ToastC , Joakim Zhang , Felix Fietkau , Jiapeng Chong , Song Liu , Fabian Hemmer , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , Sumanth Korikkar , Heiko Carstens , Changbin Du , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no clear reason for the inconsistency that stems from the initial commit. Acked-by: Andi Kleen Signed-off-by: Ian Rogers --- tools/perf/util/metricgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 988f9e95dded..b6ba1317973e 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -1172,7 +1172,7 @@ static int metricgroup__add_metric_list(const char *list, bool metric_no_group, ret = metricgroup__add_metric(p, metric_no_group, metric_list, map); if (ret == -EINVAL) - fprintf(stderr, "Cannot find metric or group `%s'\n", p); + pr_err("Cannot find metric or group `%s'\n", p); if (ret) break; -- 2.33.0.1079.g6e70778dc9-goog