Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PM] bfcc1e67ff:
 kernel-selftests.breakpoints.step_after_suspend_test.fail
To:     Florian Fainelli <f.fainelli@gmail.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <lkp@lists.01.org>, <lkp@intel.com>,
        kernel test robot <oliver.sang@intel.com>
References: <20211014075731.GB18719@xsang-OptiPlex-9020>
 <51c0a15f-1941-f161-dcec-a7a9acc726f2@gmail.com>
 <e526de16-5efd-6474-20e1-3f96a2e3c524@intel.com>
 <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
Message-ID: <d3cf18f1-2af7-5e4d-abe4-c882f25bd5c3@intel.com>
Date:   Fri, 15 Oct 2021 20:45:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVQ2T1JBY25menJzakI4Q2swVC9XK3A2ZVFVRzFMamlRQVcvczVCdWliaXE3?=
 =?utf-8?B?MjRkTkR6RUxqamR3NEV5anBTL1luVHdrc0pFZm5GcWFTaTlBclRmdmlRSW9Q?=
 =?utf-8?B?bU5hK2tRMVBTZWdJN2JSUEI5T0NjajVudCtBclB0NXJZWml3aFd3NEVxQkZY?=
 =?utf-8?B?SWFBKythaUFadlk4NElkYlQ0ajd2ZEw2aGVQbE5XZldHUFQyaXZKMDFETGVs?=
 =?utf-8?B?UWdGTkpuc1FlZkZHU0s4RERBcnp5ZE1OY00vZEd4NWp4S1F0cWxZMTBWaUJq?=
 =?utf-8?B?Vit1WlFQS3laWE0zV0luMW5vUVZNYmRGdHIxVW1Bc3FXNDR3T3hqL2x1V0hQ?=
 =?utf-8?B?OVlvOFV5Y0tadCtTSDdVSXNQZ3R0d1laeHJTakR0R1JGZkRQdVYzUFdEMUNQ?=
 =?utf-8?B?anoya0kyL3N4UGxKUnhWMys5VHE2VWhva3NnMVF1UXhad21nZEpaRVlmU0NM?=
 =?utf-8?B?L1VpN3BtRzhzaVJzeUdYSVk0UGFqUVM5MkdNYytvTW5tWWxqR2svclpNTHVv?=
 =?utf-8?B?Z2p3WUh0bm5xVjJVeDYvOGtPb3JUK1AxN3l3Z1NQbkR1ckFyT2VYUlI1bklk?=
 =?utf-8?B?Nk1hR0l0djdsQ0xDbFN5ZHJPODQ0WDBBWEtCN1orODhDSXA1QmlHaG5NODhw?=
 =?utf-8?B?M2Y1RTFWUmVicUNCeHppa0Y5M3NzOTJ3V05IbTZaZThoMzl5L0VHOUFkRE0x?=
 =?utf-8?B?dWNlSSt3eHk2TS9KYVJrcTgzdmxvODlOcHlWZTMreWNBc1ZOcmtTMGJlS0tz?=
 =?utf-8?B?SUQvbjk5RXkreDhtcFFuRmVkZ1kxTVV1bGdTdXhLMUNsalY4NXJocVV5NEdW?=
 =?utf-8?B?Q2VpUjZFOXpYVGpWVWY2QkdOZ01yenVjRDJPTEtkMkZyZGdENzZIeE1BTnRp?=
 =?utf-8?B?UHAydnptOUNkcWxST203QXl6MDNjaW4vZ0pCanp0bDhWeWRHQU55d01GY3Fo?=
 =?utf-8?B?ZnRyeHV3Rzg3Um0vaktrNFlOTXh5VHYvcW1kWU5UZHQ3dTgvaFEyTUhVRWl2?=
 =?utf-8?B?Wm10VXlvT3RGN21ESlJiMzJ5cjVMUER4Yk5wbnJGOTl5OFpSTnk5WHJNbmFP?=
 =?utf-8?B?N3RzTkNmZkZndTg2ajN4QVdVRWl6NThGd2tLbWJIdXhZVHQrTEdIWlVINkZX?=
 =?utf-8?B?S2tHOG95eUdzYmlrVmVEZ013Ukp5QnI3a0ZFSzdEMHMyS1pqS0ErUWVDSmJw?=
 =?utf-8?B?S2lRdzFJS3BFcUN6V0R2NE04RnBTZllOZloraE5ZejQ0ZnJaeDNra1FzcGRT?=
 =?utf-8?B?NzgvVVpiMnNDUTRNUlRXd0xnVXlPbkJwblpUcDJpNERjWHJHeHBmVVZkRHZn?=
 =?utf-8?B?elJwbWhUMWpLRzd5OXFHaTFqRXh4UmhsUkdoTG5FUk1qNmNTaWhIRUg1RU11?=
 =?utf-8?B?Y25EL3RUQk4zQ0VqRTVjNHNpMEs1SXo0Vm42ckFVRUxQc0pmZG5hTlgwa085?=
 =?utf-8?B?VjZwQUNyeGE1ZGdZSTZQaHB5NjNWQXYrQVc1ZGtVYS9wOVZJVUFuakxtN0R0?=
 =?utf-8?B?aCtSbHpWeUgzM2RGT3dsSktJQ1hZbWhMTCtSV0Nmc1F1NGpHVkhhMWR5RllT?=
 =?utf-8?B?UXZLU0xDaVlJK1F3SVl2R3NnVncrSnNpU0szNjNtdFJtSkVUd0w0Y091bWFi?=
 =?utf-8?B?OGlibUxjQ2FRaEpXckd1dkR4RlJHQWt3WTc5TlVIZm5rbUlCZ0pPRisydUh1?=
 =?utf-8?B?ZmVjcisrNDQxSEdUUjBKaE01eXNyUFM3ZjFIZFZqVGJmdWNlWk8xYnkzbVdS?=
 =?utf-8?Q?NFGLDGOvReOo8oYXDnhkZVxvKpXDiZqAzk+FpMV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f1660fd3-ab73-4b54-7b3c-08d9900bfe16
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5326.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 18:45:43.2567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cNfO1ZjjuYqeBvNlp4NFRI9HOb7hgxJ/AMu2d+J63glzjRsh6EhEQ3ajv+tG+BWamZCDjhDvzjVTtnFF9CetBGivRex+3FyCnCHCgzdEOHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3851
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/14/2021 11:55 PM, Florian Fainelli wrote:
> On 10/14/21 12:23 PM, Rafael J. Wysocki wrote:
>> On 10/14/2021 6:26 PM, Florian Fainelli wrote:
>>> On 10/14/21 12:57 AM, kernel test robot wrote:
>>>> Greeting,
>>>>
>>>> FYI, we noticed the following commit (built with gcc-9):
>>>>
>>>> commit: bfcc1e67ff1e4aa8bfe2ca57f99390fc284c799d ("PM: sleep: Do not
>>>> assume that "mem" is always present")
>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>>>>
>>>>
>>>> in testcase: kernel-selftests
>>>> version: kernel-selftests-x86_64-c8c9111a-1_20210929
>>>> with following parameters:
>>>>
>>>>      group: group-00
>>>>      ucode: 0x11
>>>>
>>>> test-description: The kernel contains a set of "self tests" under the
>>>> tools/testing/selftests/ directory. These are intended to be small
>>>> unit tests to exercise individual code paths in the kernel.
>>>> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt
>>>>
>>>>
>>>> on test machine: 288 threads 2 sockets Intel(R) Xeon Phi(TM) CPU 7295
>>>> @ 1.50GHz with 80G memory
>>>>
>>>> caused below changes (please refer to attached dmesg/kmsg for entire
>>>> log/backtrace):
>>>>
>>>>
>>>>
>>>>
>>>> If you fix the issue, kindly add following tag
>>>> Reported-by: kernel test robot <oliver.sang@intel.com>
>>> Thanks for your report. Assuming that the code responsible for
>>> registering the suspend operations is drivers/acpi/sleep.c for your
>>> platform, and that acpi_sleep_suspend_setup() iterated over all possible
>>> sleep states, your platform must somehow be returning that ACPI_STATE_S3
>>> is not a supported state somehow?
>>>
>>> Rafael have you ever encountered something like that?
>> Yes, there are systems with ACPI that don't support S3.
> OK and do you know what happens when we enter suspend with "mem" in
> those cases? Do we immediately return because ultimately the firmware
> does not support ACPI S3?

"mem" should not be present in the list of available strings then, so it 
should be rejected right away.


> I will rework
> tools/testing/selftests/breakpoints/step_after_suspend_test.c not to
> assume that "mem" is always available, since it may not be.