Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        a.zummo@towertech.it
Subject: Re: [PATCH] rtc: class: don't call cdev_device_del() when cdev_device_add() failed
Date:   Fri, 15 Oct 2021 21:12:21 +0200
Message-Id: <163432513381.815620.221714122932676041.b4-ty@bootlin.com>
In-Reply-To: <20211011132114.3663509-1-yangyingliang@huawei.com>
References: <20211011132114.3663509-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 11 Oct 2021 21:21:14 +0800, Yang Yingliang wrote:
> I got a null-ptr-deref report when doing fault injection test:
> 
> general protection fault, probably for non-canonical address 0xdffffc0000000022: 0000 [#1] SMP KASAN PTI
> KASAN: null-ptr-deref in range [0x0000000000000110-0x0000000000000117]
> RIP: 0010:device_del+0x132/0xdc0
> Call Trace:
>  cdev_device_del+0x1a/0x80
>  devm_rtc_unregister_device+0x37/0x80
>  release_nodes+0xc3/0x3b0
> 
> [...]

Applied, thanks!

[1/1] rtc: class: don't call cdev_device_del() when cdev_device_add() failed
      commit: 789c1093f02c436b320d78a739f9610c8271cb73

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>