Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2392232pxb; Sun, 17 Oct 2021 13:36:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi31OavrFr6dzBZpMNpFqCqQ37gTA32GLHULbAjvSkw3UtsQjkQIYqZ5QlJ5Pr6sK/Q6Oi X-Received: by 2002:a17:90b:4f8a:: with SMTP id qe10mr28482974pjb.27.1634503017413; Sun, 17 Oct 2021 13:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634503017; cv=none; d=google.com; s=arc-20160816; b=v3Z1HPUs6GiYOHXHI/F0KdhVyFgFFPDK1+aKCR7uO2/hHm5t0zGKyGKjlYh3km/lo+ J4Lfh26vFGUjxKKhaswbqeNxjA6b0FC7pTkDNz0tb2Vx8gfe1AQNbWI6ZEtPI70VPexA 2E30Yw3hgkl45Kio5o8kmyHMpB+8CNWTdJceP1MKVXq7AGJ8H+Urfkprhw4XQZFv3Rxn oEr8O9Nrjnpp5fpZYMoMryGmxPvY18lSF5KUDr8/S+FHS2uMljt/mnnoOiIiE6bQhzhW 1yUcI1KJF18yuW7ueKuR+QCJ05HC+QEFwc7xeeoSmBJqnFJ9TJqKAu0k93634OWt2Sdf SbFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9KpRg3yjD3TMogVgB2sicE+XBvozCj2SfoyCtHCzc7s=; b=0PDmqr+HuWJOIsRn7bBmRhRX0YR1eEx3GKzNseUQzWhh/xCKUIdAMKWpwoEvRfgXNz DwNeovBjxF1qBXqQsJjvskuzNDlYl21z8ZVI9fjKRc/Nk7d+DmGHuHe60f9uI+pUiIGd YzMseiLBxc4KHmn8cMpjols9XUcrGgDHgWBGBjRulhSm4MmRGlBofyzUDxFfijcVVwX5 cal3zUqH3oXsdDQ8atZmwkRcJPSrzebgBkoUsF46CoGxepgQLb7ZqNakmQijBLuSBXSc HnRz5hYicLH7cAUYtlBzf6PyfUM+5O5MKUYkdSpXD4pnmQBzp+Us0qx2uq+ZRYV0kZTs UAjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si23818500pjq.23.2021.10.17.13.36.45; Sun, 17 Oct 2021 13:36:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233818AbhJOTOg (ORCPT + 99 others); Fri, 15 Oct 2021 15:14:36 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:43041 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234151AbhJOTOf (ORCPT ); Fri, 15 Oct 2021 15:14:35 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id EE94DE0007; Fri, 15 Oct 2021 19:12:26 +0000 (UTC) From: Alexandre Belloni To: Yang Yingliang , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Cc: Alexandre Belloni , a.zummo@towertech.it Subject: Re: [PATCH v2] rtc: class: check return value when calling dev_set_name() Date: Fri, 15 Oct 2021 21:12:22 +0200 Message-Id: <163432513382.815620.12291665932227521048.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211012041629.2504158-1-yangyingliang@huawei.com> References: <20211012041629.2504158-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2021 12:16:29 +0800, Yang Yingliang wrote: > I got a null-ptr-deref report when doing fault injection test: > > BUG: kernel NULL pointer dereference, address: 0000000000000000 > RIP: 0010:strcmp+0xc/0x20 > Call Trace: > __devm_rtc_register_device.cold.7+0x16a/0x2df > rv3029_probe+0x4b1/0x770 [rtc_rv3029c2] > rv3029_i2c_probe+0x141/0x180 [rtc_rv3029c2] > i2c_device_probe+0xa07/0xbb0 > really_probe+0x285/0xc30 > > [...] Applied, thanks! [1/1] rtc: class: check return value when calling dev_set_name() commit: 24d23181e43d72ca692a479e70dfe5b0b5dd33f1 Best regards, -- Alexandre Belloni