Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2519408pxb; Sun, 17 Oct 2021 17:40:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUOwHT/HeUNucA9wOVHLC3t8imHXuY+ZNNEBXxyX4hriBUmahkxrog2tX61q1c4PpjkUfO X-Received: by 2002:a17:902:e282:b0:13f:62b1:9a06 with SMTP id o2-20020a170902e28200b0013f62b19a06mr24234348plc.1.1634517622121; Sun, 17 Oct 2021 17:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634517622; cv=none; d=google.com; s=arc-20160816; b=LbjWNuLvjBlE7hW6vQEfnRBKGLbfcoX9sgjY9lSSh+VaYQ5jceWlOKop+P9Hi1obMh LbKMC73/W9ffiQuVdaM2OWPCST5O8O56vdcUDZQE4Q9gSzYDVYsFbCrmty2L+AycF8md UD8gFC9CwnyZvi9ih1SR74foVssQC0BejHeY4fzgkwgYlR7393+D7vjF3InF4YBuBxFe jk0CQflnCaoTk+gDdcnMZ3Mw7kf22LzDdh4aUYbGSxcdXqPTI/DAdLgpPt/AnxG0UFUv ruMVhd/GHOCU/viWlD0s86vl1HHID1A98IWa6IsbBV4ZBIMMeSn6tlg98G8/cLe+d8rp 3gxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=syQH1buZLoroFXNERWBQUNYOLOPLwK56KqX3hYxQKZY=; b=fop3We5L97aQUsLkDOIb6AasGUrbMm74t5CzcOYEHmFp9PY7MgBak29cO5SOia7ctH IpBOGEsty6s3k+ja0ZVng2HmcO8S7xjZsKk3lENdBDEMLpHfvdhLgvzDrOU27JvJb2qV R1GoHoun4iV4iRdSzzG+WE1rHs+6LIn2QvcL3sHQL9Q7qcixaxGgvSK3B2FJRseal+91 J9BFGCN+e9vrOSNLOLtrXLzJX2qntKkZgCHOhdlgbAxpQ2Va0Zl0T6bak2N4jmZPEXlg flb9gRgvxVZIOpS1tTx4EFM6UBkyOII8nXq4mv880d861oZuT5J0BvtVFmINdAI8XYEN azUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VUWIy5Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s35si22627392pfg.92.2021.10.17.17.40.07; Sun, 17 Oct 2021 17:40:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VUWIy5Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242880AbhJOT5g (ORCPT + 99 others); Fri, 15 Oct 2021 15:57:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:52396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242867AbhJOT5f (ORCPT ); Fri, 15 Oct 2021 15:57:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E64A61181; Fri, 15 Oct 2021 19:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634327729; bh=uKWdkwX9NSpxgNBJUsKI6brrTvS5lkZVCUyevjasO24=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VUWIy5Fv534KjAIcIc4BeurLiZrgBQGhUIc+tNGNCGwSSgMTryAKKzaXG6Lf2ExLQ nUimrhT6T448pHEv+OJK9rN58B+fiLxSjN3MzyZ9Yz7L2UtkR8rALhcyiJPXmkCSS5 Uknr+liDuXPKBoe3nffM4bIgNKhRsIUBz7jlrnQHlt14Z80MLNJ34Q3HOuRK3VwL9p SnyTZSH2BwiYCo1PIAmZ6HQKmoZDkH7PDBBI5AuNc3myDD1xs2JQXpMlmwr86dTYsH 3LcO6QOJVjPiCky1F71vuAB04UiePhkedgbqJ/+JrMFIKC2LGv9Hz4X0yb6CtBPose e/biAPjuXycog== Date: Fri, 15 Oct 2021 12:55:27 -0700 From: Jakub Kicinski To: Rob Herring , Vladimir Oltean Cc: Prasanna Vengateshan , devicetree@vger.kernel.org, Rob Herring , Russell King , Ansuel Smith , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Florian Fainelli , netdev@vger.kernel.org, Vivien Didelot , Andrew Lunn , Shawn Guo , Vladimir Oltean , "David S . Miller" , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/6] dt-bindings: net: dsa: sja1105: add {rx,tx}-internal-delay-ps Message-ID: <20211015125527.28445238@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1634221864.138006.3295871.nullmailer@robh.at.kernel.org> References: <20211013222313.3767605-1-vladimir.oltean@nxp.com> <20211013222313.3767605-6-vladimir.oltean@nxp.com> <1634221864.138006.3295871.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Oct 2021 09:31:04 -0500 Rob Herring wrote: > On Thu, 14 Oct 2021 01:23:12 +0300, Vladimir Oltean wrote: > > Add a schema validator to nxp,sja1105.yaml and to dsa.yaml for explicit > > MAC-level RGMII delays. These properties must be per port and must be > > present only for a phy-mode that represents RGMII. > > > > We tell dsa.yaml that these port properties might be present, we also > > define their valid values for SJA1105. We create a common definition for > > the RX and TX valid range, since it's quite a mouthful. > > > > We also modify the example to include the explicit RGMII delay properties. > > On the fixed-link ports (in the example, port 4), having these explicit > > delays is actually mandatory, since with the new behavior, the driver > > shouts that it is interpreting what delays to apply based on phy-mode. > > > > Signed-off-by: Vladimir Oltean > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): FWIW I dropped the set from pw based on Rob's report, I see a mention of possible issues with fsl-lx2160a-bluebox3.dts, but it's not clear to me which DT is disagreeing with the schema.. or is the schema itself not 100?