Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 09/23] x86/resctrl: Switch over to the resctrl mbps_val
 list
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        Jamie Iles <jamie@nuviainc.com>,
        "D Scott Phillips OS" <scott@os.amperecomputing.com>,
        <lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
        <tan.shaopeng@fujitsu.com>
References: <20211001160302.31189-1-james.morse@arm.com>
 <20211001160302.31189-10-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <af0d23a9-61b3-8a2b-7f4c-4d2d6d510238@intel.com>
Date:   Fri, 15 Oct 2021 15:26:50 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <20211001160302.31189-10-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clpmazFtTmhWRW92b1FpcDNxZGJMdkFvZ0xQLzNUUnRsV3QxbUNwU1FTdDFh?=
 =?utf-8?B?MWswcEFDUkt6dG1HQ0FHSHBvelZyRHdlSkFoZ1RrdlBEa0VjMVZ2NmxueVJz?=
 =?utf-8?B?aHhBbkxSUWtKVlpGbWpGVk9oZC9iMzBPaTh3UktUT3pVQWlWcEJydmtCR1Mr?=
 =?utf-8?B?cWZ6NkgxOUUrNHdmOVJUaU9rUU8wN3ZxSHZIRUpWOXo5RFRPcVFWVWlXY2lj?=
 =?utf-8?B?MnFNRjJtREFUdnJRU1lIbkxMbHQzZUhtQXhoVCs1RUYvUFo3QnhqWW85bThv?=
 =?utf-8?B?bngzak02YU1pc0xZUGFId0JNKzlFcWJFMVNCV1Fid01SMDBNdUF1alYwRUxW?=
 =?utf-8?B?M3FxUnpKeGdTaC8wenB4bWZJclFiK05SUkcvT1MxUThBdXAzenFmd0ExQkl2?=
 =?utf-8?B?SG1hNTQ1ZlRPdGdIQ3lIelF2aGZZQmNiR0doWkMxakppMzZCeU1qSTU0bHM3?=
 =?utf-8?B?cUFwT2hRaC9wOEcyazc3aVllMy92ZGpFeXpyV0NDSHBMZW5VRTJ4cHBmcDJs?=
 =?utf-8?B?OHZOYkJhYUdyckpGWXZxalhLRTRNelJsWEhGdDZIYktmU1k4U3Qyak9wWTBM?=
 =?utf-8?B?YUtiTlVSZnBGby9CWTJmWnAwdExGSnhtOGk2Q0JScFBSb2liNkZyV0hnL2R5?=
 =?utf-8?B?UXIwVCt4L0tNVnlqalhhTTdWRVJjK3Z1dldmc2ozV21LWG9zeWFPKzd3Q3Zj?=
 =?utf-8?B?N1hJcVNYcExaNUNwUlVybVVtejB1d3VqV1hHdE5rbDd0azRta0dTcjh4ZGh6?=
 =?utf-8?B?Z09DYzIyR0x0KzdaVTd1eVZYbUFhelBwKytGNXdZRitlSkUrcnpOVksrR0Jy?=
 =?utf-8?B?bW9ZRHYyOXBOSFYyTHZxZi9nQUNqbldJVzhLbVFMSENlVVR1cnZ4RUVEL04r?=
 =?utf-8?B?S1NOR29qbVJhS1VDWmJCOTBIbUhMMWJldmtsWXJHMURkUkcrYk1VTnU5aVo4?=
 =?utf-8?B?bjFYaHJ0MkpibkhaZDhFRm1KdjdJOW5zeHAvd3kzWTVPbU4zT2o0TStPSWlj?=
 =?utf-8?B?SDJDMG8xcWw5S0dmWGQrV1Y4emp2SkpxUE0xdGhqRDN1SENyNEhoWFhISk1v?=
 =?utf-8?B?NWlnbGRrYVVVckdITHVoSWIzYlpjaWtsKzJjQTZkMmJpZ3g5WE5TWU5jN2Vk?=
 =?utf-8?B?cEhlOUV2L0o1ajRqL29KVkdITzhLOEFSeVMzc0xPandTakRXZ3BhUjFpcDd0?=
 =?utf-8?B?YURiQTBZeEt3QXZmeVV3MFpRY2l0RmhVcllPTjNGZWpGYjVjUDFoRE5sYlZN?=
 =?utf-8?B?N2RVeVpET0pXV29iRGs0MXdwU2ZvRUlCOWJPNDdxKzU1ZWkvRUJ5WlNlRDhI?=
 =?utf-8?B?a3Z6TGl0QUxmeml2ZnFKQXVwdkxNb0l5Rk1tZjdsZnhCbzZtTm1SWGEyTzEr?=
 =?utf-8?B?TUNlekpCT2hxcjI3NDA3bGFJUlVRT1hXaURyeVN0a3dwSlZkWERoUk92bXlS?=
 =?utf-8?B?SVRpNTZsNndPeHhhczdueFVLYlp2Y0xrLzQ2N3pJRlNwUDZsWk1IclJxOXhP?=
 =?utf-8?B?dXVJa0dIV0ZnSWFReEJCYzhWNGtURklYWGZmNGpsYTgxNU82cDcrVWVQRitK?=
 =?utf-8?B?QTNHWmthTk5NRmc3Qktjeml3dWJscTZzelpLL2lhaUVnNTZJamhkRHRRMG5O?=
 =?utf-8?B?WFpna0RCc2ZrOVpYdE1xRU1INWxwZ3dFZVZFTHZNRWVUc0l1Vm9mYkphR3Vz?=
 =?utf-8?B?SHNoRDVTaXlYMnJWRHRwazNucmxsTEt3VkV2NE53RjBQcC9rSmN1T3VuQjB1?=
 =?utf-8?Q?VHLuX+s4qT2MXdR+x9wg2Bdg2wS9RbwyDQH+9t3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 53b0086c-d831-4e1a-5dd6-08d9902ae54a
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 22:26:56.1628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hADE71wTJxMIdbNIgxfqgxVhMrALfF0UeIV/d3Cg2QFNmYyhQ/KfHGGBCLFVeWXylxFIjF2Y2t/xPsEeGk1cV8SJlwZM7nJDtAgycs1yJJ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5291
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 10/1/2021 9:02 AM, James Morse wrote:
> Updates to resctrl's software controller follow the same path as
> other configuration updates, but they don't modify the hardware state.
> rdtgroup_schemata_write() uses parse_line() and the resource's
> ctrlval_parse function to stage the configuration.

parse_ctrlval ?

> resctrl_arch_update_domains() then updates the mbps_val[] array
> instead, and resctrl_arch_update_domains() skips the rdt_ctrl_update()
> call that would update hardware.
> 
> This complicates the interface between resctrl's filesystem parts
> and architecture specific code. It should be possible for mba_sc
> to be completely implemented by the filesystem parts of resctrl. This
> would allow it to work on a second architecture with no additional code.
> 
> Change parse_bw() to write the configuration value directly to the
> mba_sc[] array in the domain structure. Change rdtgroup_schemata_write()

mpbs_val[] array?

> to skip the call to resctrl_arch_update_domains(), meaning all the
> mba_sc specific code in resctrl_arch_update_domains() can be removed.
> On the read-side, show_doms() and update_mba_bw() are changed to read
> the mba_sc[] array from the domain structure. With this,

mbps_val[] ?

Should rdtgroup_size_show() also get a similar snippet?

Reinette