Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 13/23] x86/resctrl: Allow update_mba_bw() to update
 controls directly
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        Jamie Iles <jamie@nuviainc.com>,
        "D Scott Phillips OS" <scott@os.amperecomputing.com>,
        <lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
        <tan.shaopeng@fujitsu.com>
References: <20211001160302.31189-1-james.morse@arm.com>
 <20211001160302.31189-14-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <777770fa-c2fb-f091-13f8-a204869d8ab5@intel.com>
Date:   Fri, 15 Oct 2021 15:28:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <20211001160302.31189-14-james.morse@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NENteVBnbThKK1g1d01ZNmdzZkpLeGY0UjlRWUZUQlR4TzMvOXRGeDNpa3JT?=
 =?utf-8?B?ampRWSs2WUJCUTM4aTQxNnZZUGFRSWp0RnNkN0dLYnlWRWRUay9QeWZSZGRW?=
 =?utf-8?B?Um83L2NGZFdvZS9LWm9NY3MvUW50Vk84U295dWVQbjFoV0kyc2hWNjdIYVVy?=
 =?utf-8?B?V3ZIVHJWNkFVLzl2K2V2d0dqWWZWaERLWmliWFVZZEFvOXJ2N1BxQnBvc25J?=
 =?utf-8?B?ek5Uanl1QTVZTFZnU29BMU9IMjJwODNTVkllZlJyTEFCNGNyWFNxWU10TFVL?=
 =?utf-8?B?ejNzTlNqOGU3eXQ2RStrVGJRdytDUGRlQ0Uybi9Ec1pkVDB1K0xhMTNXejkx?=
 =?utf-8?B?a2dZSFo5Sk8wQWFtcWFGQjIrbjB1b001dFJKQnpjL2FrOTVPektlL1M4RnF5?=
 =?utf-8?B?eG9saFZDQXlDRWxITklRZTVyTGlwa1h0L0pvZU1UdC9xckxrTEFZdzl5aWZL?=
 =?utf-8?B?RWRqYWxRMTY5Nm5hcnpsd0o0N2RNcGt6SCtoZmNRMWpXQ3VWMWppK0RoLzdR?=
 =?utf-8?B?Y3V6cE1LR2txdTE2cnlybUxYa1dZbDBrMjBad3pKWUdBVmVhNEF0NWxQNGov?=
 =?utf-8?B?WUIyTHBXbisxODdlTzlZVHk0K3VveWsvVXJWdkwvdGg2eExkSVpHSHdBWFFi?=
 =?utf-8?B?VWhvMzFVbnZYbTlXbXJJb1RFdjBLbHh1UDBmRlBpQ2JqWHo3MXoxSVRJTWk5?=
 =?utf-8?B?Y3AwcEp3S1Q1amFXZFkwNTZ6REx5SDk3Tyt4djFQaUlBTldYN1dsZWU3dlFw?=
 =?utf-8?B?VTdkU2FEdUZoaEt4VS9VeVd0UWNDYWtrWVJNNjZadjhXYWxyYXhHSFZ2bnR2?=
 =?utf-8?B?OW5yUmgzUVZsUFlNOU5hOUtEUXJJay9IM0RIbDRnZjJVdTZiYUk1UzZLT3VI?=
 =?utf-8?B?ZE10NmJxcjhGTUkxOU83ZmVzV2FoblpVKytiUUJJb1JQdlhHd25ORG9OeU1s?=
 =?utf-8?B?M2N3c3FpcEtEZFBDRUdaT3RtaGk5Zkl5ZnRTNDhrQzRoajRuZmdheTlFWmtD?=
 =?utf-8?B?UkYzZlNWUzdjOHkwem9HNjJjK0JVa0NhMHNkTmtQUUVYS1BGWXZEcDRicFdr?=
 =?utf-8?B?dDFIaWZZcFJRK05lcng2TDV5UGRyem5UWk5hVTJJMTJkYkpkcUdLMXVhOVdG?=
 =?utf-8?B?RHJtZkJVczZKUWdTR28zK21xYVE4M0F5YSt2ZlFYZEJvWVg4ZVlYL0xYRkx2?=
 =?utf-8?B?VHR1SFpnRm5OR1BBMlVRRmFOMytNZWFhanRuZW5vRCszNzhQQTJ3VkxkRmNM?=
 =?utf-8?B?bTk5eVFXbndxZVpnQXpPNjhhUk1LcnpNWTlrcUJQMyt4aWUxbXZzTi9LdFJI?=
 =?utf-8?B?Y2QvWWhMY3p5c1JHUFlmTFFpWi9FQ3YrTmhITWppTGUyU0I5V29zb2RVWjZk?=
 =?utf-8?B?eEFOUmZKN1NsQmRrT01POS9DZy9MSXZyVndFS2E4QkZMQzlyZUNvUmNYTkQv?=
 =?utf-8?B?M1NMSU5YcmpYTWhrT1VaeFhzbEdMaDJMRFZYUHUwam5yZThaNlFRV2xaVFlK?=
 =?utf-8?B?VGIzVTZHNnh2eHlVTmNWVUFBc0xvc0grVDU4TmxmRnZZQ0M2VmtyUDNEbXBt?=
 =?utf-8?B?d2ozVjJBcG1pd1V0Qi9CQTFyOFM3TWN2NHpaODJGeGkyNy8yNnBtWTlsVmk4?=
 =?utf-8?B?aUttQ0V4b0MzZzE3OVR4NlYxeDlsYmhFOExuMk1hRTZjK2w3SUcxaitVOVcy?=
 =?utf-8?B?emxFZXcwdmVjb1FNT1dKdk4vRWdsWUV2ZEpQSjFySmRmY3ZEQVB4SHJHT2lU?=
 =?utf-8?Q?DwQEP6hR1V4MEG6oXDCPSOEFt6lZyP3U9Jd8NFR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1592d171-50f2-480c-656e-08d9902b1b39
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 22:28:26.6625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uORNzAF7Wy7f8LGjqWTVbD2QG4NWA3cHcF8kPY8aIU4Pf9kOp01Fmir6LxZBBkh6Rtz/CjO+LUJbByCuwklqTJ/C5H+h5Uw6h0hAVxaEzwo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1299
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 10/1/2021 9:02 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> index 9f45207a6c74..25baacd331e0 100644
> --- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> +++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c
> @@ -282,6 +282,27 @@ static bool apply_config(struct rdt_hw_domain *hw_dom,
>   	return false;
>   }
>   
> +int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_domain *d,
> +			    u32 closid, enum resctrl_conf_type t, u32 cfg_val)
> +{
> +	struct rdt_hw_domain *hw_dom = resctrl_to_arch_dom(d);
> +	u32 idx = get_config_index(closid, t);
> +	struct msr_param msr_param;
> +
> +	if (!cpumask_test_cpu(smp_processor_id(), &d->cpu_mask))
> +		return -EINVAL;
> +
> +	hw_dom->ctrl_val[idx] = cfg_val;
> +
> +	msr_param.res = r;
> +	msr_param.low = idx;
> +	msr_param.high = idx + 1;
> +
> +	rdt_ctrl_update(&msr_param);
> +

rdt_ctrl_update() will take its parameters and recompute the domain that 
is already available here ... seems to take a few steps back and then do 
the needed. Could msr_update be called directly here instead?

Reinette