Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH v2] workqueue: Introduce __show_worker_pool_state and
 __show_workqueue_state.
To:     Tejun Heo <tj@kernel.org>
Cc:     jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
References: <20211005213841.736834-1-imran.f.khan@oracle.com>
 <YWRqxS4IMVW4ZCN/@slm.duckdns.org>
From:   imran.f.khan@oracle.com
Message-ID: <2e94a048-3300-19f0-2106-a838af0b3731@oracle.com>
Date:   Sat, 16 Oct 2021 11:26:43 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <YWRqxS4IMVW4ZCN/@slm.duckdns.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azc5SmZyZGtyNW82azFLbUc5eFVHSzl4WUFMZTE3aTAvSFJ5Vm5MdkRJSmNW?=
 =?utf-8?B?VHlPVnVzVXdURzhZZHg4Nm5iajVxendaODhHY3JFMWhPaWlza3NuN0JPN3JL?=
 =?utf-8?B?NVZXOGFKM2JNenc5d2s0Z003TnFwTjFOY3E4VVk1SkpCdnREVWJrUU1KNFl1?=
 =?utf-8?B?L2gxOWxCK3oxbm9hZHR5UmpGMWk0RzlQc0dCT0oxK05ydzFuVW5OenBBLy8y?=
 =?utf-8?B?ZjJwcjVuUUZtV1YyQnVjTVRpNnJEUjlwYVNCcXdIQlhkWXBMM2JXZGJrWXhj?=
 =?utf-8?B?TVJHQWxPcStrS2daTTRhcmRzb0hNTDdKdHorc1M4WldEdStyNVBvT2h0OUlm?=
 =?utf-8?B?RC9HTDVkU2lkeHFndFpQc2ZMcmhNeUM5dTZBRUFGdE1sWWhqQXJML0luZkVa?=
 =?utf-8?B?Y1FtNGFCK09lenYvOExub2xLRDZTaUdHYlpLSXF6ZzltQndnZFFwWGRxU2ZD?=
 =?utf-8?B?YTNnS3ZhMFJ6L2J0VC9RdjBsWmJmYnJRcUtvMWQ3WjRvMFhlWkNscHVDand2?=
 =?utf-8?B?VnVaRTBsMVcyajJqdk1QVzNSN3ZnUndxTDVkUFVHak1KUjJoSzE3VmVUVXpX?=
 =?utf-8?B?THE3Zk16eHJDM0h3YVB2R2tVMGIwT0srMXBHdExjSUJIQXlrRWtiN0o4a09m?=
 =?utf-8?B?aUFQU2k5a2VTK2lxNVI1Ym5kY2ltOGVxbzN2UUR4Z3pVQ0RDdzBNOGJSUk9y?=
 =?utf-8?B?Yno5ZmJZakhHcHlCZGpqTlE5dDVEc0swRklXb3o1Y2RPS2hURTMrM0t4WVpW?=
 =?utf-8?B?dHVnOWhhbnZnUDZvL2tuQzNGREdRU1BGeE5jV1Iyc1NXSGFsSGtQVVRKY0s3?=
 =?utf-8?B?bm1aWHI4M3lVbytCUnpRaC9ZVk94TXpyVFZQMXFLS09tRElxc2MyM0xOTWJX?=
 =?utf-8?B?RVVsaUtiN1U5T0pDVStYelpCU2lKMk1SRzY2MVl4L25jU2lvODVhR0N2Y1lT?=
 =?utf-8?B?NVFMQWpiVG02YjdLWm0wVHB2Um55OU8vbFJqL3hmYWhydUJ1SDd4VS9TSmJj?=
 =?utf-8?B?aU9XZG5oekdGb2prMmV6YkYzSEh0SVprQzllWWY3ckM1azBuNlU2OHZDLzVL?=
 =?utf-8?B?WU5pelM1T2lyZkpkbkZuUjdnd084R0lBVk50YU0wZUtnNFMxRUlDYlhiM2xL?=
 =?utf-8?B?eXAxeno3VGRmemU4QmJMeDBMTW1PcytCZUhoWUZBZ2hmVkR5eUpOZDJoOUJS?=
 =?utf-8?B?S1ZaN2xGaUE5cU4zK0RLb2NPejdwV3FHTDBpMU5iV0ZXQUUxNVo1S0lBMmVw?=
 =?utf-8?B?YVN4bDFJN05XU1V4Y2F5TU5MWmNIZmgvRFRYTGp5QWJuQ3FJVkxZbmkzNEdK?=
 =?utf-8?B?NWcyamhVbXhvbTRMZkJCK2FhWnZjd2hjeWFkeEloSFFhS040NU40RTFvVTl6?=
 =?utf-8?B?aDlFdHhFcHcxRlNSSC9VRWc5TGNZbytjQjFqclZGQ00wODYxOXpveTkrTVhu?=
 =?utf-8?B?SUg1R3JRdzd0di9uelpIUXk0bEg2VXN2aWRLV2thWnFSTnZXUTdJSEhBcUNp?=
 =?utf-8?B?ZExTTStjWUZiQjVHMTkzUXNydzRNOUt2MHRBbVhwVFo1VHYvVXpUdkZlRVZl?=
 =?utf-8?B?OGs4VGhYY1NwWTlxU2dWdHRXSjBPRWxkcDZOVnBTbTMzRnh3MTBvREIzRkh3?=
 =?utf-8?B?eXRpa2dsVjBUQmxqa29tNG1CT28zUG8rV2JHaEluVmIwc0pncWpDWm54ZEVs?=
 =?utf-8?B?OWYzYmhyZzhoaFlkNWtHSENDRy9MSm5BUlJ4ZXdoWVM1bW1UYTRXSjVvSldW?=
 =?utf-8?Q?oUJhR6M3EP6MEk14VcfBvnMVoGePh6xeKcnt84Q?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c810c28-24d2-48fe-9ea0-08d9903ba600
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2021 00:26:51.3837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QxpvEmK6dPTwir8mXuWA+FVKqpe4XBKTurGmeWyes2fBQgXGnhu85/vB+yf5fa4OendH4vnMqGfEYxuQjUTI6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1775
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10138 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110160000
X-Proofpoint-ORIG-GUID: aIxIJJuwEjuS2URtSrl3mlg8iPS2y_jS
X-Proofpoint-GUID: aIxIJJuwEjuS2URtSrl3mlg8iPS2y_jS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tejun,
Sorry for getting back late on this.

On 12/10/21 3:48 am, Tejun Heo wrote:
> On Wed, Oct 06, 2021 at 08:38:41AM +1100, Imran Khan wrote:
>> So divide show_workqueue_state into more granular functions
>> (__show_workqueue_state and __show_worker_pool_state), that would show
> 
> This is nit-picky but can we please name them sth like
> show_one_workqueue_state() and show_one_worker_pool_state() or just
> show_one_workqueue() and show_one_worker_pool() with the corresponding
> versions renamed to show_all_workqueues() and show_all_worker_pools()?
> 

Yes. This sounds good to me. I have renamed the functions as 
show_one_workqueue() and show_one_worker_pool(). On the same lines I 
have renamed show_workqueue_state() to show_all_workqueues(). These 
changes are available in v3 of the patch [1].

[1] 
https://lore.kernel.org/lkml/20211016002007.143661-1-imran.f.khan@oracle.com/

Thanks again for reviewing this.

  -- Imran
> Thanks.
>