Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2610456pxb; Sun, 17 Oct 2021 20:25:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw1Hcj1VM/3c4M1D3H78KQELTCOOMBe7yzxhBDspL2tnsrOtb98Cq7WyzRqi1FPutDRfeU X-Received: by 2002:a63:3e84:: with SMTP id l126mr9690176pga.341.1634527550904; Sun, 17 Oct 2021 20:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634527550; cv=none; d=google.com; s=arc-20160816; b=NCXIfZodtK2Tp01lBr2f0vWPr3yL42jXM9/Vh9efsv0+5/apqrUw4AYEXPspbjGNKl rt9cDmFB2vaDrjDkj+OcTtF8eR8bxc6JCY51PCm5c7bEUlHc13DgXdIq1E5U9YkoTM30 zjlUdDEnuCxsrlhCokCakYFP3GYsnNM2Z4Ii7kdLIIqGulgL17ncB3msBmtjdyqeO6na 16Zgqg9yK8mCo3FVQiQ/ZJUdaMj937R030BRTMy4sjWSSewJ4PUw0j8OsZCdVHQb9s6q In8z3M6IGRb4gX7mM7thSiuLd0KSBmjiqLTuio6MVAsphhEgUTz3OR8dG0nnnLJ8Wuak ImwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6VJ+9sIi1sqUsRf5nSziAM0Dhgkx6JgfPmLuGEZTces=; b=v1Qr+Wq2lChfU50r9IcFlq6REU8dcYsgRSHsjIsIoeYM8uDKe2lg0l8MGuF4Ho90tU oJRYhK0s73SY6Zi11bbHPMtQf3Z/KmFbuGQ1bw0s82BAdnG4eoGi7WznhPGcrsXhQrAl NlyJz0OJ2RsKsqDowMmPKOWckYriYAi8iMS+xpuQj0ATLhjrkyufJzeO9Kdw1DdA64kf y1LwDh2+pWR3fNk6NyEspJ2hPojpsoAbTHi1kfIRNOx7QWp+rDDrWEMg7cH6Sw1Kq76u i/5SDxxIoYSimqSwoxBfIySO8VugqfHR+WJXxUEQsyXjwFYeH70AdU7F4ifKQVLNkMCP ITdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=H63SeNNP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si17594194plr.280.2021.10.17.20.25.38; Sun, 17 Oct 2021 20:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=H63SeNNP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243644AbhJOX4U (ORCPT + 98 others); Fri, 15 Oct 2021 19:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239379AbhJOX4L (ORCPT ); Fri, 15 Oct 2021 19:56:11 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0F9BC061776; Fri, 15 Oct 2021 16:54:00 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id y12so45725407eda.4; Fri, 15 Oct 2021 16:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6VJ+9sIi1sqUsRf5nSziAM0Dhgkx6JgfPmLuGEZTces=; b=H63SeNNPhxbZ4wC7PPU0lHqQx61e8P4OAK+AAPDv5gblrGbDXBYKjhgWO57hTx1kVS orr3t90pArPAQI1W78i0x9ahucKgECq1IoC1shjPc9u0cAxrgMlfatpXX32sAJi21VUZ 09I5AKOaQT8di2kM3eN107rMkUQfw9zZ8zqB9wPSQprZke5QM/YJBUTRC+T3vT+kXq/w xNU4sjsufpWnOzcGzIeKt1pZFGapPj+NiL+qy7EifGrYqRAQ1KNsmv2Ewfd4sAgQ1ZzU vFoQuDByjS4Evg0/htdw6+fcFclHTt3b0/b8T4hwrAwfl4cZ/SR8mIrMVEuER/Q98LEY 6N/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6VJ+9sIi1sqUsRf5nSziAM0Dhgkx6JgfPmLuGEZTces=; b=BB4r7rhPTi5k9NQLq8be2uqeOUczItpgPWBfRgeKSNcs4w1qwqwcUrNwHyR2lfqQsd fHMDlfHLu0XGnm2VXwuA8VGal6jDZFwLaF0kjq8DzGMBma3SbgGFudDGWEkq8pJV3sTI NnckBmBZf0uHNTe5YJFVU019lSEDGex+o9GgRM7JfqfAoUVPDtbPNC/UdBAQELZ3UWIE iy0AF7shYQ5LA932Zy3wdbBktcGw7+F9wU/XKTiT8tvPfwVdqKfPE9Mv+JTJ/+3RKUwB yyP+CYJ2yBvmslHor1NH6PFTPGlJp4c3Xf8VM20qsH3+Xf/zfi0DMR164LhT1cO3WXbl 83MA== X-Gm-Message-State: AOAM532oRF301u9D73+KcItFOIWWO7vH7RqsoZTPCUcF9U1hFsacX6TG elitzVbeZdPPsqqH2u1Qnwo= X-Received: by 2002:a17:906:f8d0:: with SMTP id lh16mr10030127ejb.367.1634342039511; Fri, 15 Oct 2021 16:53:59 -0700 (PDT) Received: from p14s ([140.238.219.56]) by smtp.gmail.com with ESMTPSA id nb29sm6357942ejc.54.2021.10.15.16.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 16:53:59 -0700 (PDT) Date: Sat, 16 Oct 2021 01:53:56 +0200 From: Joerie de Gram To: Mario Limonciello Cc: Linus Walleij , Basavaraj Natikar , Shyam Sundar S K , "open list:PIN CONTROL SUBSYSTEM" , open list , Nehal Shah , "Rafael J . Wysocki" Subject: Re: [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI Message-ID: References: <20211015144332.700-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015144332.700-1-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 09:43:32AM -0500, Mario Limonciello wrote: > + if (irq < 0 && !(regval & BIT(WAKE_STS_OFF))) > + return true; Shouldn't be negated. WAKE_STS_OFF is set on wakeup. With that change: Reported-by: Joerie de Gram Tested-by: Joerie de Gram