Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: quic_luoj=quicinc.com@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 9866CC4338F
Subject: Re: [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Luo Jie <luoj@codeaurora.org>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sricharan@codeaurora.org
References: <20211015073505.1893-1-luoj@codeaurora.org>
 <20211015073505.1893-6-luoj@codeaurora.org>
 <YWkzxd7xzTDngoT9@shell.armlinux.org.uk>
From:   Jie Luo <quic_luoj@quicinc.com>
Message-ID: <73d24f3d-3327-5d4b-c308-e5b145cbe6a5@quicinc.com>
Date:   Sat, 16 Oct 2021 17:51:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YWkzxd7xzTDngoT9@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 10/15/2021 3:54 PM, Russell King (Oracle) wrote:
> On Fri, Oct 15, 2021 at 03:34:57PM +0800, Luo Jie wrote:
>> @@ -1431,6 +1433,18 @@ static struct phy_driver at803x_driver[] = {
>>   	.get_sset_count = at803x_get_sset_count,
>>   	.get_strings = at803x_get_strings,
>>   	.get_stats = at803x_get_stats,
>> +}, {
>> +	/* Qualcomm QCA8081 */
>> +	PHY_ID_MATCH_EXACT(QCA8081_PHY_ID),
>> +	.name			= "Qualcomm QCA8081 PHY",
> I don't think we need the " PHY" suffix. This name gets printed in a
> context where it's obvious it's a network PHY.
thanks Russell, will remove the suffix " PHY" in the next patch set.
>