Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <75a38832-b638-a95a-7ba7-f144cd05d978@nvidia.com>
Date:   Sat, 16 Oct 2021 14:56:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH v3 net-next] net: make use of helper
 netif_is_bridge_master()
Content-Language: en-US
To:     Kyungrok Chung <acadx0@gmail.com>,
        Marek Lindner <mareklindner@neomailbox.ch>,
        Simon Wunderlich <sw@simonwunderlich.de>,
        Antonio Quartulli <a@unstable.cc>,
        Sven Eckelmann <sven@narfation.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Roopa Prabhu <roopa@nvidia.com>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>
Cc:     b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org
References: <20211016112137.18858-1-acadx0@gmail.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
In-Reply-To: <20211016112137.18858-1-acadx0@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzNkaHpybEJNb0FhNjhLbTdGNDlTcFVnQnFVdXVZQU9MSGR5VDlrTHhXYmZG?=
 =?utf-8?B?T2IyQWcxN1FrZlVoTC9lQWlvSXNGQ1VUYjlEUEhKWXZFUEYvU0duSGVCeURn?=
 =?utf-8?B?RTM3V25CazlMeGhPM3dENW5DWGZ0bExHSGxnRmZVaWlrS2ZUR01OVHVQRlo0?=
 =?utf-8?B?ZHZjd08zWmVuNUx5Q0dSVWU1NUg2ZFo0UkQ4d2ZNdEp0UUtZVFVoaFFPcm9R?=
 =?utf-8?B?aWlHZHFkbEJOQ0FjczBVUGIwb092Y2pXcnkwL1N6T25jT2ZCSnM4NTh4em9k?=
 =?utf-8?B?U041bHNuODlLbVJsTGsvL09HN3ZjNmhITFI2TW9SRTBjdXpDbTRvL0JHdHlP?=
 =?utf-8?B?clo5d3FzSFZTNTVoRU5hZjFlL2ZhYTF5OGFaa1ZOT3NyQmovamxhTWhuUUxJ?=
 =?utf-8?B?T3ZyUnE5YkE5Zy92SlJoWCtrOFVYNXdWeHpJbFM4VmN5dWlWam5KdU45TUls?=
 =?utf-8?B?elh5ZXNNQmtUMGsrem84Y1k2UVZjMzhzM3R1RU1iS2dLNE8xOURxZ0JvS2lV?=
 =?utf-8?B?R0orYXBkODdBeDJCbytVUXBJazI1Rnk1OGtHK0tpUExBZExNcmpWa1QwUUpE?=
 =?utf-8?B?M05NV1pXNmRyZXBIY0RLdlBHK2FEZVBCczZvS3FzdTRTbXdGZFE3K0xJakxU?=
 =?utf-8?B?NUNoN3lJak9UMlNBNTRLSHpjYUpITmtZL2VZd3paWUEzbGlVc3lLNWcyZUhu?=
 =?utf-8?B?MFpZV04xSG1xNXRNdDB5WkFtUnN6aU43cEtTRjIySGNaYUJuTWtNQlRrRjQx?=
 =?utf-8?B?SC9oV2cybjhFV1hkSjZJZUZoSGFtK3M4S3VpcTA4MFJzY3NMMjdEM2hxV1V5?=
 =?utf-8?B?bS9JU09aS0FXMUdYRVkvTWtHbStNNmI4a2ZmTUE2L3loNXBkb3NVMER1N3h2?=
 =?utf-8?B?dml2Nk02Z0hidmt5ODdWSXZRR3NXS2ZyZGtMTnJvc3dPZlFXNXg2QzhaY09O?=
 =?utf-8?B?bmNmMVFXNTk3Y0UyR2I0UzI1aXA0OFRVN1VIVGMyYWN2d1ovbzMzT2ROT0xo?=
 =?utf-8?B?K1UxQ3RwTTQ1QU9ReGRmZ05PZmF0TnZvbDhEbGpDTU5jbjZ0b2FaRVVUTFFT?=
 =?utf-8?B?WW5zZ20xRHBlb1pTejNtM0QwcUw2UTJMU08yUEpLNGNwQjlkbmhhdlNlM3J3?=
 =?utf-8?B?NHN3SUtvUzU4a3FDUUw4S2xMaXg4LzhaU1daMjZZVUg5Uld4TEVwWnZtd0M0?=
 =?utf-8?B?RFhxclRVRUlQK1RnTU5lekhuTHVKZFZvQ1FTWDM0VkNTQlhYWXFJZEg2YWF5?=
 =?utf-8?B?cTNUV1dMcUZiYnlMUDRycFY1SFhxR3ByaTV5bkNjdklsQVNvRHhVcTJFckJt?=
 =?utf-8?B?MFZ4Y04vR3o5M1YxbHRrckFVOEUvR1lobnJzWExQWXhBRXJOWC8vUVhSU21u?=
 =?utf-8?B?RnF5VGRPUkhIRlFXUDBSMWdpRWlNeWlzbmdGVjZZbTk2bndXQ0lDb01BY3Q3?=
 =?utf-8?B?L0JYMTk2Wk9ENVc3Szc1NjgvM1dBY1RHRGdtWkcxb3VnSXZ1bzRONnhYTk4z?=
 =?utf-8?B?ZG5oNmVWTHhZd20veXJ2Z0RFZ2NSVWttN3hCTW9SMExZcFpwSTJZcDlQTkhG?=
 =?utf-8?B?NzE4STNITHk3Q0lDUkMyQXpLZlF3YzJpaGNYSGxIVFVXZkJaWFZCZDNvdWpY?=
 =?utf-8?B?OWMyQW9wK0RZM1FXbkd2emNhNWNTa255RDhsd010eiszaW5IUnc1am9YNXN5?=
 =?utf-8?B?N2w3OGNvME5JRGxMQUtqcVdDOGptK2x0RGU3d0p1ZVJBeHQ0cTVudURkb1VD?=
 =?utf-8?Q?ZEShiBFRFvyT9h7PgM8QlFlsune/Km7wvV6zBhe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d116dc1-9dcd-4aac-f643-08d9909bf178
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2021 11:56:09.7263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QRXg2h4KywanajeHWgQajlvfiE2vghZOCXm5obif6XEU/I/aJd5IprQbiGjxj/QLynasyFQgC3n4fyx5L2cjaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5567
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/10/2021 14:21, Kyungrok Chung wrote:
> Make use of netdev helper functions to improve code readability.
> Replace 'dev->priv_flags & IFF_EBRIDGE' with netif_is_bridge_master(dev).
> 
> Signed-off-by: Kyungrok Chung <acadx0@gmail.com>
> ---
> 
> v1->v2:
>   - Apply fixes to batman-adv, core too.
> 
> v2->v3:
>   - Fix wrong logic.
> 
>  net/batman-adv/multicast.c      | 2 +-
>  net/bridge/br.c                 | 4 ++--
>  net/bridge/br_fdb.c             | 6 +++---
>  net/bridge/br_if.c              | 2 +-
>  net/bridge/br_ioctl.c           | 2 +-
>  net/bridge/br_mdb.c             | 4 ++--
>  net/bridge/br_netfilter_hooks.c | 2 +-
>  net/bridge/br_netlink.c         | 4 ++--
>  net/core/rtnetlink.c            | 2 +-
>  9 files changed, 14 insertions(+), 14 deletions(-)
> 

LGTM,
Reviewed-by: Nikolay Aleksandrov <nikolay@nvidia.com>