Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition
To:     Aleksander Jan Bajkowski <olek2@wp.pl>, andrew@lunn.ch,
        vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211015221020.3590-1-olek2@wp.pl>
From:   Hauke Mehrtens <hauke@hauke-m.de>
Message-ID: <0abd339a-3a9b-edfc-d697-27fce492bdd0@hauke-m.de>
Date:   Sat, 16 Oct 2021 13:57:59 +0200
MIME-Version: 1.0
In-Reply-To: <20211015221020.3590-1-olek2@wp.pl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/16/21 12:10 AM, Aleksander Jan Bajkowski wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
> 
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

Thanks for finding this problem.

> ---
>   drivers/net/dsa/lantiq_gswip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 3ff4b7e177f3..dbd4486a173f 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -230,7 +230,7 @@
>   #define GSWIP_SDMA_PCTRLp(p)		(0xBC0 + ((p) * 0x6))
>   #define  GSWIP_SDMA_PCTRL_EN		BIT(0)	/* SDMA Port Enable */
>   #define  GSWIP_SDMA_PCTRL_FCEN		BIT(1)	/* Flow Control Enable */
> -#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(1)	/* Pause Frame Forwarding */
> +#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(3)	/* Pause Frame Forwarding */
>   
>   #define GSWIP_TABLE_ACTIVE_VLAN		0x01
>   #define GSWIP_TABLE_VLAN_MAPPING	0x02
>