Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2616471pxb; Sun, 17 Oct 2021 20:37:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyalQG5KAh4D8tPFBBEGOXBzapvrNRcgdIsjz5lz/R7zO4yE+OB+UATkIEAzBGZG7JriQIm X-Received: by 2002:a17:90a:8912:: with SMTP id u18mr29522212pjn.69.1634528238884; Sun, 17 Oct 2021 20:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634528238; cv=none; d=google.com; s=arc-20160816; b=iQhbatJvKcvHSlHFT1O1IDQ9k22pFdO47HSIjJSY2XfVQPg/v3CpXsiQPsQHNwnXFZ 6eSyI4535eBTYWA9bXw21Iy6Pa0BzNsDNFx/oRIj7TIbx0baXWoSyiAvwqsT+9N9cGJD fZ8FCp6A1humEHG1ehSBHABfqSEV2BjrBBaI9oqZ1/nCmYH5YN9Rf5iLZmhADmDB+qWe f/DosNv9ztrDuSbzde66CKJX3/++hv3lBTz+VitUFvsXCZT4JWpYt2wTKrJqlrFZ9obL T+VDP1hlIkNq5xlKAawQqvcKq62yhFemNv26jtXhgKANhHjgDQS+mPmZYnBSxTsrzh+C 1OrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bEDEZvAmdvWI96ksUh1vPO5+Cce7AMzdfq8gX4cXeB0=; b=nIIQtp4w7LcGCBEQKSJ8GbQKvLDgRE0AZFbX2TjHj7rmfuAxeOYfzrlSbfOK78aZ+z WKy207MbTyU34VUaPs/fTPRo0+DL4wDbA1nljVhGzXdfdvYd08sASSotqoA5jYR128Hv n59WupyIUx7nifxrnP+bdCfpDXn+z6Xa5D7Jh8frx7Bx8I9l5jUA7kdQX1bgEtTVLypq j1R2yD4Sbk7TtXRAMHIwZzYCovVVkCbeHKebAbLUpAxst0cPFgGQ/07kVZAxKCRFr/iq dcdAUlRFM+CFyRcGqzmVO5K4aiKYh8LQL6gU+RFWNYj/EpZYbzFFf/V4BkjhJ1hSYcFi DNJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@philpotter-co-uk.20210112.gappssmtp.com header.s=20210112 header.b=Hq6Ke+cY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si9627626pgv.143.2021.10.17.20.37.06; Sun, 17 Oct 2021 20:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@philpotter-co-uk.20210112.gappssmtp.com header.s=20210112 header.b=Hq6Ke+cY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237853AbhJPPhN (ORCPT + 98 others); Sat, 16 Oct 2021 11:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234575AbhJPPhL (ORCPT ); Sat, 16 Oct 2021 11:37:11 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0134AC061570 for ; Sat, 16 Oct 2021 08:35:03 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id e12so31891786wra.4 for ; Sat, 16 Oct 2021 08:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bEDEZvAmdvWI96ksUh1vPO5+Cce7AMzdfq8gX4cXeB0=; b=Hq6Ke+cYGQ7Vn7UrIUFvSLrrJjdTMhBoKwCHr+SWMz6DJQBFc0cpN8ulCOPAz98+Uw GCOJWmV7FD5Nk8UoWaBlITRZcLkn8Wdr9uOjhTS0235QeSm1i5O0OJ5p6EjMq6/Exfxw +z8Dl54DQZP0a7InF/FnOYFR/OXI6gFVnKQOLReGOwkzaBy/x6HhVE5uSw1JdHJb7gHi OXlQFEgfc1Lt0Gp2F4YblO8+PyfW2j88sQxKtIebocpxnrecREl/7cP4RR366mFtU1YF bgNis9w9NJljDB6X8sIe4Ht5eib17GmbnKDIu0YJZEjRDmMdMpLZygu+kaLHP7EWibuv nuJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bEDEZvAmdvWI96ksUh1vPO5+Cce7AMzdfq8gX4cXeB0=; b=rvYmCUXSkXNJASFfpIYdzJk9xzojOULcG+N1SL4gNxgipqNMuw6r9idlh785wjuobZ aOU5UQ4ngjuZ1HA8m2yyW3j+haL5DhIci+LM6edHnrtH1WwE9Cokd8V5wHcMHSLd7sJb 71c9TrFQVpGWg0ZACjCf4pUigcihvT3WCerS2Hgy0Sc0TQawt0vu8dq7PUzeo9zdhCs3 2JzMyGySwbaZMDAczuzZjZ7Qm0dTL94UwzRD+PeMLQG3orhhbJj9opPuF3emGw4H85Eo +MwTnZ49S6IaCurFxea+qZ98Di9lK4VIPxfn598yBlEYmxg3x1s+Q8M1AHMOrIXsh1dy DOgw== X-Gm-Message-State: AOAM5323ZR1rB+bmDJ0y+KWV+Ph3ViS1gYfWj9L/XAkNBqCMJm3Qkmyn y2N6Dw73F3bakdO79yLgIBPR2g== X-Received: by 2002:adf:e706:: with SMTP id c6mr22879136wrm.377.1634398500950; Sat, 16 Oct 2021 08:35:00 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id b19sm13813559wmb.1.2021.10.16.08.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Oct 2021 08:35:00 -0700 (PDT) Date: Sat, 16 Oct 2021 16:34:58 +0100 From: Phillip Potter To: Martin Kaiser Cc: Larry Finger , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 0/8] staging: r8188eu: another round of removals Message-ID: References: <20211016113008.27549-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211016113008.27549-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 16, 2021 at 01:30:00PM +0200, Martin Kaiser wrote: > Remove some more dead code and unused definitions. > > Martin Kaiser (8): > staging: r8188eu: remove empty trigger gpio code > staging: r8188eu: interface type is always usb > staging: r8188eu: remove two checks that are always false > staging: r8188eu: remove unused function prototypes > staging: r8188eu: PHY_SetRFPathSwitch_8188E is not used > staging: r8188eu: clean up Hal8188EPhyCfg.h > staging: r8188eu: remove procfs functions > staging: r8188eu: CurrentWirelessMode is not used > > drivers/staging/r8188eu/Makefile | 1 - > drivers/staging/r8188eu/core/rtw_debug.c | 886 ------------------ > .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 14 +- > .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 3 +- > .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 8 +- > drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 38 - > drivers/staging/r8188eu/hal/odm.c | 3 - > drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 - > drivers/staging/r8188eu/hal/usb_halinit.c | 8 - > .../staging/r8188eu/include/Hal8188EPhyCfg.h | 78 -- > drivers/staging/r8188eu/include/hal_intf.h | 1 - > drivers/staging/r8188eu/include/odm.h | 11 +- > .../staging/r8188eu/include/rtl8188e_hal.h | 1 - > drivers/staging/r8188eu/include/rtw_debug.h | 148 --- > 14 files changed, 6 insertions(+), 1196 deletions(-) > delete mode 100644 drivers/staging/r8188eu/core/rtw_debug.c > > -- > 2.20.1 > Dear Martin, Looks good from what I can see, many thanks. Built and tested on my USB-N10 Nano. For whole series: Acked-by: Phillip Potter Regards, Phil