Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ieee802154: Remove redundant 'flush_workqueue()' calls
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        h.morris@cascoda.com, alex.aring@gmail.com, davem@davemloft.net,
        kuba@kernel.org
Cc:     linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <fedb57c4f6d4373e0d6888d13ad2de3a1d315d81.1634235880.git.christophe.jaillet@wanadoo.fr>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
Message-ID: <0a080522-a30b-8b78-86d2-66c1c1a5f604@datenfreihafen.org>
Date:   Sat, 16 Oct 2021 22:54:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <fedb57c4f6d4373e0d6888d13ad2de3a1d315d81.1634235880.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Dave, Jakub.

I have nothing else in my ieee802154 tree for net right now so it would 
be great if you could take it directly. If that poses a problem, let me 
know and I will get it in through my tree.

On 14.10.21 20:26, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/net/ieee802154/ca8210.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 3a2824f24caa..ece6ff6049f6 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
>    */
>   static void ca8210_dev_com_clear(struct ca8210_priv *priv)
>   {
> -	flush_workqueue(priv->mlme_workqueue);
>   	destroy_workqueue(priv->mlme_workqueue);
> -	flush_workqueue(priv->irq_workqueue);
>   	destroy_workqueue(priv->irq_workqueue);
>   }
>   
> 

Thanks Christophe for spotting and fixing this.

Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>

regards
Stefan Schmidt