Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <5d683882-257d-87b2-20aa-0871e2902090@amd.com> <20211009033240.21543-1-nakato@nakato.io>
In-Reply-To: <20211009033240.21543-1-nakato@nakato.io>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sat, 16 Oct 2021 23:57:41 +0200
Message-ID: <CACRpkdYgqmNZEGWmjzeFtfiH-hJb6eJRuz7hnxw1GeRUuyTnRA@mail.gmail.com>
Subject: Re: [PATCH v2] pinctrl: amd: disable and mask interrupts on probe
To:     Sachi King <nakato@nakato.io>
Cc:     bnatikar@amd.com, Mario Limonciello <mario.limonciello@amd.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 9, 2021 at 5:33 AM Sachi King <nakato@nakato.io> wrote:

> Some systems such as the Microsoft Surface Laptop 4 leave interrupts
> enabled and configured for use in sleep states on boot, which cause
> unexpected behaviour such as spurious wakes and failed resumes in
> s2idle states.
>
> As interrupts should not be enabled until they are claimed and
> explicitly enabled, disabling any interrupts mistakenly left enabled by
> firmware should be safe.
>
> Signed-off-by: Sachi King <nakato@nakato.io>

This v2 version applied for fixes.

Yours,
Linus Walleij