Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 17 Oct 2021 12:56:33 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Cai Huoqing <caihuoqing@baidu.com>,
        Kevin Tsai <ktsai@capellamicro.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio <linux-iio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] iio: light: cm3605: Make use of the helper
 function dev_err_probe()
Message-ID: <20211017125633.0832bcd4@jic23-huawei>
In-Reply-To: <CACRpkdY0uM4BNapd7XNUhZ5U0sGdP3hu5Tr+dM1jigg5vQ+KDw@mail.gmail.com>
References: <20211008092656.421-1-caihuoqing@baidu.com>
        <CACRpkdY0uM4BNapd7XNUhZ5U0sGdP3hu5Tr+dM1jigg5vQ+KDw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 13 Oct 2021 01:45:47 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Fri, Oct 8, 2021 at 11:27 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> 
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > ---
> > v2->v3:
> >         *Handle platform_get_irq() that returns -EPROBE_DEFER.
> >         *Handle the lack of availability of an IIO channel
> >          by converting an -ENODEV to an -EPROBE_DEFER.  
> 
> This looks good to me!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij

Patches 1 and 3 applied (2 and 4 were applied at v2).

Thanks,

Jonathan