Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 17 Oct 2021 12:40:48 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Ziyang Xuan <william.xuanziyang@huawei.com>
Cc:     robin@protonic.nl, linux@rempel-privat.de, socketcan@hartkopp.net,
        davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] can: j1939: fix errant alert in j1939_tp_rxtimer
Message-ID: <20211017104048.lkodbwh3f5iqqgcq@pengutronix.de>
References: <20210906094219.95924-1-william.xuanziyang@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tbw24fem2sqsw5rh"
Content-Disposition: inline
In-Reply-To: <20210906094219.95924-1-william.xuanziyang@huawei.com>
Precedence: bulk


--tbw24fem2sqsw5rh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 06.09.2021 17:42:19, Ziyang Xuan wrote:
> When the session state is J1939_SESSION_DONE, j1939_tp_rxtimer() will
> give an alert "rx timeout, send abort", but do nothing actually.
> Move the alert into session active judgment condition, it is more
> reasonable.
>=20
> One of the scenarioes is that j1939_tp_rxtimer() execute followed by
             scenarios

Typo fixed while applying.

> j1939_xtp_rx_abort_one(). After j1939_xtp_rx_abort_one(), the session
> state is J1939_SESSION_DONE, then j1939_tp_rxtimer() give an alert.
>=20
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>

Added to linux-can/testing, added stable on Cc.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--tbw24fem2sqsw5rh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFr/a4ACgkQqclaivrt
76mBJwf9G6w7bBDtIoaURGYok6UdZsn3FikNLn2EpTiYbO4c0rQb0oEdrHLm2vaS
hD/889Mcn0GYgStPgbAeF756pQbwtndVQUU2iIzpEXKbhX3914wdQ8TOzZbRiWbY
jQ+zmBZibV06rlfN2r4n6iWQrBX2UCuHU0B5NBTWIQQvm/LfRHQVmZSmgRGQrE5H
Pb/B/GkeWXOMYfMihcCdV3krfmNscLjXG2te+yOmNVIQXC9p9/zVwjLIAht1HpsE
FLc1eWPpeMOlLPlyor0Wyx+DZBug2zPQ5laUMQPeza6U6YFA80xYssQpC2nIGyma
xflHutzNaKoTeMsM0NHnplP/jXpygg==
=FaKl
-----END PGP SIGNATURE-----

--tbw24fem2sqsw5rh--