Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2620353pxb; Sun, 17 Oct 2021 20:44:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoLEdmkiy5iA9jplicuYHLwELivQQ3u0RbFKUZb0qd8oeKkfHMIWuUV26dEFNGaXFBe7NC X-Received: by 2002:a17:90a:d24d:: with SMTP id o13mr45161899pjw.59.1634528639725; Sun, 17 Oct 2021 20:43:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634528639; cv=none; d=google.com; s=arc-20160816; b=IcM0FLj3JgUW9sSK1H6xZlV9oLUpqMhER79dpmSCbqEcrZ5Wc8KlDwmFoSdQ+9DAGI p/kdWOaIq2zDYsWqKxlBemFg5OrkflC0VSowfpn0kT0xSpq6sPSeuv2NZrCRRsTcTGnx lbPRbVaKO7mDFeG+NKSA5Da/hLrD9S127J4CKGKdOGtATrWTIcu7fb0ygJSNadSYLItD NTZAW5u4wKY0uK2TzIiblLN0dTG3G6pBUuOaJ+vZLDAdYXKUyC6ULggxJK2lSEJR6hxh 9rpjiaU69/3/fJnpkVum2MMbPAdCoSGJKwlmirVFGSLcmC0NgSJITVaP9xmiVOknAC4g ihcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8EAAneiZ+XWvr9pFSYjOJgwCqHEBK+LzIxMPFCiALgw=; b=NFXVSpXfLcRZHWa+Nc9kHwC+nmBCau5MYihQLVi+FwIrGPo/m/dI5o3VRyQkFFEy2S pzkPeAzHCbXRuRGi6gAhPe7GT5NjIE7CB8LfUdslhPdr5gT+iST3XZF4249Dcq2Hh44t 1lG6t34Eez3XESfRiLPaYME6vbY8DgulEpJwlgL27QpJ6IqjDUsxS+gb2kW5oNj1hfZ1 OjCS5jL2GZTVy0Dg1r0fUJCL8pz2a9chYBwm/kvGDHuKoQ6+EHZJcSt+I6F3L0ne+Kut jxeBAP2kdRYTNu1UnFTJflfFqIUVvd42wmo/QOx+YXJV3NebDqpFLft9px5a+9uz8Lvb mELA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si25261749pjr.83.2021.10.17.20.43.47; Sun, 17 Oct 2021 20:43:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237769AbhJQKnJ (ORCPT + 98 others); Sun, 17 Oct 2021 06:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235987AbhJQKnH (ORCPT ); Sun, 17 Oct 2021 06:43:07 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F812C061767 for ; Sun, 17 Oct 2021 03:40:58 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mc3b1-0001xb-0R; Sun, 17 Oct 2021 12:40:51 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-11af-1534-a8a1-94ea.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:11af:1534:a8a1:94ea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 045946958B1; Sun, 17 Oct 2021 10:40:49 +0000 (UTC) Date: Sun, 17 Oct 2021 12:40:48 +0200 From: Marc Kleine-Budde To: Ziyang Xuan Cc: robin@protonic.nl, linux@rempel-privat.de, socketcan@hartkopp.net, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] can: j1939: fix errant alert in j1939_tp_rxtimer Message-ID: <20211017104048.lkodbwh3f5iqqgcq@pengutronix.de> References: <20210906094219.95924-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tbw24fem2sqsw5rh" Content-Disposition: inline In-Reply-To: <20210906094219.95924-1-william.xuanziyang@huawei.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tbw24fem2sqsw5rh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06.09.2021 17:42:19, Ziyang Xuan wrote: > When the session state is J1939_SESSION_DONE, j1939_tp_rxtimer() will > give an alert "rx timeout, send abort", but do nothing actually. > Move the alert into session active judgment condition, it is more > reasonable. >=20 > One of the scenarioes is that j1939_tp_rxtimer() execute followed by scenarios Typo fixed while applying. > j1939_xtp_rx_abort_one(). After j1939_xtp_rx_abort_one(), the session > state is J1939_SESSION_DONE, then j1939_tp_rxtimer() give an alert. >=20 > Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") > Signed-off-by: Ziyang Xuan Added to linux-can/testing, added stable on Cc. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --tbw24fem2sqsw5rh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFr/a4ACgkQqclaivrt 76mBJwf9G6w7bBDtIoaURGYok6UdZsn3FikNLn2EpTiYbO4c0rQb0oEdrHLm2vaS hD/889Mcn0GYgStPgbAeF756pQbwtndVQUU2iIzpEXKbhX3914wdQ8TOzZbRiWbY jQ+zmBZibV06rlfN2r4n6iWQrBX2UCuHU0B5NBTWIQQvm/LfRHQVmZSmgRGQrE5H Pb/B/GkeWXOMYfMihcCdV3krfmNscLjXG2te+yOmNVIQXC9p9/zVwjLIAht1HpsE FLc1eWPpeMOlLPlyor0Wyx+DZBug2zPQ5laUMQPeza6U6YFA80xYssQpC2nIGyma xflHutzNaKoTeMsM0NHnplP/jXpygg== =FaKl -----END PGP SIGNATURE----- --tbw24fem2sqsw5rh--