Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2621178pxb; Sun, 17 Oct 2021 20:45:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTvO7v/Z7oeHJLDvjy1lMr98G4KiAzd94di7m1bJrsBf46OsU/fRaFsV/Flt4ZEL8uWqAv X-Received: by 2002:a05:6a00:1ad0:b0:44d:bd1:f392 with SMTP id f16-20020a056a001ad000b0044d0bd1f392mr26398869pfv.69.1634528716152; Sun, 17 Oct 2021 20:45:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634528716; cv=none; d=google.com; s=arc-20160816; b=TIMWbnpnhKbHVPBwioyrRYlV+DTty+4Rcjaz2hMG3bfCKaQwCCXcSPSoOP61gW3HxB eI0kbEr6x7ulDkP7WJfpjUVMYGrD6Pf/DfoypEsRVRpZK3/XoyuFPiSx6wRZiqq98wWP aSmGnceol2ZW3t32CJsdoNpLjNqMxpJeVRpmjaqPe13a/gKcG0ZluyAOHf80vS5nxCGH U+MKh1I+bJ3mMQ2YjqOn8e8SVEpFFkqSrj7d4iEt3QcMIiXTK+j8uCXgxleIzS3ua4cz 3VDWrL1LvK96BgMe4d620XDuufedg5wZBg5EbJt+Qp+SkkOA0sH/RZKclBTXvj82ovOP txDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HmFVb8xcAOPn3KFdgt6HcfcE/AmGQRsTzReX+3wjP4g=; b=fkD+x018PWzRVaytPwqYh+EKeFKBGL7odZDUNpKtNYOoDfKrJso6opduOsKspVAPti MUvlcsHC9lCq3ALHKAqFBPzcEMjFbyTf2H7FDT6QmFhfWSDZardyzZd/aG4kzTccEcrS Qo4d8n1ahONp3xAQUM0vtL96kQqDgATAZRM/M6xWFTaDCSvGyRJKfLYQI9nAK03kWmaU HhHa52ARln/BCxE5nC+AvZki5ozoYAGBqrdssjVopjcRYdywScNm7Ou5WSRddTFdsiDN 5H0P5lDvtvSQmSrW9cMojtchOK57HA2uIerwqxvjuFRKZJF/OOgouag4HZazfWb9G8kK +aRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=aRNuyuJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z12si4281096pfh.257.2021.10.17.20.45.00; Sun, 17 Oct 2021 20:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=aRNuyuJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343853AbhJQOZ4 (ORCPT + 98 others); Sun, 17 Oct 2021 10:25:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343858AbhJQOZz (ORCPT ); Sun, 17 Oct 2021 10:25:55 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81405C061769 for ; Sun, 17 Oct 2021 07:23:45 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id k3so1894344ilo.7 for ; Sun, 17 Oct 2021 07:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HmFVb8xcAOPn3KFdgt6HcfcE/AmGQRsTzReX+3wjP4g=; b=aRNuyuJrq/vs5oWRNzTycUP/Fg9XrqqlxawcmiY6GzOT3VVhg77DO+5g6T4a1lMBD8 V4Fy7cR0E9gqtQ/HNAOxZ0HRNDLiYxo7gLVY+3NbFJ3tEoi/SqZWW37OIh/Vm444vTuj /qWlv3JBPrWp2eEyA9wrirrZDV6wHKmzpYxpyfnUNaQoIr5HIWZBqPhRZYx9YRAE7jwW AJad8Tjj79siCZzMvK/BSS4J93j5zHKgYfIZ3Dj0D/8SJnwidwePXVe3Qsn8p7EG9bST UFaQhbXTNVCuT9ObfL/wrPjP6cxGPUZ6qRPluLWDVKya/gL4RmX7+o3tkvfe0wqDLmce 5mJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HmFVb8xcAOPn3KFdgt6HcfcE/AmGQRsTzReX+3wjP4g=; b=pVwBCyUYHZbhWCLDtb0zrTz/egIoCgL7qRGjF/2Wses4QpVqtBmc/qjTGRu1exp5dh WCD/VvbWfpVI5gN7HDbVsViG8LXO5KiY2G9Ss0PFofH+7aMEF63rOlveKSuXROAcNxB6 T9nmarCtFZgMgzu7WBjlBkDX8qDbS8iFww0yhlvUElgI/b93XizyBYyNgPdd8OF0K5hd yfbzU4yVSz2IFzNldc2vuJOAuGd6xbqk6vfxnKiW6MCkC5R6I8kJMByybJ6/VxG/d+I+ I1fzvdWcKiaNYVMeFIh2dcLJtUd6ZjCE5lhQBe0TFIFrLO8nFSnPEah43IZQvc5p7jQN Kyqw== X-Gm-Message-State: AOAM533yZN3ShEaploESk8PJzqArOyYUuHsatSEPpe3cNoVSC/h8ddze 0F0pOdsKNt9kNhSiPtDriIzisg== X-Received: by 2002:a05:6e02:1aa5:: with SMTP id l5mr10279705ilv.268.1634480624620; Sun, 17 Oct 2021 07:23:44 -0700 (PDT) Received: from localhost.localdomain ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id v4sm5693755ile.24.2021.10.17.07.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 07:23:44 -0700 (PDT) From: Jens Axboe To: Noah Goldstein Cc: Jens Axboe , linux-kernel@vger.kernel.org, asml.silence@gmail.com, io-uring@vger.kernel.org Subject: Re: [PATCH v1] fs/io_uring: Prioritise checking faster conditions first in io_write Date: Sun, 17 Oct 2021 08:23:41 -0600 Message-Id: <163448061835.101565.1242197523580881975.b4-ty@kernel.dk> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211017013229.4124279-1-goldstein.w.n@gmail.com> References: <20211017013229.4124279-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Oct 2021 20:32:29 -0500, Noah Goldstein wrote: > This commit reorders the conditions in a branch in io_write. The > reorder to check 'ret2 == -EAGAIN' first as checking > '(req->ctx->flags & IORING_SETUP_IOPOLL)' will likely be more > expensive due to 2x memory derefences. > > Applied, thanks! [1/1] fs/io_uring: Prioritise checking faster conditions first in io_write commit: 02a8286be94bb1fce86afa6b487717eb4ca2956e Best regards, -- Jens Axboe