Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2622688pxb; Sun, 17 Oct 2021 20:47:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+UZlz87w+qUswmmx2rmGrs/r/jPleJ2wDalH3cdy5FZbPmk4BuvcAZQMqnz1jAw0Z5qyV X-Received: by 2002:a17:90a:5b0d:: with SMTP id o13mr45771500pji.117.1634528849788; Sun, 17 Oct 2021 20:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634528849; cv=none; d=google.com; s=arc-20160816; b=XjOxVOuaToXwZZeLqAm2JfkAunWvI9ZN4feq+N9OoqHcZi0euLhqNUsebPYDa+fAMo UEml9XjoKRUPiUOGUJRecVcudAS9GLLYZAdo5zPQrw5DWLeY0cnGr1D0W/5+dxeKhnvT M8shvxNlbyvedYLfVaLyaMyVyf5K9q/oAlPlgV+ZY7+dgQwY9BeGA1d/EMgZxFsaCcH6 vSWmSdpXfnwzRm19oafsQtdOMirREVWQIy55zPgYSNCpA/LB6BtTLhYwKOG8IPlsvmhI 2r7/N+c6yIltr4UYXE+GNjiUFSkpu1HAZrpe+olYyvP9wob/iQkpe663n6tR/KcZdH27 sirA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AA9A+Zlva317NIfypRYc9E4tQrCZT2z4OCSN5FYuo3s=; b=aEKuRbMfOdtUwvBQLPywqgXX2etkldl8+gpeLNUyFLVtzAB/0+ooOM3StJFq4GGx/4 nit4FiGpo09MBoUkQrcSC7ElKp5veSUa0/qE4k+k/SIIheHR4Zcnk61tFE0fOVBRWi5v EFw15sbGCSiUuM9IaRc3DZ7I/DgBbXSLNzWJyBO8Xl18PCVcD3TyqgFj22nHwxLtZjQS GOyDPelZBZoqSukiJfo8HVFDX1v6M5GokfGRfjzZKuUke3OPQvOfNzIqE7xSG2aHuM6w ZiHp1nzXRCkutVC7X63bsMYQI/4K6lFRuIfj3NU1ic+SQM5elC5JIRcNq6vbWfpSyXsT kuhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=6kVA+4A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mq9si3725509pjb.75.2021.10.17.20.47.18; Sun, 17 Oct 2021 20:47:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=6kVA+4A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344258AbhJQQme (ORCPT + 98 others); Sun, 17 Oct 2021 12:42:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344265AbhJQQmc (ORCPT ); Sun, 17 Oct 2021 12:42:32 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A575C061768 for ; Sun, 17 Oct 2021 09:40:23 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id d125so13532042iof.5 for ; Sun, 17 Oct 2021 09:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AA9A+Zlva317NIfypRYc9E4tQrCZT2z4OCSN5FYuo3s=; b=6kVA+4A8fvoLxgstDg4L7HTcvrcAPOFtdQVwmBfM3Nr9X6MOyIfztfCEhyPHRMZABq psTj+/Tk3Xg27OQXqClky7pFZFYpPeO+NLITe4JXUE0TbY4t/2c0dle02eri6/yraJv8 Z+iIKvez0817fElA/iFZ1WXPhVMuOx7BYitnjfM0VNsRdDm0cefW9ZeTZ/i3y1HaafYd aSIm8HAjoK5nIbvS/adTf0tQZzx6MiXodwe8xsn8YQkRdZFuPQrLv7RIC1/QS9ouU2/w ihvHRRiI6z2R9Zi/G+9Yc5/YOgvNSLsjDUIfokXtEmeHghtvphRN2iG18/6OVOxygAd6 eGIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AA9A+Zlva317NIfypRYc9E4tQrCZT2z4OCSN5FYuo3s=; b=Mb3W1XLAOZds72tF7c3nipMDMzQJbUm556uJrLZyuCRhl/0jb9tsxAT0al5E116L2b iVnPguYfMtZc0NhKt71mphqsWF1gK3RiPWmNM3EBNSmzxbxl1dAaj0sLSuhKxdMWhk6o GHQ37aSd/0eaUaWwVEmDN/5MmJsans1hMi3RLKRNfDTDXcqYtpAuvjegQZYlFMJkVnj3 WsEZX/WzgYWTPZBpeOYSrEI9rvqUXbxIh97oLUPQgFW3wpOe6phYOEMV2g+ZTK38Qw89 0QJ3WgQO2u//7STVqNMc7TO4oa7I3UBzA0EB8Do0j6JzYiZW9agL9iXq0dznLXMAObCC IU/w== X-Gm-Message-State: AOAM530SZDKeeZbtVF040SB94grIbPIutfrgkrrqu6S3Chs3TY77294B 7RkSWUkcbU+KiSWUmP2G74lbKA== X-Received: by 2002:a02:6666:: with SMTP id l38mr14990150jaf.146.1634488822456; Sun, 17 Oct 2021 09:40:22 -0700 (PDT) Received: from localhost.localdomain ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id z26sm5576059ioe.9.2021.10.17.09.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 09:40:21 -0700 (PDT) From: Jens Axboe To: Tejun Heo Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH block-5.15] blk-cgroup: blk_cgroup_bio_start() should use irq-safe operations on blkg->iostat_cpu Date: Sun, 17 Oct 2021 10:40:18 -0600 Message-Id: <163448881598.109630.15974180935956486992.b4-ty@kernel.dk> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Oct 2021 13:20:22 -1000, Tejun Heo wrote: > c3df5fb57fe8 ("cgroup: rstat: fix A-A deadlock on 32bit around > u64_stats_sync") made u64_stats updates irq-safe to avoid A-A deadlocks. > Unfortunately, the conversion missed one in blk_cgroup_bio_start(). Fix it. > > Applied, thanks! [1/1] blk-cgroup: blk_cgroup_bio_start() should use irq-safe operations on blkg->iostat_cpu commit: 5370b0f49078203acf3c064b634a09707167a864 Best regards, -- Jens Axboe