Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 17 Oct 2021 22:44:12 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     Lokesh Vutla <lokeshvutla@ti.com>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Matt Kline <matt@bitbashing.io>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: m_can: m_can_platform: Fix iomap_read_fifo() and
 iomap_write_fifo()
Message-ID: <20211017204412.2jvp24tgaibvmcz3@pengutronix.de>
References: <20210920123344.2320-1-a-govindraju@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vyrpaejnfoakxj4h"
Content-Disposition: inline
In-Reply-To: <20210920123344.2320-1-a-govindraju@ti.com>
Precedence: bulk


--vyrpaejnfoakxj4h
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20.09.2021 18:03:43, Aswath Govindraju wrote:
> The read and writes from the fifo are from a buffer, with various fields
> and data at predefined offsets. So, they should not be done to the same
> address(or port) in case of val_count greater than 1. Therefore, fix this
> by using iowrite32/ioread32 instead of ioread32_rep/iowrite32_rep.
>=20
> Also, the write into fifo must be performed with an offset from the messa=
ge
> ram base address. Therefore, fix the base address to mram_base.
>=20
> Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>

Applied to linux-can/testing.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--vyrpaejnfoakxj4h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFsixkACgkQqclaivrt
76nANAf8CPQsL+cF95xUlCMoxS4E7BgIb7HAWVRKEdE0wYn5DOWOhHSQ/Ct2OzNy
PwglN9CFRcSlMR4N2vmtpuu76UZ2ifmm2oiGHGCXQ6tgwUIFAIEWjm4dA91FdTQV
Gj/hWgb5HOJa3vC+Yre01EhElbGDOCwNRJo/eFKTRIF5DO9UaBiC7ut+S4zPsL/i
+BkMkvAg5v2ePo2gvJSqZinSshcWWTyX3oxDoB6cuXZq0MDedy5Lv4WfGWRqh5kO
UbvlS2/UXAjHagMQaBzPz/4wxMz7Dqu0n9k3X6Dz1ZnbfV2A4kthJ+tAGVmRkiVz
nkxcH8wyiizCaPTGO5qtfkKibial/w==
=7CHm
-----END PGP SIGNATURE-----

--vyrpaejnfoakxj4h--