Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] net: mscc: ocelot: Add of_node_put() before goto
Date:   Sun, 17 Oct 2021 21:32:32 -0400
Message-Id: <20211018013232.3732-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lb/qAuxoYPK/vzuCaXfZcyEkx4xtj36YttbRAyc1Y2QKs71/qONm2lICw62K?=
 =?us-ascii?Q?GWUNyBuhMHqYiW2QDH0DdG2xAqohSGe1uN2BNV1kzpdaWsA6GugBl45+lfGY?=
 =?us-ascii?Q?Hj5nkuyjm/QGqmq3hWZqK+FeM/++oNnzpVlRZ9WnEkxglYUiJgAnmDF2z9iU?=
 =?us-ascii?Q?/9S7wiLNtrMj+RJVhqfzi8LBEMqygENNIAD8m2Ro4BM6ri2G+M89+6uTPLGK?=
 =?us-ascii?Q?swodyiWs4OHrCw6KEr4vkmkCJ14Bkf9FT4fJRpBcqY+txslPifXKELhZDExd?=
 =?us-ascii?Q?0YjDCH19HOpicrNhU+E/h2Ngim9J7grVew2rTkqLuET7dxWQlCk9bDW0E6Cv?=
 =?us-ascii?Q?K+pAgv5bjOpq5GN3Va0DF0qgK/2CDY+J6Ndn+pEnmasvnbaarn9N5KhFaJ1y?=
 =?us-ascii?Q?Tbkil0+GVhAD4QptskbwsISLmFxEp4597EhVT4HM5gCqZb3RI6AhNvvMfyXT?=
 =?us-ascii?Q?4czATD9sCcslwPunqhhTKzpCml/7yoFYXzXojgztD+OFsG9/9XYYu78BBVcE?=
 =?us-ascii?Q?I8AZ1nWdkdKL364gluR5x7SpcimNbvu8QP7pk4k0zZneNatyISxFu2OyMrqy?=
 =?us-ascii?Q?2M3uHTyOBMvAs9blmlTpr+u9NqIpytfQ8K4fKUxgAt8J8xRl87A6eO3p4s8J?=
 =?us-ascii?Q?Dc2kk+51LiFP95RZ4XKlF0MKpDasXQdpGVFiKot+CELtHKzSG/U7/bFGYVB2?=
 =?us-ascii?Q?m0fwM7INt+FJVO+WZbNOFnCHEseLcssKVsB8H01+04gAuZkTSkNNhLz9Gewz?=
 =?us-ascii?Q?s8nGpE+6ae1kcM0FCnvPOlGvVe+ETaphirJGGVOJfFQN7ARSnfQedtRYhnqi?=
 =?us-ascii?Q?pYfxR79P9+Y9XV5B3hdnLldpbwq7BsS8bqsrVcdyUpdT131o6Hs+Nywkk2lR?=
 =?us-ascii?Q?Ltqi7egLSNlnRF574a2CwLsx2tLT6i+2jcWUd8n5ayjYkx32EtBSFOy0cj1f?=
 =?us-ascii?Q?iqn9rKWMVB8HT5yzs6JfGVCnTSei0E84HSmu9mpZWQakSVjzZ024cgHTaKZ5?=
 =?us-ascii?Q?ABithng54BERqCEzJ9LsuXxmDuVylFnAb5hp9ahY5ieg+zJGgY/+F8d0V1gL?=
 =?us-ascii?Q?0arvyI9ZWsTZex8bUU9+H/JeCln0dWC4Cck5tMeF4w65KMypkBiqvbWQ8GdW?=
 =?us-ascii?Q?PHNuZvMh4FrvIJEqlLPz0FgvlIaZeuU4QYkG9b6PeYw4szKIn5O4ntSn9mh1?=
 =?us-ascii?Q?kK55UdsrtwnevDHt6i3kS50kfU2hSfOMzMiKqK17AoRJOMNSHOD8g1V7WBsY?=
 =?us-ascii?Q?/MEHq02k/gLv3Ga4RTSeletypF69F/49N/s/2+gt2eAojGiVtNQ9q69qmYDK?=
 =?us-ascii?Q?2ALw/cC25cJi+YVj2j26I9Hq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07d083a1-5357-49a4-6829-08d991d72ff0
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 01:32:46.0225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /lLXTaAJz6ZHHWP75MGnBhGGiq/bWojQFXplOUs2cUJ7RUP1ullf7cpiA+m5/YFxZmE/sq6kxO//ke2ymP5zww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2523
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/net/ethernet/mscc/ocelot_vsc7514.c:946:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/ethernet/mscc/ocelot_vsc7514.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
index 5d01993f6be0..38103b0255b0 100644
--- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c
+++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
@@ -969,6 +969,7 @@ static int mscc_ocelot_init_ports(struct platform_device *pdev,
 		target = ocelot_regmap_init(ocelot, res);
 		if (IS_ERR(target)) {
 			err = PTR_ERR(target);
+			of_node_put(portnp);
 			goto out_teardown;
 		}
 
-- 
2.20.1