Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     <tom.zanussi@linux.intel.com>, Steven Rostedt <rostedt@goodmis.org>
CC:     linux-kernel <linux-kernel@vger.kernel.org>
From:   Yang Jihong <yangjihong1@huawei.com>
Subject: [QUESTION] Performance deterioration caused by commit
 85f726a35e504418
Message-ID: <992d3b1c-70db-5cc7-8400-39caa5d502d5@huawei.com>
Date:   Mon, 18 Oct 2021 11:23:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Tom and Steven,

commit 85f726a35e504418 use strncpy instead of memcpy when copying comm,
on ARM64 machine, this commit causes performance degradation.

I test the number of instructions executed by invoking the 
trace_sched_switch function once on an arm64 machine:
1. Use memcpy, the number of instructions executed is 850.
2. Use strncpy, the number of instructions executed 1100.
That is, use strncpy is almost 250 more instructions than memcpy.

Has the impact on performance been considered in this commit? :)
What is the impact of revert the patch?

Kind regards,
Jihong