Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] ARM: shmobile: Add missing of_node_put()
Date:   Sun, 17 Oct 2021 21:45:03 -0400
Message-Id: <20211018014503.7598-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tYAJQZ6D2QJnOJFbFXSmcMjbGRQ5XcKEoGX8MAl14wKjmEH8kU94ZEhloy8g?=
 =?us-ascii?Q?Fv1yxjBorUtIUpgQMH5TGpFE3tRFUFbFi5RKWUMiQLipO7uUxuvV0DFa0oB0?=
 =?us-ascii?Q?mqgd9aVylyJT1CrXN7cSwLBdgB3IxY/I3mm4UgRHjP/WY4kcVm/s8NxXLlCe?=
 =?us-ascii?Q?srz5oCL9nu5J+uE2J/zXf3I9bRKR8mLcraQRor6c+q7ELenpiYny9WkJLrw4?=
 =?us-ascii?Q?4LIlHA/Q3wxPWoJfikH0E+kT6LlIsxV2InLA5wUfeSDOK893jTb8EfExKIjj?=
 =?us-ascii?Q?2lsZYYGUs7xyluQuACwMeUM3p+N4NgQLV9i0Cu1OboHLzQgyuBSSyLj1IvY+?=
 =?us-ascii?Q?YOWGcNUVTE7yypTPvEOA4oiLgNsvRhuqKCch+zgbPMMx5noQbsh3HU8inRjB?=
 =?us-ascii?Q?lo3Nko5l6VVWXWCSJw+QNbLHgeovwyU0WoMwHoYZDyupb8+TwhjHdTBWQhz1?=
 =?us-ascii?Q?VUkwWB2FMgCDHbcEjGtrDlUap8wCCP+j5Tt/3WsJvZ6mT6+n8t5/CN6dmyH+?=
 =?us-ascii?Q?HbAJGnz3Aic3Jl/wX5DylkCHAM8tR+c6YagzWBnsiiADI2bm33iKpPFhuRIf?=
 =?us-ascii?Q?/vlrNqGlnVzlZ6FSWIEQ72nXtUcJx8U8Q9EkhjuzuzqaWHSknHFygSW3AZSn?=
 =?us-ascii?Q?bXLmWk9RZirpV7xOIjHM2/ZqLNLFXR4hRPa2BXbXWVlnUuqtz7l56qmc2AMe?=
 =?us-ascii?Q?1TlbKwcM7U9V1UoMRTlNZTPKGIFyrBeF9hyDCLLmSjmrPVThn+TbGA44pSMG?=
 =?us-ascii?Q?TMG6mYC9ZdRecdpRYz8JbDl1kIdyVPQFqSX6UGjs+x/mzFHKlNUo6nbjKr1J?=
 =?us-ascii?Q?enEsZcfFTnq177kcWqj9WYzGmpS6oZJD2xvEQ2lXL39hkVLvV4pZt1HaGv+1?=
 =?us-ascii?Q?8hxN0EnQiHB9BiPihOIBy/Yg4LrVHg4JUbLUs8XB1HkGT16dLrTZUHiF+2tT?=
 =?us-ascii?Q?UjYqcVhgBqi9bNBD5ntivB7X215kXoap84QUbnd9feTy1YnN6X5X0SNo5v9P?=
 =?us-ascii?Q?zVsgF2HAk4oTkNo5Q4piabjRRV8vi2wGxyve4rnAU+Xjmaa+nCylQOkYswT6?=
 =?us-ascii?Q?roiNWEK5XlmyFAF6qzjQAe1EVodJXtYLG/SMroJ/oSOQyLcZnndShkbabY4n?=
 =?us-ascii?Q?usCJR5ZUuFNRvNIAGtgmWnVer3bLQADkihoG6DzlW8iyqChoE1FJ2nX0hfns?=
 =?us-ascii?Q?0IQunpaIWVBZy5B9kIGJdFZ+LsH7CklHjcM9p4SGowY7xDfDAxL2to++Ebdk?=
 =?us-ascii?Q?LcZHuBvPQk9v9wqgChiDhdQyc89AhpVgnn//GwzfqLH6TdZ+x/NOT2HDCR9y?=
 =?us-ascii?Q?7JhX57TjjHj4/6BUMPKqm8u4?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9b87cb1-2a7c-45d4-e5f7-08d991d8f2b7
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 01:45:22.2946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uuYiAt/OYUWNuAe9XSc/mH8x1314E/8Sh+hjmEcnv+nZkMNQSQc4y35xCMWZjcMi2RkM+lborz0fqIT9C1do4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3822
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c:156:1-33: Function
for_each_matching_node_and_match should have of_node_put() before break
and goto.

Early exits from for_each_matching_node_and_match should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
index ee949255ced3..09ef73b99dd8 100644
--- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
@@ -154,8 +154,10 @@ static int __init rcar_gen2_regulator_quirk(void)
 		return -ENODEV;
 
 	for_each_matching_node_and_match(np, rcar_gen2_quirk_match, &id) {
-		if (!of_device_is_available(np))
+		if (!of_device_is_available(np)) {
+			of_node_put(np);
 			break;
+		}
 
 		ret = of_property_read_u32(np, "reg", &addr);
 		if (ret)	/* Skip invalid entry and continue */
@@ -164,6 +166,7 @@ static int __init rcar_gen2_regulator_quirk(void)
 		quirk = kzalloc(sizeof(*quirk), GFP_KERNEL);
 		if (!quirk) {
 			ret = -ENOMEM;
+			of_node_put(np);
 			goto err_mem;
 		}
 
-- 
2.20.1