Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2646715pxb; Sun, 17 Oct 2021 21:31:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywtBlth/sT2zwaqj1Z7ceDyH//qgEUVCdR5XeL5VxgU4CS62f/bNErhFmICq6TdIkNFFPT X-Received: by 2002:a17:906:fad4:: with SMTP id lu20mr26625776ejb.316.1634531513380; Sun, 17 Oct 2021 21:31:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634531513; cv=none; d=google.com; s=arc-20160816; b=vFbXm/ihBpxZpx0UL/oCQnuO2HbItvvqsk92g0X0YNWC5AL5p7GzNrDzIjwMTFBSj0 yOOCRStaFdIIDrBInYuBYm4ATPFvPnSdSGU4NAnxuohYP5llSJqrHFIxdGb6Glk7KM20 CLA4uJ9WkABhwMCt9LAGuTmBDPxMNjATuU4qlTRKOOgC+oYY/AZ54BgJQ2Viq66AEnaR B5P/FisgRlVwZiR2FoXQFScr+04lLUbij/j+mMf2xRVAGtPYmQbYLCZmNb9M/M6cYRXp 3HM/PeQnLYHK8nPcC1iNxm/u5l+wnnaUB1HDIxjnuHwJ/gzEEQQ0FLPPdLEcZeQwtX2G k+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5OmSX37aPOYdHq5/1xSnFUk27qfLl3FqOZ0geLmt12E=; b=amVOafmSrrK/HVvAy1yR1Rx187K8hrbbCYUpfEmRjJaO/6PvbKaXMTbk/1w/32ldRS yVJvCUA1GHQDUgdwj6LMLcSpMuqosfBN+Cltx0Q8/oH+hFcjN4SUvA1iIRSZySxoJZUp d7/SKtlyLWncgbCs155ZF7jdpKiO3UGLs83lrliQsIT2FflTr59ISfCiJtC8gJ33sr3a Qogi2eN16c1Qq1ouUXuovugGakb54Fljz0R7QJup1q/O24SCnmW+xsFISedAktw/3ZOW 7WHdhR2mC+SzYCeXFH5uDNM+KbNiTa+6NVfd1Ld5S+kNXc7iFgHzfSOdDEqP7mhhKn+N 3njQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GNiq8RJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t28si18283577edc.476.2021.10.17.21.31.30; Sun, 17 Oct 2021 21:31:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GNiq8RJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229737AbhJREKa (ORCPT + 99 others); Mon, 18 Oct 2021 00:10:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:40486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhJREK1 (ORCPT ); Mon, 18 Oct 2021 00:10:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDC7F61054; Mon, 18 Oct 2021 04:08:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634530096; bh=rSBoFOHyf4uqvRd9N6DL3e/GslL/J03tC/7EHWaZi3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNiq8RJFaXXbFz8y3UGY65yPyeavMA5V5D6q6NO0OlvtDz+pAZi0ZZx0hQR5v+NMG ODHw5JHoUqoL4Hu6vpC4ksx6ML1/YTwDT3/Znc6DktuI4f+h5/3bfclf21kgALKv0R lttRimYPr6ikF8CM0i1irSUDtZoxGQggzb3QwTPsOozMxlkkHi3NHItGsuiJEPgy8p tiPPTpDzwfz8rripUu2d4todpZIXSxkLpojZ6F5yxThIRv06O20CR1UqJ6BB/s2tck wnPNaJuKdnIqELqQUhMoap6oQc+mzOjItyINEVnJCMxszKhYuA8BTcUxbz1SJMM0ud DRos4LOInoqnA== Date: Mon, 18 Oct 2021 09:38:12 +0530 From: Vinod Koul To: Colin King Cc: dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: Remove redundant initialization of variable err Message-ID: References: <20211015123447.27560-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015123447.27560-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-10-21, 13:34, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read, it > is being updated later on. The assignment is redundant and can be removed > and move the declaration into the local scope. Applied, thanks -- ~Vinod