Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2810501pxb; Mon, 18 Oct 2021 02:17:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzbbfRIkyqfsiLsfJ3g1kVFBDhpsiD+ZJpAYEOF4ZzDyQliP163pUKlpnCFd10L+p5gOh8 X-Received: by 2002:a50:d085:: with SMTP id v5mr42305140edd.75.1634548670925; Mon, 18 Oct 2021 02:17:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634548670; cv=none; d=google.com; s=arc-20160816; b=xcQ7GiViZ/rNmm6hdr/sHQCYoVzr+F9swnpt/PSTlrdwgZXfqWlhAHxE2DS/PCh2kV 0wYNYgXik14rxkbh5eSLhEj3PB0FJDenRmTwhRGItt1Da5JkOisuzgbMdf3zMFLmRnqI 1wpbvlmY7kSUsYyfkwJDv2F+TAXtUYahQFkW7O7dyM9kEzfBhGx8KZUUq8SbBvzf4HTg Y2MSUmWJapYSD0Dy2586w/qObWinbuPWIQInibnn8pRsOWnd4xDGordAkalLt8YuDDLt 5Y1LLkpTIvJ8Y9A3nJqCnlK/+VsYqa8rp35RnBlXptziU8D7C5mjhAVcB+68p1s/6EKS Eccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=j+V410fkJMukMQCq6bcgPZ6KObYPH2KYog20sn6jjPY=; b=tc0JnepE4T/C9J1Ip8qM23cKkz16D8KFHjcydat9TI+yhTus71lKG5UIYhd2WBGAKi RBwgVA+HePl2WtrBV5RTVZRaJ3W5UBT3nwAvQVsF3BXemS1b1Tto1lgTMdUYNRJlyMYo u+YqllHdSQLD7VR7UK8OLYa85o1a/kGuPtbEQCzuGxMEJNcAF1HSisn5M4pHqLU+2Vem 0wVZ2kKH8ZOoLXH3HTl4meJjYLrKBpXnu/IODHkTqMXyhBcnOEyuHAlUzNu4w+fnm19W TFxQcpQFTe9r2hCksO4NrujE/hNcdsNu9sRN0pyXzWoqHt2d8jQWsFxIQENOtmtOswix RPeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si11419993eju.460.2021.10.18.02.17.27; Mon, 18 Oct 2021 02:17:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhJRJOp (ORCPT + 99 others); Mon, 18 Oct 2021 05:14:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbhJRJOd (ORCPT ); Mon, 18 Oct 2021 05:14:33 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0725C06176D for ; Mon, 18 Oct 2021 02:12:21 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcOgj-00085b-6z; Mon, 18 Oct 2021 11:12:09 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-c2ef-28ab-e0cd-e8fd.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:c2ef:28ab:e0cd:e8fd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 6464869648E; Mon, 18 Oct 2021 09:12:07 +0000 (UTC) Date: Mon, 18 Oct 2021 11:12:06 +0200 From: Marc Kleine-Budde To: Dongliang Mu Cc: Appana Durga Kedareswara rao , Naga Sureshkumar Relli , Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , Michal Simek , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: xilinx_can: remove redundent netif_napi_del from xcan_remove Message-ID: <20211018091206.cflpumnfm3mt7aiy@pengutronix.de> References: <20211017125022.3100329-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y7pxvzm5vjcfieof" Content-Disposition: inline In-Reply-To: <20211017125022.3100329-1-mudongliangabcd@gmail.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y7pxvzm5vjcfieof Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17.10.2021 20:50:21, Dongliang Mu wrote: > Since netif_napi_del is already done in the free_candev, so we remove > this redundent netif_napi_del invocation. In addition, this patch can ^^^^^^^^^ redundant, fixed (also in subject) =20 > match the operations in the xcan_probe and xcan_remove functions. >=20 > Signed-off-by: Dongliang Mu Applied to linux-can-next/testing regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --y7pxvzm5vjcfieof Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFtOmQACgkQqclaivrt 76ksUggAm2ZWnU3CCSGRvLcFjJzgxAiS4yxJpOl6RxPGRWXuWM1cbV1Z9mLGHYjy 12Cd6AbHOPY604fxUZtqbTS/7gSoH8YxQvGACfipc6kWxPvAJ/tLrNNOm6iwjUWT GZAdS9cmOPlWYjwgLwMoXqQ2Ql9F0p8kqafgyuFnfiexs1i7/XzNJRA3X+DXskAH IEixjxp1yH80/rEvnW0n7c2ZowtVSTS6VP5k3+E8NbfKEVUGUkHlD3ZbqW3+9NdM 46Hq8fpyG2bUynANiVG4fIEqLaiUUXiELYXjq28QIk+64V1QNfQc+onnO6TKY/Sm 516tLD/oKmZ6lMui6zHnmnrhdbkI/w== =oZ/W -----END PGP SIGNATURE----- --y7pxvzm5vjcfieof--