Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2810956pxb; Mon, 18 Oct 2021 02:18:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPaud3PBwPL6enuVXFEa79r/8ayl0UOEGe6DAlxmNHCltOT2n4LUUVt+IeYqEnZtkt7YwP X-Received: by 2002:a17:906:fc0a:: with SMTP id ov10mr24173830ejb.536.1634548711613; Mon, 18 Oct 2021 02:18:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634548711; cv=none; d=google.com; s=arc-20160816; b=abcQLBkbbbnSJDLNY9G4H3BPHv5QbctRd6nLdjPKZ7jrCHhWTwyKCEOp/wJoKSM9Gi +aWtjMcG3G13iRFhde0GZN5bOjrtEZaPhNo+jup/Nhrq+FYc3cJahLAQOZGvbzzIt+hs BnLHEBHn9+mwhyL+vpl0NaszKB/8l+YBu006xagKqPLOcfVGbab6Ekho1FJHEBsaKpRQ 909539/m0R2Vm3ScQYdZ4cY5xf33LNx50ktStKoluwPJe+eituOFkeJFRgEJljkyoHjA 6fxJyzWPe7tPutfNxLP2ExiZf9kApUaN1lDiI+imdCApnRS9RVFCdsN0SvndK9TY9Cls 6Hwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uYiwoLjIpwXhjE4+/22a2xkYUdGgH07KcD2ULSn0KKM=; b=HB42KXcG7QnAXQLRMH1EWQ9HTVf4CgC9O3P+Bz9CR7xBG2N05D70RRftDDsHd4Cj9b JH7UklvpMsjPzbzE/Glq36Fmj20v66EEWQ4n7Ojormpq2A3XOStUPFauE7tvHL/WH05s s1R8TJfOfxTZIbFpfuzC1e+jidLzj2aUNrVrvGHSsmO7B0Sf/9hGAeN5zrvSFtepFt6Z hpE2kG/rrL3/xX3aGijwKF/gXFsOi7iaSKUasPMTAV14KtYdbIRaaTFj35hj7cF4IY01 lDWAc9gDUDea0DKBalTv/t1b2Mujv0Ew9x2z/JxzPpCYDCwJrLBiPRt3ZS2eHwsiLUei cW6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=am4HvN2w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si29431645edb.287.2021.10.18.02.18.08; Mon, 18 Oct 2021 02:18:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=am4HvN2w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231149AbhJRJQH (ORCPT + 99 others); Mon, 18 Oct 2021 05:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbhJRJQF (ORCPT ); Mon, 18 Oct 2021 05:16:05 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE15C06161C; Mon, 18 Oct 2021 02:13:53 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id z20so68373167edc.13; Mon, 18 Oct 2021 02:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uYiwoLjIpwXhjE4+/22a2xkYUdGgH07KcD2ULSn0KKM=; b=am4HvN2wsY8dZhVj+hvASDKd7y7W33NU7V/XoEnE3+nhc/IUvQniFsDTIe6WFCxJOG dTjXGq47WsXdE7PuaDt5CFQtJMlliwg3uvdTeZWbKkm8zA41zCoCFfO3KhbW3S0sWCtO 9rTc962aI6CV9o6RuPaTEhhjBvN2LInLb9G7e4ViVict/rMbfNy75N5cPAkOIA8aAR1T XxDyLBA3Sq5+YX2v0oqaoiSCOWi2VhM73SyoyM+F+RAjv/aUl2u4f/ZU+AADTvOZ5Hx6 8yZ1P1XdDXc21Kud1BmK7uknKAX0EGHAMrpogHGwPfZkzxDdBz9U8zySX6KhoTD0t2rx 54Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYiwoLjIpwXhjE4+/22a2xkYUdGgH07KcD2ULSn0KKM=; b=ofNPUIVyRi80IsiMF7pf60yP+CcB17Hnu8XvlX7sjxuSpS7WrpBFNkvpfDlr4rok12 TcWa+OmzRHM79GMf6PsHmHf+5YNpZzolYLmTf/ns98eqphfijClkHj9fi25sgeXpSHUm Oa2MIUiTf41Zr0pdiB51rw26+fvh+Cd+mBmij+sso+fYMs78Smdb1F7nqO2neqQNxei0 JBhx+qYPQIybftOe/jlDQTlhDRn5NfYuQbWsUIM0XmDym21XN7UgurdKxsaiZkJRXcSu Bc3V8p/qt/EiOjL6h6iJidErWt9qZBE8gzKkjzoyUGKyQB7/cU9uOLmZXdHpVm+qESnv qJLA== X-Gm-Message-State: AOAM531GjLB5CNbiMa0tbLHgGKRgthBccgdtFsHo/ssA3nvoP3x65sUU rxWZuBQlZxU60spvO4oTtlxcPzdM/kdPwKRFjfk= X-Received: by 2002:a05:6402:5ca:: with SMTP id n10mr43501196edx.216.1634548432334; Mon, 18 Oct 2021 02:13:52 -0700 (PDT) MIME-Version: 1.0 References: <20211017125022.3100329-1-mudongliangabcd@gmail.com> <20211018091206.cflpumnfm3mt7aiy@pengutronix.de> In-Reply-To: <20211018091206.cflpumnfm3mt7aiy@pengutronix.de> From: Dongliang Mu Date: Mon, 18 Oct 2021 17:13:26 +0800 Message-ID: Subject: Re: [PATCH] can: xilinx_can: remove redundent netif_napi_del from xcan_remove To: Marc Kleine-Budde Cc: Appana Durga Kedareswara rao , Naga Sureshkumar Relli , Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , Michal Simek , linux-can@vger.kernel.org, "open list:NETWORKING [GENERAL]" , linux-arm-kernel@lists.infradead.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 5:12 PM Marc Kleine-Budde wrote: > > On 17.10.2021 20:50:21, Dongliang Mu wrote: > > Since netif_napi_del is already done in the free_candev, so we remove > > this redundent netif_napi_del invocation. In addition, this patch can > ^^^^^^^^^ > redundant, fixed (also in subject) :\ Sorry about this typo. > > match the operations in the xcan_probe and xcan_remove functions. > > > > Signed-off-by: Dongliang Mu > > Applied to linux-can-next/testing > > regards, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |