Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     f.fainelli@gmail.com, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     christophe.leroy@csgroup.eu, Stefan Agner <stefan@agner.ch>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] phy: micrel: ksz8041nl: do not use power down mode
Date:   Mon, 18 Oct 2021 11:42:58 +0200
Message-Id: <20211018094256.70096-1-francesco.dolcini@toradex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PnYLSskQfCcbwrCxk7AlRtcDR6e9r9pWTV/VbGQru3iL122xVF9tkT72Xl4m?=
 =?us-ascii?Q?wLL/lE2SUtGemPGOLVw1DUY0xrgZMTCAD4kKdcYb01fHRwC4ZrOVDim0XhaF?=
 =?us-ascii?Q?TMnyygINWOovdq6+mrO/KDdjb2pB9/1yo66ui43o+E1I6fW2UlIDtEh8c4Nx?=
 =?us-ascii?Q?E46R1EGm9LTTXtpYNcloVZrwBBn3QQXH2YMDwP7f5cPpscEC590TiQnhnFG3?=
 =?us-ascii?Q?QI0j0i+yBbMg6gdihXDJJD/+1r11N64nvGImx5IGx+rXBpG/RBqW7IOg7QJO?=
 =?us-ascii?Q?WF5mk9QAs6YQO2x1WCBWuRccPuVBPhtIUqzMPU55vOY0H6vrr/zN7idGm1F/?=
 =?us-ascii?Q?PPCc747vXD6yao+b//GXjgJJjfQ4AEx7gV99pl+5oATtMQ47aHrSUol6dbbq?=
 =?us-ascii?Q?eyTsmS+P4q05Ul8UcYEpSX2tq41Xj54Zjz2Ckk/+4C+KACM5Tph5g/r4LeNt?=
 =?us-ascii?Q?6E1+PoJIlCcAyRhdi98QX0BKqnQ0RoyPlECkTPK4mIp3KObZjypz1DnPlurT?=
 =?us-ascii?Q?X0XGwmfAwP/QBfTLD3ews1uGryyq/n3Zzcp+axIkdE07wioQCsUwDeTdCS48?=
 =?us-ascii?Q?VO0yyS8sXFvjCnFHoSfBvR4wzhXlrZxRvzXntisWHT63yARD8MM1WMBAT1zQ?=
 =?us-ascii?Q?gRqbJRTypq6ERC6+/8io7TWZ9Nk6zjprZjYfR6H0BJq3Fk/kr/J1hvXSXrCV?=
 =?us-ascii?Q?Mb6rI1E4u1yNuBCYgqRLIVkWV+n6VZcb+C5zt4LQafQNw4aPMzr4phScAvAs?=
 =?us-ascii?Q?NMN0Vmgb3r73hVBEPfZFfOvrLVzOTJYzaJxYqmQ+TLW3A1RQMsm20jn7rzxB?=
 =?us-ascii?Q?NHqxZ+TGBNsPtiqDD5j8+mbrqxefIsEbn9H8+QOFnlFZ0pD2o4OQTNZUKfAi?=
 =?us-ascii?Q?/FhVQW3sDwfIQ3Rs040qwFTKs/s4wu2g8jJ5uwucJA7JCrnNv6Y453KzMm7Z?=
 =?us-ascii?Q?oSMk+8Z68jUXRQQDg3z0za+finXofAhbcKxa/Sn31Sk2a5ZMgIOGdZmcFTKg?=
 =?us-ascii?Q?0O18xf4cgDMMZhEMvaIUK8gOaVwvgmq0vI1VzTruzJneEoynEAG0rJCKIehz?=
 =?us-ascii?Q?FbX4KztAqDafHejUniC+HYzlaOAHcid7w2WZva3bEnIxwX7JTkCLWN3H9m69?=
 =?us-ascii?Q?3GnDuUALltV2aMQ+hBDSVuKv6EBAHUAG1T7UXUwN8EOk7buLCk4clS2TVtDH?=
 =?us-ascii?Q?wOAIT9s24CnY/rCophGBetvK/RjnUDiVJPK9qebWj9mrS2CIS0/js3rhawDP?=
 =?us-ascii?Q?tB9XsboITpuKwGHvic65SkPtEhSdRe7VSmECTw9CfCqPOflIQ4BM81YBdnxM?=
 =?us-ascii?Q?3DD+SvSpawN8uGGqlufBPWDz?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3129c3f-1838-4c07-93d1-08d9921c55b1
X-MS-Exchange-CrossTenant-AuthSource: DBAPR05MB7445.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 09:47:44.4783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rRu/JrdCPWjYxvkeEmdrE/sVKzpSgbjIaJ4XRBByKDZLEfZFeKDE4AzwZP39M6hoEsUie6MMnV6ZFVcPDtwMxqUsA3Psmx5rdas2EbKxFfg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3238
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stefan Agner <stefan@agner.ch>

Some Micrel KSZ8041NL PHY chips exhibit continous RX errors after using
the power down mode bit (0.11). If the PHY is taken out of power down
mode in a certain temperature range, the PHY enters a weird state which
leads to continously reporting RX errors. In that state, the MAC is not
able to receive or send any Ethernet frames and the activity LED is
constantly blinking. Since Linux is using the suspend callback when the
interface is taken down, ending up in that state can easily happen
during a normal startup.

Micrel confirmed the issue in errata DS80000700A [*], caused by abnormal
clock recovery when using power down mode. Even the latest revision (A4,
Revision ID 0x1513) seems to suffer that problem, and according to the
errata is not going to be fixed.

Remove the suspend/resume callback to avoid using the power down mode
completely.

[*] https://ww1.microchip.com/downloads/en/DeviceDoc/80000700A.pdf

Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

---
There was a previous attempt to merge a similar patch, see
https://lore.kernel.org/all/2ee9441d-1b3b-de6d-691d-b615c04c69d0@gmail.com/.
---
 drivers/net/phy/micrel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index ff452669130a..1f28d5fae677 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1676,8 +1676,6 @@ static struct phy_driver ksphy_driver[] = {
 	.get_sset_count = kszphy_get_sset_count,
 	.get_strings	= kszphy_get_strings,
 	.get_stats	= kszphy_get_stats,
-	.suspend	= genphy_suspend,
-	.resume		= genphy_resume,
 }, {
 	.phy_id		= PHY_ID_KSZ8041RNLI,
 	.phy_id_mask	= MICREL_PHY_ID_MASK,
-- 
2.25.1