Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20211017160028.23318-1-christianshewitt@gmail.com>
User-agent: mu4e 1.6.6; emacs 27.1
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     Christian Hewitt <christianshewitt@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Matthias Reichl <hias@horus.com>
Subject: Re: [PATCH] ASoC: meson: implement driver_name for snd_soc_card in
 meson-card-utils
Date:   Mon, 18 Oct 2021 12:20:03 +0200
In-reply-to: <20211017160028.23318-1-christianshewitt@gmail.com>
Message-ID: <1j1r4ivdkc.fsf@starbuckisacylon.baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


On Sun 17 Oct 2021 at 16:00, Christian Hewitt <christianshewitt@gmail.com> wrote:

> Implement driver_name to provide an alternative to card_name for userspace
> configuration of Amlogic audio cards.
>
> Suggested-by: Matthias Reichl <hias@horus.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> The meson AIU/AXG drivers currently require alsa confs based on the board
> model name which is unique to each board. This is very flexible for audio
> use-cases, but not very maintainable for distros with a single use-case
> that need to support a large number of different Amlogic boards. Using a
> driver name to match the card conf instead of card/model name reduces the
> number of confs needed in the LibreELEC (Kodi) distro from 41 to 2.
>
>  sound/soc/meson/meson-card-utils.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c
> index 415cc0046e4b..29b0174f4b5c 100644
> --- a/sound/soc/meson/meson-card-utils.c
> +++ b/sound/soc/meson/meson-card-utils.c
> @@ -302,6 +302,7 @@ int meson_card_probe(struct platform_device *pdev)
>  
>  	priv->card.owner = THIS_MODULE;
>  	priv->card.dev = dev;
> +	priv->card.driver_name = dev->driver->name;
>  	priv->match_data = data;

I was preparing something similar to help with alsa-ucm so

Acked-by: Jerome Brunet <jbrunet@baylibre.com>

>  
>  	ret = snd_soc_of_parse_card_name(&priv->card, "model");