Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2859775pxb; Mon, 18 Oct 2021 03:31:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLksTY05JCN6liD0/1GnrNm1rOAx5GRKbUEvs8wH/vwb3c0tH4GsbFTqpi5cFr9T0Mq0Oj X-Received: by 2002:a63:86c6:: with SMTP id x189mr22672968pgd.451.1634553101996; Mon, 18 Oct 2021 03:31:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634553101; cv=none; d=google.com; s=arc-20160816; b=Fx+ANeiAhHNrP7Aj/hSV15nLrDQj9JafFYqo/Vbn97+ms4FM8I+rKjPDX/i4wlGMAB 23FTyMM74XZJxr8+bx/vfAabqsEBLuy+Ub3yfQrj9NhWYxh9w79DEVJ4PZPjiFzAISTs 2B18jF1AtRH/9BoggL2Gblt/rJ/hZzD4gBqZUX2aLO1HmaCSfbi6F6pZTGqnlxY3BfGB uKtPZv2nHUCKtO86i0M7McQ/IXKLxPBqTvPw8MguloXM7pW3WBsMQMNzJu+2tnCaMDAH zjNMuPpyofzIY4RA0mC5fqjYbqOyA6UOoZUXqWTHWyJtu570yGPvRVWyaXUUCsKEqXAK E0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1AwYQrQtINIHLBHKJv0/QAn0749ukb+7iyf1UOf/bbc=; b=sK86HslectiZakOmWg5ixbJl7z3XHouU52v4xUuoISvL98zVd3W4lkzX2dYtmSrTV0 n02F/XTtePRZbrE+HY3UkyZApiJxq3XaplOw0WK7jte1yT5lgQR0ySTU2hks7BS3LO6l P89Bh38IxG4icYR2bf4aayeh36n46aJxCPhkWOaRZbTm5Lc9LfQk4As2v+BslmICG8kO jn0KPxDpLCh8yM63Uwys3lfpBj5Vs3QZLiCDYb8m8CU0yMGjLzYlyXCdPZkRgjuDHo/v eOkg08skP6pyoJta7q95jwR85ZA/UUCMztE5HnSeVL/RAYCsEqBMguc3rD4HpSoa/yMu GtNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lIOFSCSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hk6si13542080pjb.0.2021.10.18.03.31.29; Mon, 18 Oct 2021 03:31:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lIOFSCSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbhJRI2t (ORCPT + 99 others); Mon, 18 Oct 2021 04:28:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:51006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbhJRI2s (ORCPT ); Mon, 18 Oct 2021 04:28:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E33B6108E; Mon, 18 Oct 2021 08:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634545597; bh=xOmAQitMBVIxD0P5lk/jGhQrjBA6gAaoj/EuLHLLD5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lIOFSCSL4nxT+TH63zGzjyvUoiQ3l7ZYBNDji+DqcQlmmawK+g8tNdDviPd//eq7/ ErUKdTZ2j561FgLszxENs8A6jzXzCNresZfiNONGS3WgUP4ElxzPpU8TNLa+A1hrAa bRAvEEw2tD9ldMLTlw7Lz+06yEcUiolJhNYQDxBQ= Date: Mon, 18 Oct 2021 10:26:34 +0200 From: Greg KH To: William Breathitt Gray Cc: David Lechner , jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere Message-ID: References: <20211017190106.3472645-1-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 05:19:02PM +0900, William Breathitt Gray wrote: > On Mon, Oct 18, 2021 at 08:06:58AM +0200, Greg KH wrote: > > On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote: > > > On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote: > > > > In the counter subsystem, we are already using sysfs_emit(), but there > > > > were a few places where we were still using sprintf() in *_show() > > > > functions. For consistency and added protections, use sysfs_emit() > > > > everywhere. > > > > > > > > Suggested-by: Greg KH > > > > Signed-off-by: David Lechner > > > > > > Acked-by: William Breathitt Gray > > > > Thanks, want me to take this directly on top of the previous pull > > request? > > > > greg k-h > > Yes, that should be a fine path forward for this patch. Great! Can you also ack the other patch from David as well? thanks, greg k-h