Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2860798pxb; Mon, 18 Oct 2021 03:33:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz0hq3AobMR6dEQd8XRtHXzXahGXB0f1waZohNcrNV64l7ZhZYd1ZxQuGUywQdoOPqJ8ro X-Received: by 2002:a17:90b:248:: with SMTP id fz8mr45528652pjb.157.1634553191571; Mon, 18 Oct 2021 03:33:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634553191; cv=none; d=google.com; s=arc-20160816; b=LliBzKlEJ6T4BJCZA6N/szPogIZidYo9jH5x1ox2BC2k6S21UqU45SNatsK9fnc5iG ncr0D8AK6GDPl4aV0Apw6WGHMKasKUNjMQf50IuXkj3SnG4CkeqPdAGf/9swSG0cUBFa rnQHtfeh3Wslsp7lK41s0xS1puyKf3fzRPgqpt3ixdJwrxDIvV9NwLUZKeOIcLtYDWYn vftxkVG+OO5B6Jmkre+t2T++eDJIRwUOojIXqRguQm9Q8YzRuX6Drl36dEkNkcUPD1NB IeF9RJjfwbnDgJjqsiiWX0ZiCxa+thKl0TnCmlAehF9j3BaT/ys5q2hSHjcaAUe4kVGQ 5NQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rwl8ks5Dht1UAV49Z0niSFrj7ZoB/NjqJVELlq4s5gI=; b=V5Wb3RzmKMDsCTsU90tj7K82K9JcGCog/eoHHT8fZhKDsk1eGFy4GTYZ/vlUD5hAu5 pJDNo7rP2NbehtQ00aJRvx3HvQb6FCpwMYBSczycBe2qI6NwXkIRLZiZXog6Rbpq0/RO VQ6wdedeknMmow8M4tkei30kbXoy/m/mcTM3Dh+sGkhKACf5yju8aOPa9heBVKxup5a4 15gfQ9VvlxOrwQaPZP81CzlvQgR1App3L5dNQT/qf7IRKm39EH/OoTxldohpIONbL0oc tHb1tBckCAkvw8IOdz+X4VhQXb1I4WeYv8JPuWGRc4hwMGQznyBRtxDnlt8zPCAHSRM2 JRWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=p7Vygy0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si12151750plg.186.2021.10.18.03.32.56; Mon, 18 Oct 2021 03:33:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=p7Vygy0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbhJRKce (ORCPT + 99 others); Mon, 18 Oct 2021 06:32:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbhJRKcd (ORCPT ); Mon, 18 Oct 2021 06:32:33 -0400 Received: from bombadil.infradead.org (unknown [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F9E8C06161C; Mon, 18 Oct 2021 03:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rwl8ks5Dht1UAV49Z0niSFrj7ZoB/NjqJVELlq4s5gI=; b=p7Vygy0na/9BqGnMQGwHihS/FC 4jM3crSFwcGX6eK0lD1SdmBSEetGLmWLuMWtR+d8S5DXdcDaPLG3wGxwBXA+zyd3JI5/+8O58B29+ hZurbb8sjCT3c2dBrXkFxM7xv2gFTkFRCQaYXiV04f+PwTmhUGkS0W10QpU5zv+2+atnQInmWkmiy yqVx6Ew+Z3vGPaS9cLRIXGPDKEznznNHd4RzIiTisiwctqxQNgWXR4v6uZf3W8RrhTlFg4sqo0Jw3 5jVRaTmTuwaMWToqib5wmqPjE8rbxBxRQvVM8ytZRc13lCzL7BSSl8oPwQWmo1uRO9utEr6gW/TfH KeMHsReA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcPuL-00F1VI-Gq; Mon, 18 Oct 2021 10:30:17 +0000 Date: Mon, 18 Oct 2021 03:30:17 -0700 From: Christoph Hellwig To: Cai Huoqing Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Remove the unused pci wrappers pci_pool_xxx() Message-ID: References: <20211018081629.151-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018081629.151-1-caihuoqing@baidu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 04:16:28PM +0800, Cai Huoqing wrote: > The wrappers around dma_pool_xxx should go away, so > remove the unused pci wrappers. > Prefer using dma_pool_xxx() instead of the pci wrappers > pci_pool_xxx(), and the use of pci_pool_xxx was already > removed. > > Signed-off-by: Cai Huoqing This looks good. But did this survive a few rounds of buildbot randomconfig build on various architectures? I'd be somewhat surprised if no file at all dependended on this implicit inclusion of dmapool.h.