Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Oct 2021 12:47:59 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>,
        Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: xilinx_can: remove redundent netif_napi_del from
 xcan_remove
Message-ID: <20211018104759.t5ib62kqjenjepkv@pengutronix.de>
References: <20211017125022.3100329-1-mudongliangabcd@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="laxzct2z5txsqxzw"
Content-Disposition: inline
In-Reply-To: <20211017125022.3100329-1-mudongliangabcd@gmail.com>
Precedence: bulk


--laxzct2z5txsqxzw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 17.10.2021 20:50:21, Dongliang Mu wrote:
> Since netif_napi_del is already done in the free_candev, so we remove
> this redundent netif_napi_del invocation. In addition, this patch can
> match the operations in the xcan_probe and xcan_remove functions.
>=20
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>  drivers/net/can/xilinx_can.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
> index 3b883e607d8b..60a3fb369058 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -1848,7 +1848,6 @@ static int xcan_remove(struct platform_device *pdev)
> =20
>  	unregister_candev(ndev);
>  	pm_runtime_disable(&pdev->dev);
> -	netif_napi_del(&priv->napi);
>  	free_candev(ndev);
> =20
>  	return 0;

Fixed the following error:

| drivers/net/can/xilinx_can.c: In function =E2=80=98xcan_remove=E2=80=99:
| drivers/net/can/xilinx_can.c:1847:20: error: unused variable =E2=80=98pri=
v=E2=80=99 [-Werror=3Dunused-variable]
|  1847 |  struct xcan_priv *priv =3D netdev_priv(ndev);
|       |                    ^~~~

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--laxzct2z5txsqxzw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFtUNwACgkQqclaivrt
76lG4Af/egULUDAzVZK2yX285A7T6hDs6mdkip8Z7JDRg+Jdhjix258HzSYS7Qdd
Sxp1DUGn16KE+9HlJn4BQ/5LosSc3RixQxegHKLDa09BmlKD7qSKakSySMinQk6c
M9GoO1wRFH7VcXfou4p3TtdcOkocsk/AxRac12J5cufxzi4yDskRj0+NzW+tP1RJ
8pL7Q8eXZezsD04FEX2PyJHOyn8VDnkfxILcwdtpTIzhwDakYzI0PmSWRekya5jK
gk6lkVWPVdo2ZH6JwsGfNNAx+yi8A/4h1o1KeK7C5D416PLcU+HPWCTNMEoee7bK
uSHXM95bWxiWLJDpB1AqDx8FHrGkLQ==
=sQuT
-----END PGP SIGNATURE-----

--laxzct2z5txsqxzw--