Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [peterz-queue:locking/core 41/43] kernel/locking/rwsem.c:1023:19:
 error: variable has incomplete type 'enum owner_state'
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     kernel test robot <lkp@intel.com>, llvm@lists.linux.dev,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
References: <202110152145.nWCivoXy-lkp@intel.com>
 <8c0f011a-db83-001e-3cce-326cb8228a75@windriver.com>
 <YW1VQ80yoUmWC8Zv@hirez.programming.kicks-ass.net>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <f02c956e-9479-47d9-9a7d-5d50fadaa41c@windriver.com>
Date:   Mon, 18 Oct 2021 19:23:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YW1VQ80yoUmWC8Zv@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmdodXowdjdORzk4eXlvUVpRTTZwMkIrS2JQVk4vc2d3cXlUYkZjV1psdTJu?=
 =?utf-8?B?SkgrUVE1Y2RPVmdrNExpUHVwSXFHRUVqVUxlcUt6SEJwRTBRQnp3di90aGZ2?=
 =?utf-8?B?TUNBR2dOck9JMk1pM2NIelAvQjA4bHNZUUZkVllzRXhqNTI4ZTFhZGU2dnVS?=
 =?utf-8?B?bS8ycHZwdUY1ZXhTYXlqWGM0OG14ZitEdDkwb3VDZTlkbnRPUTJ5aitWSHd2?=
 =?utf-8?B?d2Y4QTcxazhMWXRNVUx0aytFYTM2TkNnNDJlN1M1eURiMFpNMkVtOU5XNzNy?=
 =?utf-8?B?UkNlU0x2QzlqRlhIN0VGK08xMkdxY21tSVEvYjY2MUx0eTdLZVY4Z0UxZTRJ?=
 =?utf-8?B?c0N6V2lRdmlUMEVpTTNmOG4vVzdNdER3QXhER1psTHFMc2dtQURyOS93MWM4?=
 =?utf-8?B?c2VRTVJ3VWJxbzNXRmVOaStPMXhrWmpyNkJJUmI3ZnpHbXpkb2dyNXpaZ0xv?=
 =?utf-8?B?SHYxa3IxRkVwek1KcWg1Mkxtc1NMNG05emxFRFZjYWdnMnZreEFoUGVsVUlR?=
 =?utf-8?B?RW9sWG5VclpUSXRPeUQrcE9CT1c2bm1sRjNnd3NCNk94eVBFdHdxcnRKYktQ?=
 =?utf-8?B?WElBRlMyMG4xbzNMNGtLZFhUUXdRM3BIaUNoMUwxM0NUd1lneVlyR21IZmZX?=
 =?utf-8?B?Sll6YUxtVjVXNGZ4UjR6cDVQQU9mL3kxTTJYNUFuZW9Jd3JBM1lpN3ZmTlEz?=
 =?utf-8?B?ZFJQSFphSXd4Nkw4eko4RWlXb1l1a05jTEFaLzEvMzQ2b1Q2eUZPN3NFUVRS?=
 =?utf-8?B?OXRweEVvU08zc2Q0eDAxRWQ4LzFidGMyTVdoUllNTVBRRGdvalRPUWNZVzhK?=
 =?utf-8?B?RzluSzhlS3hWMnBOMnBUcjF4WjhWNllHNXU3WFo4a3NCYmdVMWlpZFpSQ3pi?=
 =?utf-8?B?cFV3ZWkxeUJuVUIwa1E5VDhXVExHRkFqSk9wbFhtUGpHUGdSa09tNzFpSVF6?=
 =?utf-8?B?eUx0cC9USXhheEpkMHpCNnhGRXJlU3VGb2p5a3E0SUdOSlRwM1RaOTdhSmlz?=
 =?utf-8?B?TW1NUStRZnJuU0Yxa2hNQmMrWkovekpWTitnUXBvb0N0czk0bGs0Q0ZBMnhG?=
 =?utf-8?B?SG9XV2gxU2pOMHBxd1ppcXBZTFQyNlJaU1JaMjBuYmNrbGFhbTVWWTlLMTRS?=
 =?utf-8?B?YlBXTWdoV0M2c1pjY3B0T2FsVUt1UWhCenllVnNEN2JLVG1iUHFjUWRhNUJK?=
 =?utf-8?B?VTRGL0dQempidWQyemRJRm00ei84VDNMeVJ2ZVpiOVJiM2F2RVp2OVp4YWx1?=
 =?utf-8?B?L2pKaXdBZGI1MEZCaURLQjZFYjl1TkRqdWxiOE1xMEhRYm50RExDR055aTVB?=
 =?utf-8?B?aHBuRG9qUHgvWFZrc3V1OWZGRVk1QkJnaHRlUi9XVytVNW9kekZISVI4djZS?=
 =?utf-8?B?SnQyT096TWVFT1RhUGZSb2pPN2FQUlFWUWxJMWdRYTZDZzJZK0RGRWpGMm1k?=
 =?utf-8?B?M1VTUmZNTVN3TTJrUUhXcTNWRllTTmdXOGFLNWN3UkJjQmI3a0g1SmQwYnkr?=
 =?utf-8?B?WTJ0em9lbGwzYm5EREZCWWZ0cUhSaXNpdE80ZG1DVlUzeFcvV3NzcmEvMUpo?=
 =?utf-8?B?Y2NpMWxCS01UemRZN1YyUUwxZXpnQkkrcVl6T2ZpTzBtZnZsTjIvMTRWei9F?=
 =?utf-8?B?M2hjL0dwUlVrVnA4RVBuQ3ZFQ25IKzdSWmp1TDczazlsSlNBemNzc0JsWllQ?=
 =?utf-8?B?VzUvSUdKdTh1WXFpSjYxQ1dQMWFtS2ZOTm1KSFVUZThtRDQ1UG1QbEdOQ3ht?=
 =?utf-8?Q?HjpWCwxfnrqy7ec+6pd1YBY1Yq21+p10ZYKFh4e?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8e672c-d733-47c1-3d94-08d99229ac10
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:23:12.8601
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbb/lllZ7oyz+S6ejoLI2TWqrz48mkRtGhQf8uXMkmY/BE8/cJIWcXoRq/rX3C+Bnm1Yt++kZfS3JEvxbVHVag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3593
X-Proofpoint-GUID: v-1PvMHUA7pH7JWEt8PUvEpSiJ3hVSbp
X-Proofpoint-ORIG-GUID: v-1PvMHUA7pH7JWEt8PUvEpSiJ3hVSbp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-18_03,2021-10-14_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=868
 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0
 phishscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0
 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109230001 definitions=main-2110180070
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/18/21 7:06 PM, Peter Zijlstra wrote:
>>
>> Hi Peter,
>>
>> I send a patch named ("locking/rwsem: Introduce __rwsem_spin_on_owner()")
>> for fixing this.
> How about we do something like this instead? That makes the whole
> CONFIG_RWSEM_SPIN_ON_OWNER=n side more consistent.

I have no problem， it's more consistent indeed.

Cheers，
Yanfei