Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK
To:     Arnd Bergmann <arnd@kernel.org>, Rob Clark <robdclark@gmail.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Randy Dunlap <rdunlap@infradead.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Alex Elder <elder@linaro.org>,
        Akhil P Oommen <akhilpo@codeaurora.org>,
        Rajeev Nandan <rajeevny@codeaurora.org>,
        Abhinav Kumar <abhinavk@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
        freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20211013144308.2248978-1-arnd@kernel.org>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <25ccdc75-67da-a955-b8ef-641a2f007d13@amd.com>
Date:   Mon, 18 Oct 2021 13:36:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211013144308.2248978-1-arnd@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmFCM3NaRUorRHJRdXlaQkQwZFZvZXl5OUpwTCtOTFpmcW1Lazd2L05iLzZt?=
 =?utf-8?B?U3JSUnduaW5OSlpZUmlyL3ZPQnJnUXh5RmMvQ0w2RzJJRFZoVU1uRkRZeklX?=
 =?utf-8?B?eU9xQXJ3N1NUNWQrQ1pCUXpxTC9YUURwaEx0QkFBVDE3Nmk0R2gxclBVcVhZ?=
 =?utf-8?B?d3RsYW1FYitMQkprdTVYUWVLYllnUVlOT1UrT2lwMkNUYkZ5QkJqWTZhZVFM?=
 =?utf-8?B?NCsvZ1hTcGVoMjgvNzl6VFBOUHlVeElCdWpQTHRVSVBHOHBDVU83UGpGMU1a?=
 =?utf-8?B?UHhSNS8rU1BWd0QvV3I5RVhIY0MycVBQMFM1UU9tOTdyZGp5bVFmT3ByM3ZX?=
 =?utf-8?B?M2hyd240bXBqakYvVCt4TlhoMWhIYldWNzlrbWFNbi9qSnFDRnBKbUtGZGpv?=
 =?utf-8?B?TkxIMUswdVYvWlZuNEliVVp4NzArd0dISUUwVGhBeXV2WG9Pb3RlZHEyUWRl?=
 =?utf-8?B?Rmxob0ZYTjlVWWZpWjkySzJtZmw0WUJzajJFTTlvUTB5M1hUNHZTdW9zK0xY?=
 =?utf-8?B?TCtISTFFanF2VjVTZ3BHOStXYmlKTVBuUVIwVWJGL2lDNVJTMVd5aUNqNHo2?=
 =?utf-8?B?MTZLRkMyTHFwSW9wNFQ2b0RDc3RhTU85SHdmSkRvSFBteTMvUGVidFQraU94?=
 =?utf-8?B?VVRhNktKdHdoU3l3QXJDeTV0TjlIVHRhcnNZNUtHQmQ0VjlpUFVFRGpmSHB4?=
 =?utf-8?B?UTc2cDRRMitDeUsrS1VqdkQ3cFhWSi9yL2tuNWl2NGYwejM5Q1o1Ni83VGFQ?=
 =?utf-8?B?eTJ6V2I0TkViQVMxeTN3cVlIb0ZaMUlKenNuVXl0bDQvN2dBcXJNTzdzMVJ3?=
 =?utf-8?B?THVXOFBrTFp0UENqZTBSMzVpNGgvL3B1a2NDZ3lhRWRuOWdRZmxYVUtUQ3Vk?=
 =?utf-8?B?SGFlYkkzblpEN0VURHRGVC90bklmTTE5MThaaUlZMHlvS1JJWEJKTUYycjFa?=
 =?utf-8?B?VUdwSEFOTUxaVGpvMHNOUjkwaFFoWHZSdkZiZ0NoYXBrMDQ3VzFxZjA4QUJC?=
 =?utf-8?B?c0R0VGFSY1QxcnFvRVd5bWZnMWNOaUJ1WHV0bERJZFp6VXplQmVOb2Qvdzc5?=
 =?utf-8?B?LzNBdEFkdFZLWDRjKzRFc3UyeER6WEdxYlQ0c2h0NVZpNTcvbVd3UnVxc1h1?=
 =?utf-8?B?VU5hcVRPMGlIeHV3VzI4SEw3NnlEY2ZuaTB2ZTNTUlVRQ1ltRk90NU1TaE1y?=
 =?utf-8?B?blU0NkgwWmVnQytyTTRBUThtUzBrNnBsNytLL2dWWlNXZDh5dXJFZ1BHVzRK?=
 =?utf-8?B?KzZuZzVHRUxHUSt6Zlk2VHRIc05MOGR6NTRsWkVEVXQzSDdsRTIzVm5IdDl2?=
 =?utf-8?B?T0J2K3p5SlkvZ3NCRkZJM29VNGJHTnhnM0RpZERYQnU4QTJFSWNlVU5Sc3BK?=
 =?utf-8?B?dUhxRXNIeGIwWEY4djZZWVhRZWRyc0RpSkx1TnVCZGFiTTE2YWd2WDdtVUdD?=
 =?utf-8?B?WXlCZ2NEaEZZWG1BR0JWL3gvM1dNWjU5a2swbWNIV3A5OEhjYk5OZm5CMDhZ?=
 =?utf-8?B?MGxaNCsrMy9VRWlHcitOVS9heWQ5QmNsa2lEYUNjS0tqMzMyRUYyTWRhSUw1?=
 =?utf-8?B?c05KUHRRM0N4aGlsSWdqdEZycjMrN2xJaFdHSkZ6dlFzUFZGUDUrSHNaUS83?=
 =?utf-8?B?UTdEZlZBNk9TMVRmVWp6bERHcG9MOG5HQmZpTlVMbmhmTzdnTjU1QnV5SzNU?=
 =?utf-8?B?Ry9qcVZIRWRSTG9aUXFGZStTSjBiQlRWZjFRZkhqYld5QW9KZkZoY3FrcHN6?=
 =?utf-8?B?MGlMRzQ4aXR0ZkE4T2t2ckpteDVyeUlLYmdaam9tUFl6ajRyUTBtRU1BU2Rk?=
 =?utf-8?B?NERqaFJOVU12bXJ2UStFdTRiRXlnYkFvR2M5RkY4YUwxbllsa09sR2FTbnAz?=
 =?utf-8?Q?Tb1ZlPYjlj6qX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbfc7d4-631a-4743-e3f8-08d9922b9601
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:36:55.1679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 55dR+0DOlP7nJ9mc98OZiMQsWiilyxbUQgnxxXafbm12vGs/oYeIRQWQI8QS/81p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1149
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.10.21 um 16:42 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_COMMON_CLOCK is disabled, the 8996 specific
> phy code is left out, which results in a link failure:
>
> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>
> This was only exposed after it became possible to build
> test the driver without the clock interfaces.
>
> Make COMMON_CLK a hard dependency for compile testing,
> and simplify it a little based on that.
>
> Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/msm/Kconfig  | 2 +-
>   drivers/gpu/drm/msm/Makefile | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index f5107b6ded7b..cb204912e0f4 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -4,8 +4,8 @@ config DRM_MSM
>   	tristate "MSM DRM"
>   	depends on DRM
>   	depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
> +	depends on COMMON_CLK
>   	depends on IOMMU_SUPPORT

We also need a "depends on MMU" here because some automated test is now 
trying to compile the driver on parisc as well.

I have absolutely no idea how a platform can have IOMMU but no MMU 
support but it indeed seems to be the case here.

Regards,
Christian.

> -	depends on (OF && COMMON_CLK) || COMPILE_TEST
>   	depends on QCOM_OCMEM || QCOM_OCMEM=n
>   	depends on QCOM_LLCC || QCOM_LLCC=n
>   	depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n
> diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile
> index 904535eda0c4..bbee22b54b0c 100644
> --- a/drivers/gpu/drm/msm/Makefile
> +++ b/drivers/gpu/drm/msm/Makefile
> @@ -23,8 +23,10 @@ msm-y := \
>   	hdmi/hdmi_i2c.o \
>   	hdmi/hdmi_phy.o \
>   	hdmi/hdmi_phy_8960.o \
> +	hdmi/hdmi_phy_8996.o \
>   	hdmi/hdmi_phy_8x60.o \
>   	hdmi/hdmi_phy_8x74.o \
> +	hdmi/hdmi_pll_8960.o \
>   	edp/edp.o \
>   	edp/edp_aux.o \
>   	edp/edp_bridge.o \
> @@ -37,6 +39,7 @@ msm-y := \
>   	disp/mdp4/mdp4_dtv_encoder.o \
>   	disp/mdp4/mdp4_lcdc_encoder.o \
>   	disp/mdp4/mdp4_lvds_connector.o \
> +	disp/mdp4/mdp4_lvds_pll.o \
>   	disp/mdp4/mdp4_irq.o \
>   	disp/mdp4/mdp4_kms.o \
>   	disp/mdp4/mdp4_plane.o \
> @@ -117,9 +120,6 @@ msm-$(CONFIG_DRM_MSM_DP)+= dp/dp_aux.o \
>   	dp/dp_audio.o
>   
>   msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o
> -msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o
> -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_pll_8960.o
> -msm-$(CONFIG_COMMON_CLK) += hdmi/hdmi_phy_8996.o
>   
>   msm-$(CONFIG_DRM_MSM_HDMI_HDCP) += hdmi/hdmi_hdcp.o
>